c/pve-qemu-qoup
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add format attributes to function candidates

Browse Source 
Add format attributes to functions that take printf-like arguments. This
provides additional compile-time checking that the correct parameters
are passed to the functions.

This fixes compiler warnings generated by the -Wsuggest-attribute=format
flag.

Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
This commit is contained in:
Filip Schauer 2023-08-07 15:19:42 +02:00 committed by Fiona Ebner
parent df47146afe
commit b8b4ce0480
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
debian/patches/pve/0017-PVE-add-savevm-async-for-background-state-snapshots.patch vendored
View File

@ -275,7 +275,7 @@ index 0000000000..ac1fac6378
+ return ret; + return ret;
+} +}
+ +
+static void save_snapshot_error(const char *fmt, ...) +static void G_GNUC_PRINTF(1, 2) save_snapshot_error(const char *fmt, ...)
+{ +{
+ va_list ap; + va_list ap;
+ char *msg; + char *msg;

6
debian/patches/pve/0027-PVE-Backup-add-vma-backup-format-code.patch vendored
View File

@ -2314,13 +2314,13 @@ index 0000000000..304f02bc84
+ ret = blk_co_preadv(job->target, start * VMA_CLUSTER_SIZE, + ret = blk_co_preadv(job->target, start * VMA_CLUSTER_SIZE,
+ readlen, &qiov, 0); + readlen, &qiov, 0);
+ if (ret < 0) { + if (ret < 0) {
+ vma_writer_set_error(job->vmaw, "read error", -1); + vma_writer_set_error(job->vmaw, "read error");
+ goto out; + goto out;
+ } + }
+ +
+ size_t zb = 0; + size_t zb = 0;
+ if (vma_writer_write(job->vmaw, job->dev_id, start, buf, &zb) < 0) { + if (vma_writer_write(job->vmaw, job->dev_id, start, buf, &zb) < 0) {
+ vma_writer_set_error(job->vmaw, "backup_dump_cb vma_writer_write failed", -1); + vma_writer_set_error(job->vmaw, "backup_dump_cb vma_writer_write failed");
+ goto out; + goto out;
+ } + }
+ } + }
@ -2757,7 +2757,7 @@ index 0000000000..1b62859165
+int coroutine_fn vma_writer_flush_output(VmaWriter *vmaw); +int coroutine_fn vma_writer_flush_output(VmaWriter *vmaw);
+ +
+int vma_writer_get_status(VmaWriter *vmaw, VmaStatus *status); +int vma_writer_get_status(VmaWriter *vmaw, VmaStatus *status);
+void vma_writer_set_error(VmaWriter *vmaw, const char *fmt, ...); +void vma_writer_set_error(VmaWriter *vmaw, const char *fmt, ...) G_GNUC_PRINTF(2, 3);
+ +
+ +
+VmaReader *vma_reader_create(const char *filename, Error **errp); +VmaReader *vma_reader_create(const char *filename, Error **errp);