From b8b4ce04809a78bc5d36443999197a49d18b8b1e Mon Sep 17 00:00:00 2001 From: Filip Schauer Date: Mon, 7 Aug 2023 15:19:42 +0200 Subject: [PATCH] Add format attributes to function candidates Add format attributes to functions that take printf-like arguments. This provides additional compile-time checking that the correct parameters are passed to the functions. This fixes compiler warnings generated by the -Wsuggest-attribute=format flag. Signed-off-by: Filip Schauer --- ...VE-add-savevm-async-for-background-state-snapshots.patch | 2 +- .../pve/0027-PVE-Backup-add-vma-backup-format-code.patch | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/debian/patches/pve/0017-PVE-add-savevm-async-for-background-state-snapshots.patch b/debian/patches/pve/0017-PVE-add-savevm-async-for-background-state-snapshots.patch index 7be1af4..762ba9b 100644 --- a/debian/patches/pve/0017-PVE-add-savevm-async-for-background-state-snapshots.patch +++ b/debian/patches/pve/0017-PVE-add-savevm-async-for-background-state-snapshots.patch @@ -275,7 +275,7 @@ index 0000000000..ac1fac6378 + return ret; +} + -+static void save_snapshot_error(const char *fmt, ...) ++static void G_GNUC_PRINTF(1, 2) save_snapshot_error(const char *fmt, ...) +{ + va_list ap; + char *msg; diff --git a/debian/patches/pve/0027-PVE-Backup-add-vma-backup-format-code.patch b/debian/patches/pve/0027-PVE-Backup-add-vma-backup-format-code.patch index 8471a6f..3c3ac54 100644 --- a/debian/patches/pve/0027-PVE-Backup-add-vma-backup-format-code.patch +++ b/debian/patches/pve/0027-PVE-Backup-add-vma-backup-format-code.patch @@ -2314,13 +2314,13 @@ index 0000000000..304f02bc84 + ret = blk_co_preadv(job->target, start * VMA_CLUSTER_SIZE, + readlen, &qiov, 0); + if (ret < 0) { -+ vma_writer_set_error(job->vmaw, "read error", -1); ++ vma_writer_set_error(job->vmaw, "read error"); + goto out; + } + + size_t zb = 0; + if (vma_writer_write(job->vmaw, job->dev_id, start, buf, &zb) < 0) { -+ vma_writer_set_error(job->vmaw, "backup_dump_cb vma_writer_write failed", -1); ++ vma_writer_set_error(job->vmaw, "backup_dump_cb vma_writer_write failed"); + goto out; + } + } @@ -2757,7 +2757,7 @@ index 0000000000..1b62859165 +int coroutine_fn vma_writer_flush_output(VmaWriter *vmaw); + +int vma_writer_get_status(VmaWriter *vmaw, VmaStatus *status); -+void vma_writer_set_error(VmaWriter *vmaw, const char *fmt, ...); ++void vma_writer_set_error(VmaWriter *vmaw, const char *fmt, ...) G_GNUC_PRINTF(2, 3); + + +VmaReader *vma_reader_create(const char *filename, Error **errp);