c/mirror_zfs
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_zfs.git synced 2026-03-22 08:51:30 +03:00
Code Issues Packages Projects Releases Wiki Activity
10,376 Commits 2 Branches 50 Tags 118 MiB
C 70.2%
Shell 19.9%
Assembly 5.1%
M4 2%
Python 1.6%
Other 1.2%
6218a5eb03
Go to file
shuppy 6218a5eb03 Fix history logging for zpool create -t 
`zpool create` is supposed to log the command to the new pool’s history,
as a special record that never gets evicted from the ring buffer. but
when you create a pool with `zpool create -t`, no such record is ever
logged (#18102). that bug may be the cause of issues like #16408.

`zpool create -t` (83e9986f6e) and `zpool
import -t` (26b42f3f9d) are both designed
to override the on-disk zpool property `name` with an in-core
“temporary” name, but they work somewhat differently under the hood.

importing with a temporary name sets `spa->spa_import_flags |=
ZFS_IMPORT_TEMP_NAME` in ZFS_IOC_POOL_IMPORT, which tells
spa_write_cachefile() and spa_config_generate() to use the
ZPOOL_CONFIG_POOL_NAME in `spa->spa_config` instead of `spa->spa_name`.

creating with a temporary name permanently(!) sets the internal zpool
property `tname` (ZPOOL_PROP_TNAME) in the `zc->zc_nvlist_src` of
ZFS_IOC_POOL_CREATE, which tells zfs_ioc_pool_create()
(4ceb8dd6fd) and spa_create() to use that
name instead of `zc->zc_name`, then sets `spa->spa_import_flags |=
ZFS_IMPORT_TEMP_NAME` like an import.

but zfsdev_ioctl_common() fails to check for `tname` when saving the
pool name to `zfs_allow_log_key`, so when we call ZFS_IOC_LOG_HISTORY,
we call spa_open() on the wrong pool name and get ENOENT, so the logging
silently fails.

this patch fixes #18102 by checking for `tname` in zfsdev_ioctl_common()
like we do in zfs_ioc_pool_create().

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <alexander.motin@TrueNAS.com>
Signed-off-by: delan azabani <dazabani@igalia.com>
Closes #18118  
Closes #18102
2026-02-05 13:48:31 -08:00
.github Remove the obsolete FreeBSD 14.2-RELEASE from CI 2026-02-05 13:48:31 -08:00
cmd cmd/zfs: clone: accept -u to not mount newly created datasets 2026-02-05 13:48:31 -08:00
config Linux 6.19: replace i_state access with inode_state_read_once() 2026-02-05 13:48:31 -08:00
contrib Bump SONAME of libzfs and libzpool 2025-11-12 13:07:28 -08:00
etc docs: fix a few small typos (#17804) 2025-10-21 09:50:43 -07:00
include DDT: Add locking for table ZAP destruction 2026-02-05 13:48:31 -08:00
lib Fix snapshot automount expiry cancellation deadlock 2025-12-10 10:21:29 -08:00
man cmd/zfs: clone: accept -u to not mount newly created datasets 2026-02-05 13:48:31 -08:00
module Fix history logging for zpool create -t 2026-02-05 13:48:31 -08:00
rpm Bump SONAME of libzfs and libzpool 2025-11-12 13:07:28 -08:00
scripts CI: exclude signed-off-by/reviewed-by from 72 char limit 2025-12-10 10:21:29 -08:00
tests Fix history logging for zpool create -t 2026-02-05 13:48:31 -08:00
udev zvol_id: make array length properly known at compile time 2025-12-10 10:21:29 -08:00
.editorconfig Add an .editorconfig; document git whitespace settings 2020-01-27 13:32:52 -08:00
.gitignore Packaging: Auto-generate changelog during configure (#15528) 2023-11-16 08:58:47 -08:00
.gitmodules .gitmodules: link to openzfs github repository 2021-04-12 09:37:23 -07:00
.mailmap mailmap/AUTHORS: update with recent new contributors 2025-11-12 13:04:35 -08:00
AUTHORS mailmap/AUTHORS: update with recent new contributors 2025-11-12 13:04:35 -08:00
autogen.sh autogen.sh: remove workaround for automake <1.14, needed for EL <=7 2025-11-12 13:05:16 -08:00
CODE_OF_CONDUCT.md Documentation corrections 2022-12-22 11:34:28 -08:00
configure.ac Linux build: handle CONFIG_OBJTOOL_WERROR=y 2025-06-16 08:12:09 -07:00
copy-builtin copy-builtin: add hooks with sed/>> 2022-05-10 10:17:43 -07:00
COPYRIGHT Fix typos 2020-06-09 21:24:09 -07:00
LICENSE Update build system and packaging 2018-05-29 16:00:33 -07:00
Makefile.am Install zarcstat and zarcsummary symlinks in Makefile 2025-09-09 17:05:30 -07:00
META Tag 2.4.0 2025-12-18 09:31:29 -08:00
NEWS Fix NEWS file 2020-08-26 21:44:41 -07:00
NOTICE Update build system and packaging 2018-05-29 16:00:33 -07:00
README.md Fix capitalization typo in README.md 2025-11-12 13:05:35 -08:00
RELEASES.md Update RELEASES.md LTS release to 2.2 2025-01-17 11:04:36 -05:00
TEST Remove CI builder customization from TEST 2020-03-16 10:46:03 -07:00
zfs.release.in Move zfs.release generation to configure step 2012-07-12 12:22:51 -07:00

README.md

img

OpenZFS is an advanced file system and volume manager which was originally developed for Solaris and is now maintained by the OpenZFS community. This repository contains the code for running OpenZFS on Linux and FreeBSD.

codecov coverity

Official Resources

Installation

Full documentation for installing OpenZFS on your favorite operating system can be found at the Getting Started Page.

Contribute & Develop

We have a separate document with contribution guidelines.

We have a Code of Conduct.

Release

OpenZFS is released under a CDDL license. For more details see the NOTICE, LICENSE and COPYRIGHT files; UCRL-CODE-235197

Supported Kernels

  • The META file contains the officially recognized supported Linux kernel versions.
  • Supported FreeBSD versions are any supported branches and releases starting from 13.0-RELEASE.