Go to file
Rob Norris 3b64a9619f FreeBSD: zfs_putpages: don't undirty pages until after write completes
In syncing mode, zfs_putpages() would put the entire range of pages onto
the ZIL, then return VM_PAGER_OK for each page to the kernel. However,
an associated zil_commit() or txg sync had not happened at this point,
so the write may not actually be on disk.

So, we rework that case to use a ZIL commit callback, and do the
post-write work of undirtying the page and signaling completion there.
We return VM_PAGER_PEND to the kernel instead so it knows that we will
take care of it.

The original version of this (238eab7dc1) copied the Linux model and did
the cleanup in a ZIL callback for both async and sync. This was a
mistake, as FreeBSD does not have a separate "busy for writeback" flag
like Linux which keeps the page usable. The full sbusy flag locks the
entire page out until the itx callback fires, which for async is after
txg sync, which could be literal seconds in the future.

For the async case, the data is already on the DMU and the in-memory
ZIL, which is sufficient for async writeback, so the old method of
logging it without a callback, undirtying the page and returning is more
than sufficient and reclaims that lost performance.

Sponsored-by: Klara, Inc.
Sponsored-by: Wasabi Technology, Inc.
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Mark Johnston <markj@FreeBSD.org>
Signed-off-by: Rob Norris <rob.norris@klarasystems.com>
Closes #17533
2025-08-12 22:41:17 -04:00
.github FreeBSD 15.0 is now "PRERELEASE" 2025-08-12 17:24:22 -07:00
cmd zed: prettify slack notification message 2025-08-12 17:24:15 -07:00
config config: Avoid void main() in toolchain-simd.m4 2025-08-12 17:23:57 -07:00
contrib Introduce zfs rewrite subcommand (#17246) 2025-08-07 12:34:28 -04:00
etc SPDX: license tags: MIT 2025-04-16 09:59:44 -07:00
include FreeBSD: zfs_putpages: don't undirty pages until after write completes 2025-08-12 22:41:17 -04:00
lib Validate mountpoint on path-based unmount using statx 2025-08-05 12:27:25 -04:00
man Introduce zfs rewrite subcommand (#17246) 2025-08-07 12:34:28 -04:00
module FreeBSD: zfs_putpages: don't undirty pages until after write completes 2025-08-12 22:41:17 -04:00
rpm rpm: don't list /sbin/zgenhostid twice in %files 2025-08-12 17:24:08 -07:00
scripts Linux build: handle CONFIG_OBJTOOL_WERROR=y 2025-08-07 13:10:33 -04:00
tests ZTS: mmap_ftruncate test to confirm async writeback behaviour 2025-08-12 17:23:35 -07:00
udev Update 69-vdev.rules.in 2025-05-28 16:00:28 -07:00
.editorconfig Add an .editorconfig; document git whitespace settings 2020-01-27 13:32:52 -08:00
.gitignore Packaging: Auto-generate changelog during configure (#15528) 2023-11-16 08:58:47 -08:00
.gitmodules .gitmodules: link to openzfs github repository 2021-04-12 09:37:23 -07:00
.mailmap AUTHORS/mailmap: update with new contributors 2025-05-28 16:00:28 -07:00
AUTHORS AUTHORS/mailmap: update with new contributors 2025-05-28 16:00:28 -07:00
autogen.sh Ubuntu 22.04 integration: ShellCheck 2022-11-18 11:24:48 -08:00
CODE_OF_CONDUCT.md Documentation corrections 2022-12-22 11:34:28 -08:00
configure.ac Linux build: handle CONFIG_OBJTOOL_WERROR=y 2025-08-07 13:10:33 -04:00
copy-builtin copy-builtin: add hooks with sed/>> 2022-05-10 10:17:43 -07:00
COPYRIGHT Fix typos 2020-06-09 21:24:09 -07:00
LICENSE Update build system and packaging 2018-05-29 16:00:33 -07:00
Makefile.am spdxcheck: program to check SPDX license tags 2025-04-16 09:59:45 -07:00
META Linux 6.16 compat: META 2025-08-12 17:24:19 -07:00
NEWS Fix NEWS file 2020-08-26 21:44:41 -07:00
NOTICE Update build system and packaging 2018-05-29 16:00:33 -07:00
README.md FreeBSD: remove support for FreeBSD < 13.0-RELEASE (#16372) 2024-08-05 16:56:45 -07:00
RELEASES.md Update RELEASES.md LTS release to 2.2 2025-02-25 22:27:10 +05:00
TEST Remove CI builder customization from TEST 2020-03-16 10:46:03 -07:00
zfs.release.in Move zfs.release generation to configure step 2012-07-12 12:22:51 -07:00

img

OpenZFS is an advanced file system and volume manager which was originally developed for Solaris and is now maintained by the OpenZFS community. This repository contains the code for running OpenZFS on Linux and FreeBSD.

codecov coverity

Official Resources

Installation

Full documentation for installing OpenZFS on your favorite operating system can be found at the Getting Started Page.

Contribute & Develop

We have a separate document with contribution guidelines.

We have a Code of Conduct.

Release

OpenZFS is released under a CDDL license. For more details see the NOTICE, LICENSE and COPYRIGHT files; UCRL-CODE-235197

Supported Kernels

  • The META file contains the officially recognized supported Linux kernel versions.
  • Supported FreeBSD versions are any supported branches and releases starting from 13.0-RELEASE.