c/mirror_zfs
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_zfs.git synced 2025-01-27 10:24:22 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix coverity defects: CID 147474

Browse Source 
CID 147474: Logically dead code (DEADCODE)

Remove ternary operator and return `error` directly.

Currently return value is derived from a ternary operator. The
conditional is always true. The ternary operator is therefore
redundant i.e dead code.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tobin C. Harding <me@tobin.cc>
Closes #6723
This commit is contained in:
Tobin Harding 2017-10-11 10:41:47 +11:00 committed by Brian Behlendorf
parent 829e95c4dc
commit 523d5ce0f4
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
module/zfs/sa.c
View File

@ -980,7 +980,8 @@ bail:
kmem_free(sa->sa_user_table, count * sizeof (sa_attr_type_t)); kmem_free(sa->sa_user_table, count * sizeof (sa_attr_type_t));
sa->sa_user_table = NULL; sa->sa_user_table = NULL;
sa_free_attr_table(sa); sa_free_attr_table(sa);
return ((error != 0) ? error : EINVAL); ASSERT(error != 0);
return (error);
} }
int int