From 523d5ce0f48a1b7127345d830e5a34079cace322 Mon Sep 17 00:00:00 2001 From: Tobin Harding Date: Wed, 11 Oct 2017 10:41:47 +1100 Subject: [PATCH] Fix coverity defects: CID 147474 CID 147474: Logically dead code (DEADCODE) Remove ternary operator and return `error` directly. Currently return value is derived from a ternary operator. The conditional is always true. The ternary operator is therefore redundant i.e dead code. Reviewed-by: Brian Behlendorf Signed-off-by: Tobin C. Harding Closes #6723 --- module/zfs/sa.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/module/zfs/sa.c b/module/zfs/sa.c index 8046dbde2..f0a18bad8 100644 --- a/module/zfs/sa.c +++ b/module/zfs/sa.c @@ -980,7 +980,8 @@ bail: kmem_free(sa->sa_user_table, count * sizeof (sa_attr_type_t)); sa->sa_user_table = NULL; sa_free_attr_table(sa); - return ((error != 0) ? error : EINVAL); + ASSERT(error != 0); + return (error); } int