mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2024-12-25 18:59:33 +03:00
zdb: Fix handling of nul termination in symlink targets
The SA attribute containing the symlink target does not include a nul terminator, so when printing the target zdb would sometimes include garbage at the end of the string. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Signed-off-by: Mark Johnston <markj@FreeBSD.org> Closes #13482
This commit is contained in:
parent
e02d84d3a5
commit
03df6bad94
@ -3194,13 +3194,18 @@ dump_znode_symlink(sa_handle_t *hdl)
|
||||
{
|
||||
int sa_symlink_size = 0;
|
||||
char linktarget[MAXPATHLEN];
|
||||
linktarget[0] = '\0';
|
||||
int error;
|
||||
|
||||
error = sa_size(hdl, sa_attr_table[ZPL_SYMLINK], &sa_symlink_size);
|
||||
if (error || sa_symlink_size == 0) {
|
||||
return;
|
||||
}
|
||||
if (sa_symlink_size >= sizeof (linktarget)) {
|
||||
(void) printf("symlink size %d is too large\n",
|
||||
sa_symlink_size);
|
||||
return;
|
||||
}
|
||||
linktarget[sa_symlink_size] = '\0';
|
||||
if (sa_lookup(hdl, sa_attr_table[ZPL_SYMLINK],
|
||||
&linktarget, sa_symlink_size) == 0)
|
||||
(void) printf("\ttarget %s\n", linktarget);
|
||||
|
Loading…
Reference in New Issue
Block a user