5b15e2ecaf
Notable changes:
* The only big change is the switch to using a custom QIOChannel for
savevm-async, because the previously used QEMUFileOps was dropped.
Changes to the current implementation:
* Switch to vector based methods as required for an IO channel. For
short reads the passed-in IO vector is stuffed with zeroes at the
end, just to be sure.
* For reading: The documentation in include/io/channel.h states that
at least one byte should be read, so also error out when whe are
at the very end instead of returning 0.
* For reading: Fix off-by-one error when request goes beyond end.
The wrong code piece was:
if ((pos + size) > maxlen) {
size = maxlen - pos - 1;
}
Previously, the last byte would not be read. It's actually
possible to get a snapshot .raw file that has content all the way
up the final 512 byte (= BDRV_SECTOR_SIZE) boundary without any
trailing zero bytes (I wrote a script to do it).
Luckily, it didn't cause a real issue, because qemu_loadvm_state()
is not interested in the final (i.e. QEMU_VM_VMDESCRIPTION)
section. The buffer for reading it is simply freed up afterwards
and the function will assume that it read the whole section, even
if that's not the case.
* For writing: Make use of the generated blk_pwritev() wrapper
instead of manually wrapping the coroutine to simplify and save a
few lines.
* Adapt to changed interfaces for blk_{pread,pwrite}:
* a9262f551e ("block: Change blk_{pread,pwrite}() param order")
* 3b35d4542c ("block: Add a 'flags' param to blk_pread()")
* bf5b16fa40 ("block: Make blk_{pread,pwrite}() return 0 on success")
Those changes especially affected the qemu-img dd patches, because
the context also changed, but also some of our block drivers used
the functions.
* Drop qemu-common.h include: it got renamed after essentially
everything was moved to other headers. The only remaining user I
could find for things dropped from the header between 7.0 and 7.1
was qemu_get_vm_name() in the iscsi-initiatorname patch, but it
already includes the header to which the function was moved.
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
89 lines
2.4 KiB
Diff
89 lines
2.4 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
|
|
Date: Mon, 6 Apr 2020 12:16:37 +0200
|
|
Subject: [PATCH] PVE: [Up] qmp: add get_link_status
|
|
|
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|
---
|
|
net/net.c | 27 +++++++++++++++++++++++++++
|
|
qapi/net.json | 15 +++++++++++++++
|
|
qapi/pragma.json | 1 +
|
|
3 files changed, 43 insertions(+)
|
|
|
|
diff --git a/net/net.c b/net/net.c
|
|
index 2db160e063..8329347891 100644
|
|
--- a/net/net.c
|
|
+++ b/net/net.c
|
|
@@ -1343,6 +1343,33 @@ void hmp_info_network(Monitor *mon, const QDict *qdict)
|
|
}
|
|
}
|
|
|
|
+int64_t qmp_get_link_status(const char *name, Error **errp)
|
|
+{
|
|
+ NetClientState *ncs[MAX_QUEUE_NUM];
|
|
+ NetClientState *nc;
|
|
+ int queues;
|
|
+ bool ret;
|
|
+
|
|
+ queues = qemu_find_net_clients_except(name, ncs,
|
|
+ NET_CLIENT_DRIVER__MAX,
|
|
+ MAX_QUEUE_NUM);
|
|
+
|
|
+ if (queues == 0) {
|
|
+ error_set(errp, ERROR_CLASS_DEVICE_NOT_FOUND,
|
|
+ "Device '%s' not found", name);
|
|
+ return (int64_t) -1;
|
|
+ }
|
|
+
|
|
+ nc = ncs[0];
|
|
+ ret = ncs[0]->link_down;
|
|
+
|
|
+ if (nc->peer->info->type == NET_CLIENT_DRIVER_NIC) {
|
|
+ ret = ncs[0]->peer->link_down;
|
|
+ }
|
|
+
|
|
+ return (int64_t) ret ? 0 : 1;
|
|
+}
|
|
+
|
|
void colo_notify_filters_event(int event, Error **errp)
|
|
{
|
|
NetClientState *nc;
|
|
diff --git a/qapi/net.json b/qapi/net.json
|
|
index 75ba2cb989..a3c93ab88f 100644
|
|
--- a/qapi/net.json
|
|
+++ b/qapi/net.json
|
|
@@ -35,6 +35,21 @@
|
|
##
|
|
{ 'command': 'set_link', 'data': {'name': 'str', 'up': 'bool'} }
|
|
|
|
+##
|
|
+# @get_link_status:
|
|
+#
|
|
+# Get the current link state of the nics or nic.
|
|
+#
|
|
+# @name: name of the nic you get the state of
|
|
+#
|
|
+# Return: If link is up 1
|
|
+# If link is down 0
|
|
+# If an error occure an empty string.
|
|
+#
|
|
+# Notes: this is an Proxmox VE extension and not offical part of Qemu.
|
|
+##
|
|
+{ 'command': 'get_link_status', 'data': {'name': 'str'} , 'returns': 'int' }
|
|
+
|
|
##
|
|
# @netdev_add:
|
|
#
|
|
diff --git a/qapi/pragma.json b/qapi/pragma.json
|
|
index 7f810b0e97..a2358e303a 100644
|
|
--- a/qapi/pragma.json
|
|
+++ b/qapi/pragma.json
|
|
@@ -26,6 +26,7 @@
|
|
'system_wakeup' ],
|
|
# Commands allowed to return a non-dictionary
|
|
'command-returns-exceptions': [
|
|
+ 'get_link_status',
|
|
'human-monitor-command',
|
|
'qom-get',
|
|
'query-tpm-models',
|