db5d2a4b77
where there is no good reason to keep them separate. It's a pain during rebase if there are multiple patches changing the same code over and over again. This was especially bad for the backup-related patches. If the history of patches really is needed, it can be extracted via git. Additionally, compilation with partial application of patches was broken since a long time, because one of the master key changes became part of an earlier patch during a past rebase. If only the same files were changed by a subsequent patch and the changes felt to belong together (obvious for later bug fixes, but also done for features e.g. adding master key support for PBS), the patches were squashed together. The PBS namespace support patch was split into the individual parts it changes, i.e. PBS block driver, pbs-restore binary and QMP backup infrastructure, and squashed into the respective patches. No code change is intended, git diff in the submodule should not show any difference between applying all patches before this commit and applying all patches after this commit. The query-proxmox-support QMP function has been left as part of the "PVE-Backup: Proxmox backup patches for QEMU" patch, because it's currently only used there. If it ever is used elsewhere too, it can be split out from there. The recent alloc-track and BQL-related savevm-async changes have been left separate for now, because it's not 100% clear they are the best approach yet. This depends on what upstream decides about the BQL stuff and whether and what kind of issues with the changes pop up. The qemu-img dd snapshot patch has been re-ordered to after the other qemu-img dd patches. Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
30 lines
1.2 KiB
Diff
30 lines
1.2 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Fiona Ebner <f.ebner@proxmox.com>
|
|
Date: Fri, 5 May 2023 15:30:16 +0200
|
|
Subject: [PATCH] savevm-async: don't hold BQL during setup
|
|
|
|
See commit "migration: for snapshots, hold the BQL during setup
|
|
callbacks" for why. This is separate, because a version of that one
|
|
will hopefully land upstream.
|
|
|
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
|
---
|
|
migration/savevm-async.c | 2 --
|
|
1 file changed, 2 deletions(-)
|
|
|
|
diff --git a/migration/savevm-async.c b/migration/savevm-async.c
|
|
index effe6d1e0d..f006a8e4d4 100644
|
|
--- a/migration/savevm-async.c
|
|
+++ b/migration/savevm-async.c
|
|
@@ -403,10 +403,8 @@ void qmp_savevm_start(const char *statefile, Error **errp)
|
|
snap_state.state = SAVE_STATE_ACTIVE;
|
|
snap_state.finalize_bh = qemu_bh_new(process_savevm_finalize, &snap_state);
|
|
snap_state.co = qemu_coroutine_create(&process_savevm_co, NULL);
|
|
- qemu_mutex_unlock_iothread();
|
|
qemu_savevm_state_header(snap_state.file);
|
|
qemu_savevm_state_setup(snap_state.file);
|
|
- qemu_mutex_lock_iothread();
|
|
|
|
/* Async processing from here on out happens in iohandler context, so let
|
|
* the target bdrv have its home there.
|