32 lines
1.1 KiB
Diff
32 lines
1.1 KiB
Diff
From bde803ceb42d6bddc06a1881c00acdf203214772 Mon Sep 17 00:00:00 2001
|
|
From: Li Qiang <liqiang6-s@360.cn>
|
|
Date: Tue, 1 Nov 2016 05:37:57 -0700
|
|
Subject: [PATCH 10/12] virtio-gpu: fix information leak in capset get dispatch
|
|
|
|
In virgl_cmd_get_capset function, it uses g_malloc to allocate
|
|
a response struct to the guest. As the 'resp'struct hasn't been full
|
|
initialized it will lead the 'resp->padding' field to the guest.
|
|
Use g_malloc0 to avoid this.
|
|
|
|
Signed-off-by: Li Qiang <liqiang6-s@360.cn>
|
|
---
|
|
hw/display/virtio-gpu-3d.c | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
diff --git a/hw/display/virtio-gpu-3d.c b/hw/display/virtio-gpu-3d.c
|
|
index 23f39de..d98b140 100644
|
|
--- a/hw/display/virtio-gpu-3d.c
|
|
+++ b/hw/display/virtio-gpu-3d.c
|
|
@@ -371,7 +371,7 @@ static void virgl_cmd_get_capset(VirtIOGPU *g,
|
|
|
|
virgl_renderer_get_cap_set(gc.capset_id, &max_ver,
|
|
&max_size);
|
|
- resp = g_malloc(sizeof(*resp) + max_size);
|
|
+ resp = g_malloc0(sizeof(*resp) + max_size);
|
|
|
|
resp->hdr.type = VIRTIO_GPU_RESP_OK_CAPSET;
|
|
virgl_renderer_fill_caps(gc.capset_id,
|
|
--
|
|
2.1.4
|
|
|