4b7975e75d
Most notable fixes from a Proxmox VE perspective are: * "virtio-net: correctly copy vnet header when flushing TX" To prevent a stack overflow that could lead to leaking parts of the QEMU process's memory. * "hw/pflash: implement update buffer for block writes" To prevent an edge case for half-completed writes. This potentially affected EFI disks. * Fixes to i386 emulation and ARM emulation. No changes for patches were necessary (all are just automatic context changes). Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
34 lines
1.3 KiB
Diff
34 lines
1.3 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
|
|
Date: Mon, 6 Apr 2020 12:16:53 +0200
|
|
Subject: [PATCH] PVE: monitor: disable oob capability
|
|
|
|
A bisect revealed that commit 8258292e18c3
|
|
("monitor: Remove "x-oob", offer capability "oob" unconditionally")
|
|
causes unexpected hangs when restoring live snapshots from some
|
|
types of block devices (particularly RBD).
|
|
We need to figure out what's happnening there. For now, since we
|
|
had this disabled before and probably don't need it now either,
|
|
disable oob, so we can get a functioning qemu out...
|
|
|
|
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
|
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|
---
|
|
monitor/qmp.c | 3 +--
|
|
1 file changed, 1 insertion(+), 2 deletions(-)
|
|
|
|
diff --git a/monitor/qmp.c b/monitor/qmp.c
|
|
index 589c9524f8..2505dd658a 100644
|
|
--- a/monitor/qmp.c
|
|
+++ b/monitor/qmp.c
|
|
@@ -536,8 +536,7 @@ void monitor_init_qmp(Chardev *chr, bool pretty, Error **errp)
|
|
qemu_chr_fe_set_echo(&mon->common.chr, true);
|
|
|
|
/* Note: we run QMP monitor in I/O thread when @chr supports that */
|
|
- monitor_data_init(&mon->common, true, false,
|
|
- qemu_chr_has_feature(chr, QEMU_CHAR_FEATURE_GCONTEXT));
|
|
+ monitor_data_init(&mon->common, true, false, false);
|
|
|
|
mon->pretty = pretty;
|
|
|