d03e1b3ce3
User-facing breaking change:
The slirp submodule for user networking got removed. It would be
necessary to add the --enable-slirp option to the build and/or install
the appropriate library to continue building it. Since PVE is not
explicitly supporting it, it would require additionally installing the
libslirp0 package on all installations and there is *very* little
mention on the community forum when searching for "slirp" or
"netdev user", the plan is to only enable it again if there is some
real demand for it.
Notable changes:
* The big change for this release is the rework of job locking, using
a job mutex and introducing _locked() variants of job API functions
moving away from call-side AioContext locking. See (in the qemu
submodule) commit 6f592e5aca ("job.c: enable job lock/unlock and
remove Aiocontext locks") and previous commits for context.
Changes required for the backup patches:
* Use WITH_JOB_LOCK_GUARD() and call the _locked() variant of job
API functions where appropriate (many are only availalbe as
a _locked() variant).
* Remove acquiring/releasing AioContext around functions taking the
job mutex lock internally.
The patch introducing sequential transaction support for jobs needs
to temporarily unlock the job mutex to call job_start() when
starting the next job in the transaction.
* The zeroinit block driver now marks its child as primary.
The documentation in include/block/block-common.h states:
> Filter node has exactly one FILTERED|PRIMARY child, and may have
> other children which must not have these bits
Without this, an assert will trigger when copying to a zeroinit target
with qemu-img convert, because bdrv_child_cb_attach() expects any
non-PRIMARY child to be not FILTERED:
> qemu-img convert -n -p -f raw -O raw input.raw zeroinit:output.raw
> qemu-img: ../block.c:1476: bdrv_child_cb_attach: Assertion
> `!(child->role & BDRV_CHILD_FILTERED)' failed.
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
43 lines
1.6 KiB
Diff
43 lines
1.6 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Fiona Ebner <f.ebner@proxmox.com>
|
|
Date: Fri, 28 Oct 2022 10:09:46 +0200
|
|
Subject: [PATCH] init: daemonize: defuse PID file resolve error
|
|
|
|
When proxmox-file-restore invokes QEMU, the PID file is a (temporary)
|
|
file that's already unlinked, so resolving the absolute path here
|
|
failed.
|
|
|
|
It should not be a critical error when the PID file unlink handler
|
|
can't be registered, because the path can't be resolved for whatever
|
|
reason. If the file is already gone from QEMU's perspective (i.e.
|
|
errno is ENOENT), silently ignore the error. Otherwise, print a
|
|
warning.
|
|
|
|
Reported-by: Dominik Csapak <d.csapak@proxmox.com>
|
|
Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
|
---
|
|
softmmu/vl.c | 9 +++++----
|
|
1 file changed, 5 insertions(+), 4 deletions(-)
|
|
|
|
diff --git a/softmmu/vl.c b/softmmu/vl.c
|
|
index 5115221efe..5f7f6ca981 100644
|
|
--- a/softmmu/vl.c
|
|
+++ b/softmmu/vl.c
|
|
@@ -2460,10 +2460,11 @@ static void qemu_maybe_daemonize(const char *pid_file)
|
|
|
|
pid_file_realpath = g_malloc0(PATH_MAX);
|
|
if (!realpath(pid_file, pid_file_realpath)) {
|
|
- error_report("cannot resolve PID file path: %s: %s",
|
|
- pid_file, strerror(errno));
|
|
- unlink(pid_file);
|
|
- exit(1);
|
|
+ if (errno != ENOENT) {
|
|
+ warn_report("not removing PID file on exit: cannot resolve PID "
|
|
+ "file path: %s: %s", pid_file, strerror(errno));
|
|
+ }
|
|
+ return;
|
|
}
|
|
|
|
qemu_unlink_pidfile_notifier = (struct UnlinkPidfileNotifier) {
|