53b56ca781
Changes to other patches are all just metadata/context changes except
for pvebackup_co_prepare() needing to call bdrv_co_unref() rather than
bdrv_unref(), because it is a coroutine itself. This is documented in
d6ee2e324e ("block-coroutine-wrapper: Introduce no_co_wrapper"). The
change is necessary, because one of the stable fixes converts
bdrv_unref and blk_unref into no_co_wrappers (in preparation for a
second patch to fix a hang with the block resize QMP command).
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
49 lines
1.9 KiB
Diff
49 lines
1.9 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: Wang Liang <wangliangzz@inspur.com>
|
|
Date: Mon, 24 Apr 2023 18:39:02 +0800
|
|
Subject: [PATCH] block/monitor: Fix crash when executing HMP commit
|
|
|
|
hmp_commit() calls blk_is_available() from a non-coroutine context (and
|
|
in the main loop). blk_is_available() is a co_wrapper_mixed_bdrv_rdlock
|
|
function, and in the non-coroutine context it calls AIO_WAIT_WHILE(),
|
|
which crashes if the aio_context lock is not taken before.
|
|
|
|
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1615
|
|
Signed-off-by: Wang Liang <wangliangzz@inspur.com>
|
|
Message-Id: <20230424103902.45265-1-wangliangzz@126.com>
|
|
Reviewed-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
|
|
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
|
|
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
|
|
(cherry-picked from commit 8c1e8fb2e7fc2cbeb57703e143965a4cd3ad301a)
|
|
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
|
|
---
|
|
block/monitor/block-hmp-cmds.c | 10 ++++++----
|
|
1 file changed, 6 insertions(+), 4 deletions(-)
|
|
|
|
diff --git a/block/monitor/block-hmp-cmds.c b/block/monitor/block-hmp-cmds.c
|
|
index 2846083546..ca2599de44 100644
|
|
--- a/block/monitor/block-hmp-cmds.c
|
|
+++ b/block/monitor/block-hmp-cmds.c
|
|
@@ -214,15 +214,17 @@ void hmp_commit(Monitor *mon, const QDict *qdict)
|
|
error_report("Device '%s' not found", device);
|
|
return;
|
|
}
|
|
- if (!blk_is_available(blk)) {
|
|
- error_report("Device '%s' has no medium", device);
|
|
- return;
|
|
- }
|
|
|
|
bs = bdrv_skip_implicit_filters(blk_bs(blk));
|
|
aio_context = bdrv_get_aio_context(bs);
|
|
aio_context_acquire(aio_context);
|
|
|
|
+ if (!blk_is_available(blk)) {
|
|
+ error_report("Device '%s' has no medium", device);
|
|
+ aio_context_release(aio_context);
|
|
+ return;
|
|
+ }
|
|
+
|
|
ret = bdrv_commit(bs);
|
|
|
|
aio_context_release(aio_context);
|