2018-04-05 12:04:11 +03:00
|
|
|
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
|
|
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
|
2018-08-30 16:00:07 +03:00
|
|
|
Date: Fri, 31 Aug 2018 09:32:55 +0200
|
|
|
|
Subject: [PATCH] PVE: [Config] rbd: block: rbd: disable
|
|
|
|
rbd_cache_writethrough_until_flush
|
2018-04-05 12:04:11 +03:00
|
|
|
|
|
|
|
Either the cache mode asks for a cache or not. There's no
|
|
|
|
point in having a "temporary" cache mode. This option AFAIK
|
|
|
|
was introduced as a hack for ancient virtio drivers. If
|
|
|
|
anything, we should have a separate option for it. Better
|
|
|
|
yet, VMs affected by the related issue should simply
|
|
|
|
explicitly choose writethrough.
|
|
|
|
|
|
|
|
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
|
2019-06-06 13:58:15 +03:00
|
|
|
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
|
2018-04-05 12:04:11 +03:00
|
|
|
---
|
2018-08-30 16:00:07 +03:00
|
|
|
block/rbd.c | 2 ++
|
|
|
|
1 file changed, 2 insertions(+)
|
2018-04-05 12:04:11 +03:00
|
|
|
|
|
|
|
diff --git a/block/rbd.c b/block/rbd.c
|
2019-11-20 17:45:35 +03:00
|
|
|
index 59757b3120..d00c9d2d12 100644
|
2018-04-05 12:04:11 +03:00
|
|
|
--- a/block/rbd.c
|
|
|
|
+++ b/block/rbd.c
|
2019-11-20 17:45:35 +03:00
|
|
|
@@ -636,6 +636,8 @@ static int qemu_rbd_connect(rados_t *cluster, rados_ioctx_t *io_ctx,
|
2018-08-30 16:00:07 +03:00
|
|
|
rados_conf_set(*cluster, "rbd_cache", "false");
|
2018-04-05 12:04:11 +03:00
|
|
|
}
|
|
|
|
|
2018-08-30 16:00:07 +03:00
|
|
|
+ rados_conf_set(*cluster, "rbd_cache_writethrough_until_flush", "false");
|
|
|
|
+
|
|
|
|
r = rados_connect(*cluster);
|
2018-04-05 12:04:11 +03:00
|
|
|
if (r < 0) {
|
2018-08-30 16:00:07 +03:00
|
|
|
error_setg_errno(errp, -r, "error connecting");
|