mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2026-03-11 12:56:21 +03:00
88d012a1d6
A deadlock occurs when snapshot expiry tasks are cancelled while holding locks. The snapshot expiry task (snapentry_expire) spawns an umount process and waits for it to complete. Concurrently, ARC memory pressure triggers arc_prune which calls zfs_exit_fs(), attempting to cancel the expiry task while holding locks. The umount process spawned by the expiry task blocks trying to acquire locks held by arc_prune, which is blocked waiting for the expiry task to complete. This creates a circular dependency: expiry task waits for umount, umount waits for arc_prune, arc_prune waits for expiry task. Fix by adding non-blocking cancellation support to taskq_cancel_id(). The zfs_exit_fs() path calls zfsctl_snapshot_unmount_delay() to reschedule the unmount, which needs to cancel any existing expiry task. It now uses non-blocking cancellation to avoid waiting while holding locks, breaking the deadlock by returning immediately when the task is already running. The per-entry se_taskqid_lock has been removed, with all taskqid operations now protected by the global zfs_snapshot_lock held as WRITER. Additionally, an se_in_umount flag prevents recursive waits when zfsctl_destroy() is called during unmount. The taskqid is now only cleared by the caller on successful cancellation; running tasks clear their own taskqid upon completion. Reviewed-by: Alexander Motin <alexander.motin@TrueNAS.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ameer Hamza <ahamza@ixsystems.com> Closes #17941 |
||
|---|---|---|
| .. | ||
| dktp | ||
| acl_impl.h | ||
| acl.h | ||
| asm_linkage.h | ||
| backtrace.h | ||
| callb.h | ||
| cmn_err.h | ||
| condvar.h | ||
| cred.h | ||
| debug.h | ||
| dkio.h | ||
| dklabel.h | ||
| feature_tests.h | ||
| inttypes.h | ||
| isa_defs.h | ||
| kmem.h | ||
| kstat.h | ||
| list_impl.h | ||
| list.h | ||
| mhd.h | ||
| misc.h | ||
| mkdev.h | ||
| mod.h | ||
| mutex.h | ||
| policy.h | ||
| poll.h | ||
| priv.h | ||
| processor.h | ||
| procfs_list.h | ||
| random.h | ||
| rwlock.h | ||
| sid.h | ||
| simd.h | ||
| stack.h | ||
| stdtypes.h | ||
| string.h | ||
| sunddi.h | ||
| sysmacros.h | ||
| systeminfo.h | ||
| systm.h | ||
| taskq.h | ||
| thread.h | ||
| time.h | ||
| timer.h | ||
| trace.h | ||
| tsd.h | ||
| tunables.h | ||
| types32.h | ||
| types.h | ||
| uio.h | ||
| vnode.h | ||
| wmsum.h | ||
| zone.h | ||