Files
mirror_zfs/module/zfs
Matthew Ahrens 0156253d29 ztest fails assertion in zio_write_gang_member_ready()
Encrypted blocks can have up to 2 DVA's, as the third DVA is reserved
for the salt+IV.  However, dmu_write_policy() allows non-encrypted
blocks (e.g. DMU_OT_OBJSET) inside encrypted datasets to request and
allocate 3 DVA's, since they don't need a salt+IV (they are merely
authenicated).

However, if such a block becomes a gang block, the gang code incorrectly
limits the gang block header to 2 DVA's.  This leads to a "NDVAs
inversion", where a parent block (the gang block header) has less DVA's
than its children (the gang members), causing an assertion failure in
zio_write_gang_member_ready().

This commit addresses the problem by only restricting the gang block
header to 2 DVA's if the block is actually encrypted (and thus its gang
block members can have at most 2 DVA's).

Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matthew Ahrens <mahrens@delphix.com>
Closes #14250
Closes #14356
2023-01-10 08:44:55 -08:00
..
2022-07-26 10:10:37 -07:00
2021-06-09 13:05:34 -07:00
2022-12-01 12:39:43 -08:00
2020-08-20 10:30:06 -07:00
2019-07-26 10:54:14 -07:00
2021-06-09 13:05:34 -07:00
2020-11-02 11:51:12 -08:00
2022-09-26 14:55:27 -07:00
2022-09-26 14:55:27 -07:00
2020-06-18 12:21:25 -07:00
2017-10-11 16:54:48 -04:00
2022-02-16 17:58:56 -08:00
2020-11-13 13:51:51 -08:00
2021-09-14 12:10:17 -07:00
2019-06-19 09:48:12 -07:00
2020-07-29 16:35:33 -07:00
2022-02-16 17:58:56 -08:00
2020-06-18 12:21:25 -07:00
2020-06-18 12:21:25 -07:00
2021-02-20 20:16:50 -08:00
2021-06-24 13:12:36 -07:00
2022-07-26 10:10:37 -07:00
2021-06-10 10:50:16 -07:00
2022-09-21 16:12:14 -07:00
2019-10-09 10:36:03 -07:00
2021-11-02 09:50:30 -07:00
2021-11-02 09:50:30 -07:00
2020-11-13 13:51:51 -08:00
2020-06-18 12:21:25 -07:00
2019-09-02 17:56:41 -07:00
2020-10-02 17:44:10 -07:00
2020-06-18 12:20:38 -07:00
2022-12-01 12:39:43 -08:00
2021-11-02 09:50:30 -07:00
2021-01-20 21:27:30 -08:00
2022-11-01 12:49:14 -07:00
2020-06-18 12:21:25 -07:00
2020-06-18 12:21:18 -07:00