Andriy Tkachuk f8457fbdc4
Fix deadlock on dmu_tx_assign() from vdev_rebuild() ...
vdev_rebuild() is always called with spa_config_lock held in
RW_WRITER mode. However, when it tries to call dmu_tx_assign()
the latter may hang on dmu_tx_wait() waiting for available txg.
But that available txg may not happen because txg_sync takes
spa_config_lock in order to process the current txg. So we have
a deadlock case here:
- dmu_tx_assign() waits for txg holding spa_config_lock;
- txg_sync waits for spa_config_lock not progressing with txg.
Here are the stacks:
__schedule+0x24e/0x590
schedule+0x69/0x110
cv_wait_common+0xf8/0x130 [spl]
__cv_wait+0x15/0x20 [spl]
dmu_tx_wait+0x8e/0x1e0 [zfs]
dmu_tx_assign+0x49/0x80 [zfs]
vdev_rebuild_initiate+0x39/0xc0 [zfs]
vdev_rebuild+0x84/0x90 [zfs]
spa_vdev_attach+0x305/0x680 [zfs]
zfs_ioc_vdev_attach+0xc7/0xe0 [zfs]
cv_wait_common+0xf8/0x130 [spl]
__cv_wait+0x15/0x20 [spl]
spa_config_enter+0xf9/0x120 [zfs]
spa_sync+0x6d/0x5b0 [zfs]
txg_sync_thread+0x266/0x2f0 [zfs]
The solution is to pass txg returned by spa_vdev_enter(spa)
at the top of spa_vdev_attach() to vdev_rebuild() and call
dmu_tx_create_assigned(txg) which doesn't wait for txg.
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov >
Reviewed-by: Akash B <akash-b@hpe.com >
Reviewed-by: Alek Pinchuk <apinchuk@axcient.com >
Signed-off-by: Andriy Tkachuk <andriy.tkachuk@seagate.com >
Closes #18210
Closes #18258
2026-02-26 11:18:02 -08:00
2025-11-12 10:03:51 -08:00
2025-09-10 15:25:03 -07:00
2026-02-25 09:41:38 -05:00
2025-03-13 17:56:54 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:50 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2026-02-04 10:07:07 -08:00
2026-02-04 10:07:02 -08:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-11-10 13:58:39 -08:00
2025-11-10 16:16:22 -08:00
2026-02-22 11:43:51 -08:00
2025-03-13 17:56:27 -07:00
2025-08-06 10:36:56 -07:00
2025-12-15 09:49:14 -08:00
2026-02-25 09:41:38 -05:00
2025-08-21 06:05:38 -07:00
2026-02-09 10:17:56 -08:00
2025-04-29 16:27:48 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-08-06 10:36:07 -07:00
2025-05-28 10:28:51 -07:00
2025-05-13 14:26:55 -07:00
2026-02-04 10:12:32 -08:00
2025-08-21 06:05:38 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-06-10 14:52:43 -07:00
2025-03-13 17:56:27 -07:00
2025-09-12 09:53:31 -07:00
2025-03-13 17:56:27 -07:00
2025-04-29 16:27:48 -07:00
2025-03-24 09:25:01 -07:00
2025-03-13 17:56:27 -07:00
2025-12-11 18:46:08 -08:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-06-04 17:40:09 -07:00
2025-03-13 17:56:27 -07:00
2026-02-19 10:36:35 -08:00
2026-02-19 10:36:35 -08:00
2026-02-09 09:36:01 -08:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-04-18 09:22:16 -04:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-09-29 16:38:52 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:57:31 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2026-02-09 09:36:01 -08:00
2025-03-13 17:56:27 -07:00
2026-02-09 09:35:03 -08:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-05-28 10:27:46 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2026-02-09 09:36:01 -08:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-05-02 15:32:18 -07:00
2025-03-13 17:56:27 -07:00
2026-02-23 09:34:33 -08:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-09-10 15:25:03 -07:00
2025-09-10 15:25:03 -07:00
2026-02-26 11:18:02 -08:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2026-02-09 09:36:01 -08:00
2025-07-30 09:49:43 -07:00
2025-12-15 14:38:34 -08:00
2025-03-13 17:56:27 -07:00
2025-12-15 14:38:34 -08:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-04-29 16:27:48 -07:00
2025-03-13 17:56:27 -07:00
2025-11-12 10:00:24 -08:00
2025-11-12 10:03:07 -08:00
2025-03-13 17:56:27 -07:00
2025-11-12 10:04:03 -08:00
2026-01-05 14:15:22 -08:00
2025-03-13 17:56:27 -07:00
2025-12-10 09:45:39 -08:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-10-01 12:17:13 -07:00
2025-03-13 17:56:27 -07:00
2025-11-05 16:22:03 -08:00
2025-04-03 10:36:45 -07:00
2025-05-13 14:26:55 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-05-12 10:22:17 -07:00
2025-08-07 11:40:59 -07:00
2025-08-14 08:50:17 -07:00
2025-08-08 16:43:33 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-12-10 19:51:53 -05:00
2025-10-01 12:17:13 -07:00
2025-03-13 17:56:27 -07:00
2025-03-13 17:56:27 -07:00
2025-08-19 10:06:47 -07:00
2025-09-03 11:13:09 -07:00
Andriy Tkachuk
f8457fbdc4