mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2024-11-17 10:01:01 +03:00
13ec73a028
This new check in 0.9.0 appears to have some issues with various forms of "early return", like trap, exit and return. This is tripping up (at least): cmd/zed/zed.d/history_event-zfs-list-cacher.sh /etc/zfs/zfs-functions Its not obvious what its complaining about or what the remedy is, so it seems sensible to disable this check for now. See also: https://www.shellcheck.net/wiki/SC2317 https://github.com/koalaman/shellcheck/issues/2542 https://github.com/koalaman/shellcheck/issues/2613 Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Rob Norris <robn@despairlabs.com> Closes #15089
43 lines
2.1 KiB
Plaintext
43 lines
2.1 KiB
Plaintext
# Global ShellCheck exclusions:
|
|
#
|
|
# ShellCheck can't follow non-constant source. Use a directive to specify location. [SC1090]
|
|
# Not following: a was not specified as input (see shellcheck -x). [SC1091]
|
|
# Prefer putting braces around variable references even when not strictly required. [SC2250]
|
|
# Consider invoking this command separately to avoid masking its return value (or use '|| true' to ignore). [SC2312]
|
|
# Command appears to be unreachable. Check usage (or ignore if invoked indirectly). [SC2317]
|
|
# In POSIX sh, 'local' is undefined. [SC2039] # older ShellCheck versions
|
|
# In POSIX sh, 'local' is undefined. [SC3043] # newer ShellCheck versions
|
|
|
|
SHELLCHECKSCRIPTS =
|
|
|
|
JUST_SHELLCHECK_OPTS = $(addprefix shellcheck-here-,$(subst /,^,$(1)))
|
|
JUST_CHECKBASHISMS_OPTS = $(addprefix checkbashisms-here-,$(subst /,^,$(1)))
|
|
SHELLCHECK_OPTS = $(call JUST_SHELLCHECK_OPTS,$(1)) $(call JUST_CHECKBASHISMS_OPTS,$(1))
|
|
|
|
PHONY += shellcheck
|
|
|
|
_STGT = $(subst ^,/,$(subst shellcheck-here-,,$@))
|
|
shellcheck-here-%:
|
|
if HAVE_SHELLCHECK
|
|
shellcheck --format=gcc --enable=all --exclude=SC1090,SC1091,SC2039,SC2250,SC2312,SC2317,SC3043 $$([ -n "$(SHELLCHECK_SHELL)" ] && echo "--shell=$(SHELLCHECK_SHELL)") "$$([ -e "$(_STGT)" ] || echo "$(srcdir)/")$(_STGT)"
|
|
else
|
|
@echo "skipping shellcheck of" $(_STGT) "because shellcheck is not installed"
|
|
endif
|
|
|
|
shellcheck: $(SHELLCHECKSCRIPTS) $(call JUST_SHELLCHECK_OPTS,$(SHELLCHECKSCRIPTS))
|
|
|
|
|
|
PHONY += checkbashisms
|
|
|
|
# command -v *is* specified by POSIX and every shell in existence supports it
|
|
_BTGT = $(subst ^,/,$(subst checkbashisms-here-,,$@))
|
|
checkbashisms-here-%:
|
|
if HAVE_CHECKBASHISMS
|
|
! { [ -n "$(SHELLCHECK_SHELL)" ] && echo '#!/bin/$(SHELLCHECK_SHELL)'; cat "$$([ -e "$(_BTGT)" ] || echo "$(srcdir)/")$(_BTGT)"; } | \
|
|
checkbashisms -npx 2>&1 | grep -vFe "'command' with option other than -p" -e 'command -v' -e 'any possible bashisms' $(CHECKBASHISMS_IGNORE) >&2
|
|
else
|
|
@echo "skipping checkbashisms of" $(_BTGT) "because checkbashisms is not installed"
|
|
endif
|
|
|
|
checkbashisms: $(SHELLCHECKSCRIPTS) $(call JUST_CHECKBASHISMS_OPTS,$(SHELLCHECKSCRIPTS))
|