mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2024-11-17 18:11:00 +03:00
f0ce0436aa
The size argument of snprintf(3) in glibc and snprintf() in Linux
kernel includes trailing \0, as snprintf(3) man page explains it as
"write at most size bytes (including the trailing null byte ('\0'))",
i.e. snprintf() can just take buffer size.
e.g. For snprintf() in module/zfs/zfs_ctldir.c, a buffer size is
MAXPATHLEN, and a caller is passing MAXPATHLEN to snprintf(), so size
should just be `path_len` to do what the caller is trying to do.
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Richard Laager <rlaager@wiktel.com>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@gmail.com>
Closes #8692
125 lines
3.1 KiB
C
125 lines
3.1 KiB
C
/*
|
|
* Copyright (C) 2007-2010 Lawrence Livermore National Security, LLC.
|
|
* Copyright (C) 2007 The Regents of the University of California.
|
|
* Produced at Lawrence Livermore National Laboratory (cf, DISCLAIMER).
|
|
* Written by Brian Behlendorf <behlendorf1@llnl.gov>.
|
|
* UCRL-CODE-235197
|
|
*
|
|
* This file is part of the SPL, Solaris Porting Layer.
|
|
* For details, see <http://zfsonlinux.org/>.
|
|
*
|
|
* The SPL is free software; you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public License as published by the
|
|
* Free Software Foundation; either version 2 of the License, or (at your
|
|
* option) any later version.
|
|
*
|
|
* The SPL is distributed in the hope that it will be useful, but WITHOUT
|
|
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
|
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
|
|
* for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with the SPL. If not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
* Solaris Porting Layer (SPL) Error Implementation.
|
|
*/
|
|
|
|
#include <sys/sysmacros.h>
|
|
#include <sys/cmn_err.h>
|
|
|
|
/*
|
|
* It is often useful to actually have the panic crash the node so you
|
|
* can then get notified of the event, get the crashdump for later
|
|
* analysis and other such goodies.
|
|
* But we would still default to the current default of not to do that.
|
|
*/
|
|
/* BEGIN CSTYLED */
|
|
unsigned int spl_panic_halt;
|
|
module_param(spl_panic_halt, uint, 0644);
|
|
MODULE_PARM_DESC(spl_panic_halt, "Cause kernel panic on assertion failures");
|
|
/* END CSTYLED */
|
|
|
|
void
|
|
spl_dumpstack(void)
|
|
{
|
|
printk("Showing stack for process %d\n", current->pid);
|
|
dump_stack();
|
|
}
|
|
EXPORT_SYMBOL(spl_dumpstack);
|
|
|
|
int
|
|
spl_panic(const char *file, const char *func, int line, const char *fmt, ...)
|
|
{
|
|
const char *newfile;
|
|
char msg[MAXMSGLEN];
|
|
va_list ap;
|
|
|
|
newfile = strrchr(file, '/');
|
|
if (newfile != NULL)
|
|
newfile = newfile + 1;
|
|
else
|
|
newfile = file;
|
|
|
|
va_start(ap, fmt);
|
|
(void) vsnprintf(msg, sizeof (msg), fmt, ap);
|
|
va_end(ap);
|
|
|
|
printk(KERN_EMERG "%s", msg);
|
|
printk(KERN_EMERG "PANIC at %s:%d:%s()\n", newfile, line, func);
|
|
if (spl_panic_halt)
|
|
panic("%s", msg);
|
|
|
|
spl_dumpstack();
|
|
|
|
/* Halt the thread to facilitate further debugging */
|
|
set_current_state(TASK_UNINTERRUPTIBLE);
|
|
while (1)
|
|
schedule();
|
|
|
|
/* Unreachable */
|
|
return (1);
|
|
}
|
|
EXPORT_SYMBOL(spl_panic);
|
|
|
|
void
|
|
vcmn_err(int ce, const char *fmt, va_list ap)
|
|
{
|
|
char msg[MAXMSGLEN];
|
|
|
|
vsnprintf(msg, MAXMSGLEN, fmt, ap);
|
|
|
|
switch (ce) {
|
|
case CE_IGNORE:
|
|
break;
|
|
case CE_CONT:
|
|
printk("%s", msg);
|
|
break;
|
|
case CE_NOTE:
|
|
printk(KERN_NOTICE "NOTICE: %s\n", msg);
|
|
break;
|
|
case CE_WARN:
|
|
printk(KERN_WARNING "WARNING: %s\n", msg);
|
|
break;
|
|
case CE_PANIC:
|
|
printk(KERN_EMERG "PANIC: %s\n", msg);
|
|
spl_dumpstack();
|
|
|
|
/* Halt the thread to facilitate further debugging */
|
|
set_current_state(TASK_UNINTERRUPTIBLE);
|
|
while (1)
|
|
schedule();
|
|
}
|
|
} /* vcmn_err() */
|
|
EXPORT_SYMBOL(vcmn_err);
|
|
|
|
void
|
|
cmn_err(int ce, const char *fmt, ...)
|
|
{
|
|
va_list ap;
|
|
|
|
va_start(ap, fmt);
|
|
vcmn_err(ce, fmt, ap);
|
|
va_end(ap);
|
|
} /* cmn_err() */
|
|
EXPORT_SYMBOL(cmn_err);
|