mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2024-11-18 10:21:01 +03:00
55d7afa4ad
Both Clang's Static Analyzer and Synopsys' Coverity would ignore assertions. Following Clang's advice, we annotate our assertions: https://clang-analyzer.llvm.org/annotations.html#custom_assertions This makes both Clang's Static Analyzer and Coverity properly identify assertions. This change reduced Clang's reported defects from 246 to 180. It also reduced the false positives reported by Coverityi by 10, while enabling Coverity to find 9 more defects that previously were false negatives. A couple examples of this would be CID-1524417 and CID-1524423. After submitting a build to coverity with the modified assertions, CID-1524417 disappeared while the report for CID-1524423 no longer claimed that the assertion tripped. Coincidentally, it turns out that it is possible to more accurately annotate our headers than the Coverity modelling file permits in the case of format strings. Since we can do that and this patch annotates headers whenever `__coverity_panic__()` would have been used in the model file, we drop all models that use `__coverity_panic__()` from the model file. Upon seeing the success in eliminating false positives involving assertions, it occurred to me that we could also modify our headers to eliminate coverity's false positives involving byte swaps. We now have coverity specific byteswap macros, that do nothing, to disable Coverity's false positives when we do byte swaps. This allowed us to also drop the byteswap definitions from the model file. Lastly, a model file update has been done beyond the mentioned deletions: * The definitions of `umem_alloc_aligned()`, `umem_alloc()` andi `umem_zalloc()` were originally implemented in a way that was intended to inform coverity that when KM_SLEEP has been passed these functions, they do not return NULL. A small error in how this was done was found, so we correct it. * Definitions for umem_cache_alloc() and umem_cache_free() have been added. In practice, no false positives were avoided by making these changes, but in the interest of correctness from future coverity builds, we make them anyway. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Closes #13902
176 lines
4.0 KiB
C
176 lines
4.0 KiB
C
/*
|
|
* CDDL HEADER START
|
|
*
|
|
* The contents of this file are subject to the terms of the
|
|
* Common Development and Distribution License, Version 1.0 only
|
|
* (the "License"). You may not use this file except in compliance
|
|
* with the License.
|
|
*
|
|
* You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
|
|
* or https://opensource.org/licenses/CDDL-1.0.
|
|
* See the License for the specific language governing permissions
|
|
* and limitations under the License.
|
|
*
|
|
* When distributing Covered Code, include this CDDL HEADER in each
|
|
* file and include the License file at usr/src/OPENSOLARIS.LICENSE.
|
|
* If applicable, add the following below this CDDL HEADER, with the
|
|
* fields enclosed by brackets "[]" replaced with your own identifying
|
|
* information: Portions Copyright [yyyy] [name of copyright owner]
|
|
*
|
|
* CDDL HEADER END
|
|
*/
|
|
/*
|
|
* Copyright 2005 Sun Microsystems, Inc. All rights reserved.
|
|
* Use is subject to license terms.
|
|
*/
|
|
|
|
#ifndef _LIBUUTIL_IMPL_H
|
|
#define _LIBUUTIL_IMPL_H
|
|
|
|
|
|
|
|
#include <libuutil.h>
|
|
#include <pthread.h>
|
|
|
|
#include <sys/avl_impl.h>
|
|
#include <sys/byteorder.h>
|
|
|
|
#ifdef __cplusplus
|
|
extern "C" {
|
|
#endif
|
|
|
|
void uu_set_error(uint_t);
|
|
|
|
|
|
__attribute__((format(printf, 1, 2), __noreturn__))
|
|
void uu_panic(const char *format, ...);
|
|
|
|
|
|
/*
|
|
* For debugging purposes, libuutil keeps around linked lists of all uu_lists
|
|
* and uu_avls, along with pointers to their parents. These can cause false
|
|
* negatives when looking for memory leaks, so we encode the pointers by
|
|
* storing them with swapped endianness; this is not perfect, but it's about
|
|
* the best we can do without wasting a lot of space.
|
|
*/
|
|
#ifdef _LP64
|
|
#define UU_PTR_ENCODE(ptr) BSWAP_64((uintptr_t)(void *)(ptr))
|
|
#else
|
|
#define UU_PTR_ENCODE(ptr) BSWAP_32((uintptr_t)(void *)(ptr))
|
|
#endif
|
|
|
|
#define UU_PTR_DECODE(ptr) ((void *)UU_PTR_ENCODE(ptr))
|
|
|
|
/*
|
|
* uu_list structures
|
|
*/
|
|
typedef struct uu_list_node_impl {
|
|
struct uu_list_node_impl *uln_next;
|
|
struct uu_list_node_impl *uln_prev;
|
|
} uu_list_node_impl_t;
|
|
|
|
struct uu_list_walk {
|
|
uu_list_walk_t *ulw_next;
|
|
uu_list_walk_t *ulw_prev;
|
|
|
|
uu_list_t *ulw_list;
|
|
int8_t ulw_dir;
|
|
uint8_t ulw_robust;
|
|
uu_list_node_impl_t *ulw_next_result;
|
|
};
|
|
|
|
struct uu_list {
|
|
uintptr_t ul_next_enc;
|
|
uintptr_t ul_prev_enc;
|
|
|
|
uu_list_pool_t *ul_pool;
|
|
uintptr_t ul_parent_enc; /* encoded parent pointer */
|
|
size_t ul_offset;
|
|
size_t ul_numnodes;
|
|
uint8_t ul_debug;
|
|
uint8_t ul_sorted;
|
|
uint8_t ul_index; /* mark for uu_list_index_ts */
|
|
|
|
uu_list_node_impl_t ul_null_node;
|
|
uu_list_walk_t ul_null_walk; /* for robust walkers */
|
|
};
|
|
|
|
#define UU_LIST_PTR(ptr) ((uu_list_t *)UU_PTR_DECODE(ptr))
|
|
|
|
#define UU_LIST_POOL_MAXNAME 64
|
|
|
|
struct uu_list_pool {
|
|
uu_list_pool_t *ulp_next;
|
|
uu_list_pool_t *ulp_prev;
|
|
|
|
char ulp_name[UU_LIST_POOL_MAXNAME];
|
|
size_t ulp_nodeoffset;
|
|
size_t ulp_objsize;
|
|
uu_compare_fn_t *ulp_cmp;
|
|
uint8_t ulp_debug;
|
|
uint8_t ulp_last_index;
|
|
pthread_mutex_t ulp_lock; /* protects null_list */
|
|
uu_list_t ulp_null_list;
|
|
};
|
|
|
|
/*
|
|
* uu_avl structures
|
|
*/
|
|
typedef struct avl_node uu_avl_node_impl_t;
|
|
|
|
struct uu_avl_walk {
|
|
uu_avl_walk_t *uaw_next;
|
|
uu_avl_walk_t *uaw_prev;
|
|
|
|
uu_avl_t *uaw_avl;
|
|
void *uaw_next_result;
|
|
int8_t uaw_dir;
|
|
uint8_t uaw_robust;
|
|
};
|
|
|
|
struct uu_avl {
|
|
uintptr_t ua_next_enc;
|
|
uintptr_t ua_prev_enc;
|
|
|
|
uu_avl_pool_t *ua_pool;
|
|
uintptr_t ua_parent_enc;
|
|
uint8_t ua_debug;
|
|
uint8_t ua_index; /* mark for uu_avl_index_ts */
|
|
|
|
struct avl_tree ua_tree;
|
|
uu_avl_walk_t ua_null_walk;
|
|
};
|
|
|
|
#define UU_AVL_PTR(x) ((uu_avl_t *)UU_PTR_DECODE(x))
|
|
|
|
#define UU_AVL_POOL_MAXNAME 64
|
|
|
|
struct uu_avl_pool {
|
|
uu_avl_pool_t *uap_next;
|
|
uu_avl_pool_t *uap_prev;
|
|
|
|
char uap_name[UU_AVL_POOL_MAXNAME];
|
|
size_t uap_nodeoffset;
|
|
size_t uap_objsize;
|
|
uu_compare_fn_t *uap_cmp;
|
|
uint8_t uap_debug;
|
|
uint8_t uap_last_index;
|
|
pthread_mutex_t uap_lock; /* protects null_avl */
|
|
uu_avl_t uap_null_avl;
|
|
};
|
|
|
|
/*
|
|
* atfork() handlers
|
|
*/
|
|
void uu_avl_lockup(void);
|
|
void uu_avl_release(void);
|
|
|
|
void uu_list_lockup(void);
|
|
void uu_list_release(void);
|
|
|
|
#ifdef __cplusplus
|
|
}
|
|
#endif
|
|
|
|
#endif /* _LIBUUTIL_IMPL_H */
|