mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2024-11-17 18:11:00 +03:00
5a84c60fb9
1. With various (debug and/or tracing?) kernel options enabled it's possible for 'struct inode' and 'struct super_block' to exceed the default frame size, leaving errors like this in config.log: build/conftest.c:116:1: error: the frame size of 1048 bytes is larger than 1024 bytes [-Werror=frame-larger-than=] Fix this by removing the frame size warning for config checks 2. Without the correct headers included, it's possible for declarations to be missed, leaving errors like this in the config.log: build/conftest.c:131:14: error: ‘struct nameidata’ declared inside parameter list [-Werror] Fix this by adding appropriate headers. Note: Both these issues can result in silent config failures because the compile failure is taken to mean "this option is not supported by this kernel" rather than "there's something wrong with the config test". This can lead to something merely annoying (compile failures) to something potentially serious (miscompiled or misused kernel primitives or functions). E.g. the fixes included here resulted in these additional defines in zfs_config.h with linux v4.14.19: Also, drive-by whitespace fixes in config/* files which don't mention "GNU" (those ones look to be imported from elsewhere so leave them alone). Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Chris Dunlop <chris@onthe.net.au> Closes #7169
101 lines
2.6 KiB
Plaintext
101 lines
2.6 KiB
Plaintext
dnl #
|
|
dnl # Supported get_link() interfaces checked newest to oldest.
|
|
dnl #
|
|
AC_DEFUN([ZFS_AC_KERNEL_FOLLOW_LINK], [
|
|
dnl #
|
|
dnl # 4.2 API change
|
|
dnl # - This kernel retired the nameidata structure.
|
|
dnl #
|
|
AC_MSG_CHECKING([whether iops->follow_link() passes cookie])
|
|
ZFS_LINUX_TRY_COMPILE([
|
|
#include <linux/fs.h>
|
|
const char *follow_link(struct dentry *de,
|
|
void **cookie) { return "symlink"; }
|
|
static struct inode_operations
|
|
iops __attribute__ ((unused)) = {
|
|
.follow_link = follow_link,
|
|
};
|
|
],[
|
|
],[
|
|
AC_MSG_RESULT(yes)
|
|
AC_DEFINE(HAVE_FOLLOW_LINK_COOKIE, 1,
|
|
[iops->follow_link() cookie])
|
|
],[
|
|
dnl #
|
|
dnl # 2.6.32 API
|
|
dnl #
|
|
AC_MSG_RESULT(no)
|
|
AC_MSG_CHECKING(
|
|
[whether iops->follow_link() passes nameidata])
|
|
ZFS_LINUX_TRY_COMPILE([
|
|
#include <linux/fs.h>
|
|
void *follow_link(struct dentry *de, struct
|
|
nameidata *nd) { return (void *)NULL; }
|
|
static struct inode_operations
|
|
iops __attribute__ ((unused)) = {
|
|
.follow_link = follow_link,
|
|
};
|
|
],[
|
|
],[
|
|
AC_MSG_RESULT(yes)
|
|
AC_DEFINE(HAVE_FOLLOW_LINK_NAMEIDATA, 1,
|
|
[iops->follow_link() nameidata])
|
|
],[
|
|
AC_MSG_ERROR(no; please file a bug report)
|
|
])
|
|
])
|
|
])
|
|
|
|
AC_DEFUN([ZFS_AC_KERNEL_GET_LINK], [
|
|
dnl #
|
|
dnl # 4.5 API change
|
|
dnl # The get_link interface has added a delayed done call and
|
|
dnl # used it to retire the put_link() interface.
|
|
dnl #
|
|
AC_MSG_CHECKING([whether iops->get_link() passes delayed])
|
|
ZFS_LINUX_TRY_COMPILE([
|
|
#include <linux/fs.h>
|
|
const char *get_link(struct dentry *de, struct inode *ip,
|
|
struct delayed_call *done) { return "symlink"; }
|
|
static struct inode_operations
|
|
iops __attribute__ ((unused)) = {
|
|
.get_link = get_link,
|
|
};
|
|
],[
|
|
],[
|
|
AC_MSG_RESULT(yes)
|
|
AC_DEFINE(HAVE_GET_LINK_DELAYED, 1,
|
|
[iops->get_link() delayed])
|
|
],[
|
|
dnl #
|
|
dnl # 4.5 API change
|
|
dnl # The follow_link() interface has been replaced by
|
|
dnl # get_link() which behaves the same as before except:
|
|
dnl # - An inode is passed as a separate argument
|
|
dnl # - When called in RCU mode a NULL dentry is passed.
|
|
dnl #
|
|
AC_MSG_RESULT(no)
|
|
AC_MSG_CHECKING([whether iops->get_link() passes cookie])
|
|
ZFS_LINUX_TRY_COMPILE([
|
|
#include <linux/fs.h>
|
|
const char *get_link(struct dentry *de, struct
|
|
inode *ip, void **cookie) { return "symlink"; }
|
|
static struct inode_operations
|
|
iops __attribute__ ((unused)) = {
|
|
.get_link = get_link,
|
|
};
|
|
],[
|
|
],[
|
|
AC_MSG_RESULT(yes)
|
|
AC_DEFINE(HAVE_GET_LINK_COOKIE, 1,
|
|
[iops->get_link() cookie])
|
|
],[
|
|
dnl #
|
|
dnl # Check for the follow_link APIs.
|
|
dnl #
|
|
AC_MSG_RESULT(no)
|
|
ZFS_AC_KERNEL_FOLLOW_LINK
|
|
])
|
|
])
|
|
])
|