Rob Norris ea076d6921 vdev_raidz_asize_to_psize: return psize, not asize ... Since 246e588, gang blocks written to raidz vdevs will write past the end of their allocation, corrupting themselves, other data, or both. The reason is simple - when allocating the gang children, we call vdev_psize_to_asize() to find out how much data we should load into the allocation we just did. vdev_raidz_asize_to_psize() had a bug; it computed the psize, but returned the original asize. The raidz layer dutifully writes that much out, into space beyond the end of the allocation. If there's existing data there, it gets overwritten, causing checksum errors when that data is read. Even there's not data there (unlikely, given that gang blocks are in play at all), that area is not considered allocated, so can be allocated and overwritten later. The fix is simple: return the psize we just computed. Sponsored-by: Klara, Inc. Sponsored-by: Wasabi Technology, Inc. Reviewed-by: Alexander Motin <mav@FreeBSD.org> Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Allan Jude <allan@klarasystems.com> Signed-off-by: Rob Norris <rob.norris@klarasystems.com> Closes #17488		2025-06-26 10:19:59 -04:00
..
abd.c	Export correct symbols for Lustre Direct I/O	2025-04-24 13:55:21 -04:00
aggsum.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
arc.c	tunables: ensure tunable and variable have same define gate	2025-05-28 16:50:22 -07:00
blake3_zfs.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
blkptr.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
bplist.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
bpobj.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
bptree.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
bqueue.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
brt.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
btree.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
dataset_kstats.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
dbuf_stats.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
dbuf.c	Improve block cloning transactions accounting	2025-06-11 11:59:16 -07:00
ddt_log.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
ddt_stats.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
ddt_zap.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
ddt.c	Improve allocation fallback handling	2025-05-31 19:12:16 -04:00
dmu_diff.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
dmu_direct.c	Wire O_DIRECT also to Uncached I/O (#17218)	2025-05-13 14:26:55 -07:00
dmu_object.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
dmu_objset.c	dsl_dataset: rename dmu_objset_clone* to dsl_dataset_clone*	2025-06-10 14:52:43 -07:00
dmu_recv.c	Wire O_DIRECT also to Uncached I/O (#17218)	2025-05-13 14:26:55 -07:00
dmu_redact.c	dmu_tx_assign: make all VERIFY0 calls use DMU_TX_SUSPEND	2025-05-28 10:28:59 -07:00
dmu_send.c	Fix 2 bugs in non-raw send with encryption	2025-05-19 09:55:00 -07:00
dmu_traverse.c	dmu_traverse: remove 'ignore_hole_birth' tunable alias	2025-05-27 15:05:09 -07:00
dmu_tx.c	Clarify and restrict dmu_tx_assign() errors	2025-06-23 15:48:30 -04:00
dmu_zfetch.c	Wire O_DIRECT also to Uncached I/O (#17218)	2025-05-13 14:26:55 -07:00
dmu.c	Ensure that gang_copies is always at least as large as copies	2025-06-25 12:05:36 -04:00
dnode_sync.c	Wire O_DIRECT also to Uncached I/O (#17218)	2025-05-13 14:26:55 -07:00
dnode.c	Polish db_rwlock scope	2025-06-11 11:13:48 -07:00
dsl_bookmark.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
dsl_crypt.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
dsl_dataset.c	dsl_dataset: rename dmu_objset_clone* to dsl_dataset_clone*	2025-06-10 14:52:43 -07:00
dsl_deadlist.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
dsl_deleg.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
dsl_destroy.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
dsl_dir.c	Clarify and restrict dmu_tx_assign() errors	2025-06-23 15:48:30 -04:00
dsl_pool.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
dsl_prop.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
dsl_scan.c	scrub: generate scrub_finish event	2025-06-06 22:43:10 -04:00
dsl_synctask.c	dmu_tx_assign: make all VERIFY0 calls use DMU_TX_SUSPEND	2025-05-28 10:28:59 -07:00
dsl_userhold.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
edonr_zfs.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
fm.c	tunables: ensure tunable and variable have same define gate	2025-05-28 16:50:22 -07:00
gzip.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
hkdf.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
lz4_zfs.c	SPDX: license tags: BSD-2-Clause	2025-03-13 17:56:46 -07:00
lz4.c	SPDX: license tags: BSD-2-Clause	2025-03-13 17:56:46 -07:00
lzjb.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
metaslab.c	Include class name into struct metaslab_class	2025-06-03 11:12:59 -04:00
mmp.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
multilist.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
objlist.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
pathname.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
range_tree.c	Fix off-by-one bug in range tree code	2025-05-23 10:33:33 -04:00
refcount.c	Implement allocation size ranges and use for gang leaves (#17111)	2025-05-02 15:32:18 -07:00
rrwlock.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
sa.c	Wire O_DIRECT also to Uncached I/O (#17218)	2025-05-13 14:26:55 -07:00
sha2_zfs.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
skein_zfs.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
spa_checkpoint.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
spa_config.c	tunables: ensure tunable and variable have same define gate	2025-05-28 16:50:22 -07:00
spa_errlog.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
spa_history.c	dmu_tx: rename dmu_tx_assign() flags from TXG_* to DMU_TX_* (#17143)	2025-03-18 16:04:22 -07:00
spa_log_spacemap.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
spa_misc.c	Improve allocation fallback handling	2025-05-31 19:12:16 -04:00
spa_stats.c	Wire O_DIRECT also to Uncached I/O (#17218)	2025-05-13 14:26:55 -07:00
spa.c	Include class name into struct metaslab_class	2025-06-03 11:12:59 -04:00
space_map.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
space_reftree.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
THIRDPARTYLICENSE.cityhash	OpenZFS 8484 - Implement aggregate sum and use for arc counters	2018-06-06 09:35:59 -07:00
THIRDPARTYLICENSE.cityhash.descrip	OpenZFS 8484 - Implement aggregate sum and use for arc counters	2018-06-06 09:35:59 -07:00
txg.c	txg_wait_synced_flags: add TXG_WAIT_SUSPEND flag to not wait if pool suspended	2025-05-28 10:27:46 -07:00
uberblock.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
unique.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
vdev_draid_rand.c	SPDX: license tags: LicenseRef-OpenZFS-ThirdParty-PublicDomain	2025-03-13 17:57:31 -07:00
vdev_draid.c	Fix other nonrot bugs	2025-06-19 09:25:58 -04:00
vdev_file.c	Implement allocation size ranges and use for gang leaves (#17111)	2025-05-02 15:32:18 -07:00
vdev_indirect_births.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
vdev_indirect_mapping.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
vdev_indirect.c	dmu_tx_assign: make all VERIFY0 calls use DMU_TX_SUSPEND	2025-05-28 10:28:59 -07:00
vdev_initialize.c	dmu_tx_assign: make all VERIFY0 calls use DMU_TX_SUSPEND	2025-05-28 10:28:59 -07:00
vdev_label.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
vdev_mirror.c	Implement allocation size ranges and use for gang leaves (#17111)	2025-05-02 15:32:18 -07:00
vdev_missing.c	Implement allocation size ranges and use for gang leaves (#17111)	2025-05-02 15:32:18 -07:00
vdev_queue.c	Unified allocation throttling (#17020)	2025-03-24 09:25:01 -07:00
vdev_raidz_math_aarch64_neon_common.h	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
vdev_raidz_math_aarch64_neon.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
vdev_raidz_math_aarch64_neonx2.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
vdev_raidz_math_avx2.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
vdev_raidz_math_avx512bw.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
vdev_raidz_math_avx512f.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
vdev_raidz_math_impl.h	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
vdev_raidz_math_powerpc_altivec_common.h	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
vdev_raidz_math_powerpc_altivec.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
vdev_raidz_math_scalar.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
vdev_raidz_math_sse2.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
vdev_raidz_math_ssse3.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
vdev_raidz_math.c	tunables: don't assert initialisation in impl getters	2025-05-28 16:50:22 -07:00
vdev_raidz.c	vdev_raidz_asize_to_psize: return psize, not asize	2025-06-26 10:19:59 -04:00
vdev_rebuild.c	dmu_tx_assign: make all VERIFY0 calls use DMU_TX_SUSPEND	2025-05-28 10:28:59 -07:00
vdev_removal.c	dmu_tx_assign: make all VERIFY0 calls use DMU_TX_SUSPEND	2025-05-28 10:28:59 -07:00
vdev_root.c	Implement allocation size ranges and use for gang leaves (#17111)	2025-05-02 15:32:18 -07:00
vdev_trim.c	dmu_tx_assign: make all VERIFY0 calls use DMU_TX_SUSPEND	2025-05-28 10:28:59 -07:00
vdev.c	Fix other nonrot bugs	2025-06-19 09:25:58 -04:00
zap_leaf.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
zap_micro.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
zap.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
zcp_get.c	zcp: get_prop: fix encryptionroot and encryption	2025-05-27 20:04:37 -04:00
zcp_global.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
zcp_iter.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
zcp_set.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
zcp_synctask.c	zcp_synctask: add zfs.sync.clone()	2025-06-10 14:53:10 -07:00
zcp.c	txg: generalise txg_wait_synced_sig() to txg_wait_synced_flags() (#17284)	2025-05-02 15:29:50 -07:00
zfeature.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
zfs_byteswap.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
zfs_chksum.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
zfs_debug_common.c	nvlist: Add nvlist_snprintf() and zfs_dbgmsg_nvlist()	2025-04-18 09:22:16 -04:00
zfs_fm.c	events: include zio type in IO error reports	2025-05-30 10:29:29 -04:00
zfs_fuid.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
zfs_impl.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
zfs_ioctl.c	dsl_dataset: rename dmu_objset_clone* to dsl_dataset_clone*	2025-06-10 14:52:43 -07:00
zfs_log.c	zfs_log_write: only put the callback on the last itx	2025-06-12 14:44:33 -07:00
zfs_onexit.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
zfs_quota.c	Show default quotas in zfs userspace tools	2025-04-03 10:36:45 -07:00
zfs_ratelimit.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
zfs_replay.c	dmu_tx: rename dmu_tx_assign() flags from TXG_* to DMU_TX_* (#17143)	2025-03-18 16:04:22 -07:00
zfs_rlock.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
zfs_sa.c	dmu_tx: rename dmu_tx_assign() flags from TXG_* to DMU_TX_* (#17143)	2025-03-18 16:04:22 -07:00
zfs_vnops.c	Improve block cloning transactions accounting	2025-06-11 11:59:16 -07:00
zfs_znode.c	Add default user/group/project quota properties	2025-04-03 10:35:22 -07:00
zil.c	ZIL: Relax parallel write ZIOs processing	2025-06-14 09:37:18 -04:00
zio_checksum.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
zio_compress.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
zio_inject.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
zio.c	Include class name into struct metaslab_class	2025-06-03 11:12:59 -04:00
zle.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
zrlock.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
zthr.c	SPDX: license tags: CDDL-1.0	2025-03-13 17:56:27 -07:00
zvol.c	Improve block cloning transactions accounting	2025-06-11 11:59:16 -07:00