Files
mirror_zfs/include/sys
Tom Caputi 47ab01a18f Always wait for txg sync when umounting dataset
Currently, when unmounting a filesystem, ZFS will only wait for
a txg sync if the dataset is dirty and not readonly. However, this
can be problematic in cases where a dataset is remounted readonly
immediately before being unmounted, which often happens when the
system is being shut down. Since encrypted datasets require that
all I/O is completed before the dataset is disowned, this issue
causes problems when write I/Os leak into the txgs after the
dataset is disowned, which can happen when sync=disabled.

While looking into fixes for this issue, it was discovered that
dsl_dataset_is_dirty() does not return B_TRUE when the dataset has
been removed from the txg dirty datasets list, but has not actually
been processed yet. Furthermore, the implementation is comletely
different from dmu_objset_is_dirty(), adding to the confusion.
Rather than relying on this function, this patch forces the umount
code path (and the remount readonly code path) to always perform a
txg sync on read-write datasets and removes the function altogether.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tom Caputi <tcaputi@datto.com>
Closes #7753
Closes #7795
2018-08-27 10:16:28 -07:00
..
2018-05-29 16:00:33 -07:00
2018-05-29 16:00:33 -07:00
2017-10-05 19:28:00 -07:00
2016-01-08 15:08:19 -08:00
2018-08-02 10:21:48 -07:00
2018-08-02 10:21:48 -07:00
2014-07-29 10:55:29 -07:00
2013-11-04 11:17:48 -08:00
2017-01-03 11:31:18 -06:00
2017-12-07 10:28:50 -08:00
2017-10-11 16:54:48 -04:00
2018-05-29 16:00:33 -07:00
2016-04-21 09:49:25 -07:00
2016-06-07 09:16:52 -07:00
2016-06-24 13:13:21 -07:00
2018-02-13 14:54:54 -08:00
2015-01-06 16:53:24 -08:00
2018-08-27 10:16:01 -07:00
2017-07-13 13:54:00 -04:00
2011-02-10 09:21:43 -08:00
2013-11-04 10:55:25 -08:00
2018-02-08 15:28:18 -08:00
2018-02-08 15:28:18 -08:00
2018-06-15 15:10:42 -07:00
2018-02-13 14:54:54 -08:00
2017-03-10 09:51:33 -08:00
2018-04-30 10:19:48 -07:00
2018-05-29 16:00:33 -07:00
2017-03-10 09:51:33 -08:00
2018-05-29 16:00:33 -07:00
2018-02-13 14:54:54 -08:00
2017-03-10 09:51:33 -08:00
2018-02-13 14:54:54 -08:00
2017-03-29 12:24:51 -07:00
2017-08-14 10:36:48 -07:00
2017-07-12 13:05:37 -07:00