mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2024-11-17 10:01:01 +03:00
db7f1a91de
A function that returns with no value is a different thing from a
function that doesn't return at all. Those are two orthogonal
concepts, commonly confused.
pthread_create(3) expects a pointer to a start routine that has a
very precise prototype:
void *(*start_routine)(void *);
However, other thread functions, such as kernel ones, expect:
void (*start_routine)(void *);
Providing a different one is incorrect, and has only been working
because the ABIs happen to produce a compatible function.
We should use '_Noreturn void', since it's the natural type, and
then provide a '_Noreturn void *' wrapper for pthread functions.
For consistency, replace most cases of __NORETURN or
__attribute__((noreturn)) by _Noreturn. _Noreturn is understood
by -std=gnu89, so it should be safe to use everywhere.
Ref: https://github.com/openzfs/zfs/pull/13110#discussion_r808450136
Ref: https://software.codidact.com/posts/285972
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Co-authored-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
Closes #13120
248 lines
6.4 KiB
Plaintext
248 lines
6.4 KiB
Plaintext
dnl #
|
|
dnl # Enabled -fsanitize=address if supported by $CC.
|
|
dnl #
|
|
dnl # LDFLAGS needs -fsanitize=address at all times so libraries compiled with
|
|
dnl # it will be linked successfully. CFLAGS will vary by binary being built.
|
|
dnl #
|
|
dnl # The ASAN_OPTIONS environment variable can be used to further control
|
|
dnl # the behavior of binaries and libraries build with -fsanitize=address.
|
|
dnl #
|
|
AC_DEFUN([ZFS_AC_CONFIG_ALWAYS_CC_ASAN], [
|
|
AC_MSG_CHECKING([whether to build with -fsanitize=address support])
|
|
AC_ARG_ENABLE([asan],
|
|
[AS_HELP_STRING([--enable-asan],
|
|
[Enable -fsanitize=address support @<:@default=no@:>@])],
|
|
[],
|
|
[enable_asan=no])
|
|
|
|
AM_CONDITIONAL([ASAN_ENABLED], [test x$enable_asan = xyes])
|
|
AC_SUBST([ASAN_ENABLED], [$enable_asan])
|
|
AC_MSG_RESULT($enable_asan)
|
|
|
|
AS_IF([ test "$enable_asan" = "yes" ], [
|
|
AC_MSG_CHECKING([whether $CC supports -fsanitize=address])
|
|
saved_cflags="$CFLAGS"
|
|
CFLAGS="$CFLAGS -Werror -fsanitize=address"
|
|
AC_LINK_IFELSE([
|
|
AC_LANG_SOURCE([[ int main() { return 0; } ]])
|
|
], [
|
|
ASAN_CFLAGS="-fsanitize=address"
|
|
ASAN_LDFLAGS="-fsanitize=address"
|
|
ASAN_ZFS="_with_asan"
|
|
AC_MSG_RESULT([yes])
|
|
], [
|
|
AC_MSG_ERROR([$CC does not support -fsanitize=address])
|
|
])
|
|
CFLAGS="$saved_cflags"
|
|
], [
|
|
ASAN_CFLAGS=""
|
|
ASAN_LDFLAGS=""
|
|
ASAN_ZFS="_without_asan"
|
|
])
|
|
|
|
AC_SUBST([ASAN_CFLAGS])
|
|
AC_SUBST([ASAN_LDFLAGS])
|
|
AC_SUBST([ASAN_ZFS])
|
|
])
|
|
|
|
dnl #
|
|
dnl # Enabled -fsanitize=undefined if supported by cc.
|
|
dnl #
|
|
dnl # LDFLAGS needs -fsanitize=undefined at all times so libraries compiled with
|
|
dnl # it will be linked successfully. CFLAGS will vary by binary being built.
|
|
dnl #
|
|
dnl # The UBSAN_OPTIONS environment variable can be used to further control
|
|
dnl # the behavior of binaries and libraries build with -fsanitize=undefined.
|
|
dnl #
|
|
AC_DEFUN([ZFS_AC_CONFIG_ALWAYS_CC_UBSAN], [
|
|
AC_MSG_CHECKING([whether to build with -fsanitize=undefined support])
|
|
AC_ARG_ENABLE([ubsan],
|
|
[AS_HELP_STRING([--enable-ubsan],
|
|
[Enable -fsanitize=undefined support @<:@default=no@:>@])],
|
|
[],
|
|
[enable_ubsan=no])
|
|
|
|
AM_CONDITIONAL([UBSAN_ENABLED], [test x$enable_ubsan = xyes])
|
|
AC_SUBST([UBSAN_ENABLED], [$enable_ubsan])
|
|
AC_MSG_RESULT($enable_ubsan)
|
|
|
|
AS_IF([ test "$enable_ubsan" = "yes" ], [
|
|
AC_MSG_CHECKING([whether $CC supports -fsanitize=undefined])
|
|
saved_cflags="$CFLAGS"
|
|
CFLAGS="$CFLAGS -Werror -fsanitize=undefined"
|
|
AC_LINK_IFELSE([
|
|
AC_LANG_SOURCE([[ int main() { return 0; } ]])
|
|
], [
|
|
UBSAN_CFLAGS="-fsanitize=undefined"
|
|
UBSAN_LDFLAGS="-fsanitize=undefined"
|
|
UBSAN_ZFS="_with_ubsan"
|
|
AC_MSG_RESULT([yes])
|
|
], [
|
|
AC_MSG_ERROR([$CC does not support -fsanitize=undefined])
|
|
])
|
|
CFLAGS="$saved_cflags"
|
|
], [
|
|
UBSAN_CFLAGS=""
|
|
UBSAN_LDFLAGS=""
|
|
UBSAN_ZFS="_without_ubsan"
|
|
])
|
|
|
|
AC_SUBST([UBSAN_CFLAGS])
|
|
AC_SUBST([UBSAN_LDFLAGS])
|
|
AC_SUBST([UBSAN_ZFS])
|
|
])
|
|
|
|
dnl #
|
|
dnl # Check if cc supports -Wframe-larger-than=<size> option.
|
|
dnl #
|
|
AC_DEFUN([ZFS_AC_CONFIG_ALWAYS_CC_FRAME_LARGER_THAN], [
|
|
AC_MSG_CHECKING([whether $CC supports -Wframe-larger-than=<size>])
|
|
|
|
saved_flags="$CFLAGS"
|
|
CFLAGS="$CFLAGS -Werror -Wframe-larger-than=4096"
|
|
|
|
AC_COMPILE_IFELSE([AC_LANG_PROGRAM([], [])], [
|
|
FRAME_LARGER_THAN="-Wframe-larger-than=4096"
|
|
AC_MSG_RESULT([yes])
|
|
], [
|
|
FRAME_LARGER_THAN=""
|
|
AC_MSG_RESULT([no])
|
|
])
|
|
|
|
CFLAGS="$saved_flags"
|
|
AC_SUBST([FRAME_LARGER_THAN])
|
|
])
|
|
|
|
dnl #
|
|
dnl # Check if cc supports -Wno-format-truncation option.
|
|
dnl #
|
|
AC_DEFUN([ZFS_AC_CONFIG_ALWAYS_CC_NO_FORMAT_TRUNCATION], [
|
|
AC_MSG_CHECKING([whether $CC supports -Wno-format-truncation])
|
|
|
|
saved_flags="$CFLAGS"
|
|
CFLAGS="$CFLAGS -Werror -Wno-format-truncation"
|
|
|
|
AC_COMPILE_IFELSE([AC_LANG_PROGRAM([], [])], [
|
|
NO_FORMAT_TRUNCATION=-Wno-format-truncation
|
|
AC_MSG_RESULT([yes])
|
|
], [
|
|
NO_FORMAT_TRUNCATION=
|
|
AC_MSG_RESULT([no])
|
|
])
|
|
|
|
CFLAGS="$saved_flags"
|
|
AC_SUBST([NO_FORMAT_TRUNCATION])
|
|
])
|
|
|
|
dnl #
|
|
dnl # Check if cc supports -Wno-format-zero-length option.
|
|
dnl #
|
|
AC_DEFUN([ZFS_AC_CONFIG_ALWAYS_CC_NO_FORMAT_ZERO_LENGTH], [
|
|
AC_MSG_CHECKING([whether $CC supports -Wno-format-zero-length])
|
|
|
|
saved_flags="$CFLAGS"
|
|
CFLAGS="$CFLAGS -Werror -Wno-format-zero-length"
|
|
|
|
AC_COMPILE_IFELSE([AC_LANG_PROGRAM([], [])], [
|
|
NO_FORMAT_ZERO_LENGTH=-Wno-format-zero-length
|
|
AC_MSG_RESULT([yes])
|
|
], [
|
|
NO_FORMAT_ZERO_LENGTH=
|
|
AC_MSG_RESULT([no])
|
|
])
|
|
|
|
CFLAGS="$saved_flags"
|
|
AC_SUBST([NO_FORMAT_ZERO_LENGTH])
|
|
])
|
|
|
|
dnl #
|
|
dnl # Check if cc supports -Wno-clobbered option.
|
|
dnl #
|
|
dnl # We actually invoke it with the -Wclobbered option
|
|
dnl # and infer the 'no-' version does or doesn't exist based upon
|
|
dnl # the results. This is required because when checking any of
|
|
dnl # no- prefixed options gcc always returns success.
|
|
dnl #
|
|
AC_DEFUN([ZFS_AC_CONFIG_ALWAYS_CC_NO_CLOBBERED], [
|
|
AC_MSG_CHECKING([whether $CC supports -Wno-clobbered])
|
|
|
|
saved_flags="$CFLAGS"
|
|
CFLAGS="$CFLAGS -Werror -Wclobbered"
|
|
|
|
AC_COMPILE_IFELSE([AC_LANG_PROGRAM([], [])], [
|
|
NO_CLOBBERED=-Wno-clobbered
|
|
AC_MSG_RESULT([yes])
|
|
], [
|
|
NO_CLOBBERED=
|
|
AC_MSG_RESULT([no])
|
|
])
|
|
|
|
CFLAGS="$saved_flags"
|
|
AC_SUBST([NO_CLOBBERED])
|
|
])
|
|
|
|
dnl #
|
|
dnl # Check if cc supports -Wimplicit-fallthrough option.
|
|
dnl #
|
|
AC_DEFUN([ZFS_AC_CONFIG_ALWAYS_CC_IMPLICIT_FALLTHROUGH], [
|
|
AC_MSG_CHECKING([whether $CC supports -Wimplicit-fallthrough])
|
|
|
|
saved_flags="$CFLAGS"
|
|
CFLAGS="$CFLAGS -Werror -Wimplicit-fallthrough"
|
|
|
|
AC_COMPILE_IFELSE([AC_LANG_PROGRAM([], [])], [
|
|
IMPLICIT_FALLTHROUGH=-Wimplicit-fallthrough
|
|
AC_DEFINE([HAVE_IMPLICIT_FALLTHROUGH], 1,
|
|
[Define if compiler supports -Wimplicit-fallthrough])
|
|
AC_MSG_RESULT([yes])
|
|
], [
|
|
IMPLICIT_FALLTHROUGH=
|
|
AC_MSG_RESULT([no])
|
|
])
|
|
|
|
CFLAGS="$saved_flags"
|
|
AC_SUBST([IMPLICIT_FALLTHROUGH])
|
|
])
|
|
|
|
dnl #
|
|
dnl # Check if cc supports -fno-omit-frame-pointer option.
|
|
dnl #
|
|
AC_DEFUN([ZFS_AC_CONFIG_ALWAYS_CC_NO_OMIT_FRAME_POINTER], [
|
|
AC_MSG_CHECKING([whether $CC supports -fno-omit-frame-pointer])
|
|
|
|
saved_flags="$CFLAGS"
|
|
CFLAGS="$CFLAGS -Werror -fno-omit-frame-pointer"
|
|
|
|
AC_COMPILE_IFELSE([AC_LANG_PROGRAM([], [])], [
|
|
NO_OMIT_FRAME_POINTER=-fno-omit-frame-pointer
|
|
AC_MSG_RESULT([yes])
|
|
], [
|
|
NO_OMIT_FRAME_POINTER=
|
|
AC_MSG_RESULT([no])
|
|
])
|
|
|
|
CFLAGS="$saved_flags"
|
|
AC_SUBST([NO_OMIT_FRAME_POINTER])
|
|
])
|
|
|
|
dnl #
|
|
dnl # Check if cc supports -fno-ipa-sra option.
|
|
dnl #
|
|
AC_DEFUN([ZFS_AC_CONFIG_ALWAYS_CC_NO_IPA_SRA], [
|
|
AC_MSG_CHECKING([whether $CC supports -fno-ipa-sra])
|
|
|
|
saved_flags="$CFLAGS"
|
|
CFLAGS="$CFLAGS -Werror -fno-ipa-sra"
|
|
|
|
AC_COMPILE_IFELSE([AC_LANG_PROGRAM([], [])], [
|
|
NO_IPA_SRA=-fno-ipa-sra
|
|
AC_MSG_RESULT([yes])
|
|
], [
|
|
NO_IPA_SRA=
|
|
AC_MSG_RESULT([no])
|
|
])
|
|
|
|
CFLAGS="$saved_flags"
|
|
AC_SUBST([NO_IPA_SRA])
|
|
])
|