Richard Yao e6328fda2e Cleanup: !A || A && B is equivalent to !A || B ... In zfs_zaccess_dataset_check(), we have the following subexpression: (!IS_DEVVP(ZTOV(zp)) || (IS_DEVVP(ZTOV(zp)) && (v4_mode & WRITE_MASK_ATTRS))) When !IS_DEVVP(ZTOV(zp)) is false, IS_DEVVP(ZTOV(zp)) is true under the law of the excluded middle since we are not doing pseudoboolean alegbra. Therefore doing: (IS_DEVVP(ZTOV(zp)) && (v4_mode & WRITE_MASK_ATTRS)) Is unnecessary and we can just do: (v4_mode & WRITE_MASK_ATTRS) The Linux 5.16.14 kernel's coccicheck caught this. The semantic patch that caught it was: ./scripts/coccinelle/misc/excluded_middle.cocci Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Closes #14372		2023-01-12 16:00:15 -08:00
..
avl	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
icp	Cleanup: Remove unnecessary explicit casts of pointers from allocators	2023-01-12 15:59:12 -08:00
lua	Cleanup: Replace oldstyle struct hack with C99 flexible array members	2023-01-12 16:00:03 -08:00
nvpair	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
os	Cleanup: !A || A && B is equivalent to !A || B	2023-01-12 16:00:15 -08:00
unicode	Illumos #15286: do_composition() needs sign awareness	2023-01-05 11:16:21 -08:00
zcommon	Micro-optimize fletcher4 calculations	2022-12-05 11:00:34 -08:00
zfs	Cleanup: Replace oldstyle struct hack with C99 flexible array members	2023-01-12 16:00:03 -08:00
zstd	Cleanup: Remove unnecessary explicit casts of pointers from allocators	2023-01-12 15:59:12 -08:00
.gitignore	FreeBSD: Ignore symlink to i386 includes	2022-08-02 16:34:23 -07:00
Kbuild.in	Fix Clang 15 compilation errors	2022-11-30 13:46:26 -08:00
Makefile.bsd	Cleanup dead spa_boot code	2022-09-13 16:40:10 -07:00
Makefile.in	autoconf: use include directives instead of recursing down lib	2022-05-10 10:18:11 -07:00