mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2024-11-19 10:51:00 +03:00
63652e1546
`configure` now accepts `--enable-asan` and `--enable-ubsan` switches which results in passing `-fsanitize=address` and `-fsanitize=undefined`, respectively, to the compiler. Those flags are enabled in GitHub workflows for ZTS and zloop. Errors reported by both instrumentations are corrected, except for: - Memory leak reporting is (temporarily) suppressed. The cost of fixing them is relatively high compared to the gains. - Checksum computing functions in `module/zcommon/zfs_fletcher*` have UBSan errors suppressed. It is completely impractical to enforce 64-byte payload alignment there due to performance impact. - There's no ASan heap poisoning in `module/zstd/lib/zstd.c`. A custom memory allocator is used there rendering that measure unfeasible. - Memory leaks detection has to be suppressed for `cmd/zvol_id`. `zvol_id` is run by udev with the help of `ptrace(2)`. Tracing is incompatible with memory leaks detection. Reviewed-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: szubersk <szuberskidamian@gmail.com> Closes #12928
130 lines
3.1 KiB
C
130 lines
3.1 KiB
C
/*
|
|
* CDDL HEADER START
|
|
*
|
|
* The contents of this file are subject to the terms of the
|
|
* Common Development and Distribution License (the "License").
|
|
* You may not use this file except in compliance with the License.
|
|
*
|
|
* You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
|
|
* or http://www.opensolaris.org/os/licensing.
|
|
* See the License for the specific language governing permissions
|
|
* and limitations under the License.
|
|
*
|
|
* When distributing Covered Code, include this CDDL HEADER in each
|
|
* file and include the License file at usr/src/OPENSOLARIS.LICENSE.
|
|
* If applicable, add the following below this CDDL HEADER, with the
|
|
* fields enclosed by brackets "[]" replaced with your own identifying
|
|
* information: Portions Copyright [yyyy] [name of copyright owner]
|
|
*
|
|
* CDDL HEADER END
|
|
*/
|
|
/*
|
|
* Copyright (c) 2011, Fajar A. Nugraha. All rights reserved.
|
|
* Use is subject to license terms.
|
|
*/
|
|
|
|
#include <ctype.h>
|
|
#include <string.h>
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <fcntl.h>
|
|
#include <unistd.h>
|
|
#include <linux/ioctl.h>
|
|
#include <sys/stat.h>
|
|
#include <sys/ioctl.h>
|
|
#include <sys/zfs_znode.h>
|
|
#include <sys/fs/zfs.h>
|
|
|
|
#if defined(ZFS_ASAN_ENABLED)
|
|
/*
|
|
* zvol_id is invoked by udev with the help of ptrace()
|
|
* making sanitized binary with leak detection croak
|
|
* because of tracing mechanisms collision
|
|
*/
|
|
extern const char *__asan_default_options(void);
|
|
|
|
const char *__asan_default_options(void) {
|
|
return ("abort_on_error=true:halt_on_error=true:"
|
|
"allocator_may_return_null=true:disable_coredump=false:"
|
|
"detect_stack_use_after_return=true:detect_leaks=false");
|
|
}
|
|
#endif
|
|
|
|
static int
|
|
ioctl_get_msg(char *var, int fd)
|
|
{
|
|
int ret;
|
|
char msg[ZFS_MAX_DATASET_NAME_LEN];
|
|
|
|
ret = ioctl(fd, BLKZNAME, msg);
|
|
if (ret < 0) {
|
|
return (ret);
|
|
}
|
|
|
|
snprintf(var, ZFS_MAX_DATASET_NAME_LEN, "%s", msg);
|
|
return (ret);
|
|
}
|
|
|
|
int
|
|
main(int argc, char **argv)
|
|
{
|
|
int fd = -1, ret = 0, status = EXIT_FAILURE;
|
|
char zvol_name[ZFS_MAX_DATASET_NAME_LEN];
|
|
char *zvol_name_part = NULL;
|
|
char *dev_name;
|
|
struct stat64 statbuf;
|
|
int dev_minor, dev_part;
|
|
int i;
|
|
|
|
if (argc < 2) {
|
|
fprintf(stderr, "Usage: %s /dev/zvol_device_node\n", argv[0]);
|
|
goto fail;
|
|
}
|
|
|
|
dev_name = argv[1];
|
|
ret = stat64(dev_name, &statbuf);
|
|
if (ret != 0) {
|
|
fprintf(stderr, "Unable to access device file: %s\n", dev_name);
|
|
goto fail;
|
|
}
|
|
|
|
dev_minor = minor(statbuf.st_rdev);
|
|
dev_part = dev_minor % ZVOL_MINORS;
|
|
|
|
fd = open(dev_name, O_RDONLY);
|
|
if (fd < 0) {
|
|
fprintf(stderr, "Unable to open device file: %s\n", dev_name);
|
|
goto fail;
|
|
}
|
|
|
|
ret = ioctl_get_msg(zvol_name, fd);
|
|
if (ret < 0) {
|
|
fprintf(stderr, "ioctl_get_msg failed: %s\n", strerror(errno));
|
|
goto fail;
|
|
}
|
|
if (dev_part > 0)
|
|
ret = asprintf(&zvol_name_part, "%s-part%d", zvol_name,
|
|
dev_part);
|
|
else
|
|
ret = asprintf(&zvol_name_part, "%s", zvol_name);
|
|
|
|
if (ret == -1 || zvol_name_part == NULL)
|
|
goto fail;
|
|
|
|
for (i = 0; i < strlen(zvol_name_part); i++) {
|
|
if (isblank(zvol_name_part[i]))
|
|
zvol_name_part[i] = '+';
|
|
}
|
|
|
|
printf("%s\n", zvol_name_part);
|
|
status = EXIT_SUCCESS;
|
|
|
|
fail:
|
|
if (zvol_name_part)
|
|
free(zvol_name_part);
|
|
if (fd >= 0)
|
|
close(fd);
|
|
|
|
return (status);
|
|
}
|