mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2025-01-27 18:34:22 +03:00
e2dcc6e2b8
This patch is designed to resolve a deadlock which can occur with __vmalloc() based slabs. The issue is that the Linux kernel does not honor the flags passed to __vmalloc(). This makes it unsafe to use in a writeback context. Unfortunately, this is a use case ZFS depends on for correct operation. Fixing this issue in the upstream kernel was pursued and patches are available which resolve the issue. https://bugs.gentoo.org/show_bug.cgi?id=416685 However, these changes were rejected because upstream felt that using __vmalloc() in the context of writeback should never be done. Their solution was for us to rewrite parts of ZFS to accomidate the Linux VM. While that is probably the right long term solution, and it is something we want to pursue, it is not a trivial task and will likely destabilize the existing code. This work has been planned for the 0.7.0 release but in the meanwhile we want to improve the SPL slab implementation to accomidate this expected ZFS usage. This is accomplished by performing the __vmalloc() asynchronously in the context of a work queue. This doesn't prevent the posibility of the worker thread from deadlocking. However, the caller can now safely block on a wait queue for the slab allocation to complete. Normally this will occur in a reasonable amount of time and the caller will be woken up when the new slab is available,. The objects will then get cached in the per-cpu magazines and everything will proceed as usual. However, if the __vmalloc() deadlocks for the reasons described above, or is just very slow, then the callers on the wait queues will timeout out. When this rare situation occurs they will attempt to kmalloc() a single minimally sized object using the GFP_NOIO flags. This allocation will not deadlock because kmalloc() will honor the passed flags and the caller will be able to make forward progress. As long as forward progress can be maintained then even if the worker thread is deadlocked the critical thread will make progress. This will eventually allow the deadlocked worker thread to complete and normal operation will resume. These emergency allocations will likely be slow since they require contiguous pages. However, their use should be rare so the impact is expected to be minimal. If that turns out not to be the case in practice further optimizations are possible. One additional concern is if these emergency objects are long lived. Right now they are simply tracked on a list which must be walked when an object is freed. Is they accumulate on a system and the list grows freeing objects will become more expensive. This could be handled relatively easily by using a hash instead of a list, but that optimization (if needed) is left for a follow up patch. Additionally, these emeregency objects could be repacked in to existing slabs as objects are freed if the kmem_cache_set_move() functionality was implemented. See issue https://github.com/zfsonlinux/spl/issues/26 for full details. This work would also help reduce ZFS's memory fragmentation problems. The /proc/spl/kmem/slab file has had two new columns added at the end. The 'emerg' column reports the current number of these emergency objects in use for the cache, and the following 'max' column shows the historical worst case. These value should give us a good idea of how often these objects are needed. Based on these values under real use cases we can tune the default behavior. Lastly, as a side benefit using a single work queue for the slab allocations should reduce cpu contention on the global virtual address space lock. This should manifest itself as reduced cpu usage for the system. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> |
||
|---|---|---|
| .. | ||
| fm | ||
| fs | ||
| sysevent | ||
| acl_impl.h | ||
| acl.h | ||
| atomic.h | ||
| attr.h | ||
| bitmap.h | ||
| bootconf.h | ||
| bootprops.h | ||
| buf.h | ||
| byteorder.h | ||
| callb.h | ||
| cmn_err.h | ||
| compress.h | ||
| condvar.h | ||
| conf.h | ||
| console.h | ||
| cpupart.h | ||
| cpuvar.h | ||
| crc32.h | ||
| cred.h | ||
| ctype.h | ||
| ddi.h | ||
| debug.h | ||
| dirent.h | ||
| disp.h | ||
| dkio.h | ||
| dklabel.h | ||
| dnlc.h | ||
| dumphdr.h | ||
| efi_partition.h | ||
| errno.h | ||
| extdirent.h | ||
| fcntl.h | ||
| file.h | ||
| idmap.h | ||
| int_limits.h | ||
| int_types.h | ||
| inttypes.h | ||
| isa_defs.h | ||
| kidmap.h | ||
| kmem.h | ||
| kobj.h | ||
| kstat.h | ||
| list.h | ||
| mkdev.h | ||
| mntent.h | ||
| modctl.h | ||
| mode.h | ||
| mount.h | ||
| mutex.h | ||
| note.h | ||
| open.h | ||
| param.h | ||
| pathname.h | ||
| policy.h | ||
| pool.h | ||
| priv_impl.h | ||
| proc.h | ||
| processor.h | ||
| pset.h | ||
| random.h | ||
| refstr.h | ||
| resource.h | ||
| rwlock.h | ||
| sdt.h | ||
| sid.h | ||
| signal.h | ||
| stat.h | ||
| stropts.h | ||
| sunddi.h | ||
| sunldi.h | ||
| sysdc.h | ||
| sysevent.h | ||
| sysmacros.h | ||
| systeminfo.h | ||
| systm.h | ||
| t_lock.h | ||
| taskq.h | ||
| thread.h | ||
| time.h | ||
| timer.h | ||
| tsd.h | ||
| types32.h | ||
| types.h | ||
| u8_textprep.h | ||
| uio.h | ||
| unistd.h | ||
| utsname.h | ||
| va_list.h | ||
| varargs.h | ||
| vfs_opreg.h | ||
| vfs.h | ||
| vmsystm.h | ||
| vnode.h | ||
| zmod.h | ||
| zone.h | ||