mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2024-11-18 18:31:00 +03:00
e59a377a8f
The filesystem_limit and snapshot_limit properties limit the number of filesystems or snapshots that can be created below this dataset. According to the manpage, "The limit is not enforced if the user is allowed to change the limit." Two types of users are allowed to change the limit: 1. Those that have been delegated the `filesystem_limit` or `snapshot_limit` permission, e.g. with `zfs allow USER filesystem_limit DATASET`. This works properly. 2. A user with elevated system privileges (e.g. root). This does not work - the root user will incorrectly get an error when trying to create a snapshot/filesystem, if it exceeds the `_limit` property. The problem is that `priv_policy_ns()` does not work if the `cred_t` is not that of the current process. This happens when `dsl_enforce_ds_ss_limits()` is called in syncing context (as part of a sync task's check func) to determine the permissions of the corresponding user process. This commit fixes the issue by passing the `task_struct` (typedef'ed as a `proc_t`) to syncing context, and then using `has_capability()` to determine if that process is privileged. Note that we still need to pass the `cred_t` to syncing context so that we can check if the user was delegated this permission with `zfs allow`. This problem only impacts Linux. Wrappers are added to FreeBSD but it continues to use `priv_check_cred()`, which works on arbitrary `cred_t`. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Ryan Moeller <ryan@ixsystems.com> Signed-off-by: Matthew Ahrens <mahrens@delphix.com> Closes #8226 Closes #10545
79 lines
3.5 KiB
C
79 lines
3.5 KiB
C
/*
|
|
* Copyright (c) 2007 Pawel Jakub Dawidek <pjd@FreeBSD.org>
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE AUTHORS AND CONTRIBUTORS ``AS IS'' AND
|
|
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHORS OR CONTRIBUTORS BE LIABLE
|
|
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
|
|
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
|
|
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
|
|
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
|
|
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
|
|
* SUCH DAMAGE.
|
|
*
|
|
* $ $FreeBSD$
|
|
*/
|
|
|
|
#ifndef _OPENSOLARIS_SYS_POLICY_H_
|
|
#define _OPENSOLARIS_SYS_POLICY_H_
|
|
|
|
#include <sys/param.h>
|
|
#include <sys/xvattr.h>
|
|
#include <sys/vnode.h>
|
|
struct mount;
|
|
struct vattr;
|
|
|
|
int secpolicy_nfs(cred_t *cr);
|
|
int secpolicy_zfs(cred_t *crd);
|
|
int secpolicy_zfs_proc(cred_t *cr, proc_t *proc);
|
|
int secpolicy_sys_config(cred_t *cr, int checkonly);
|
|
int secpolicy_zinject(cred_t *cr);
|
|
int secpolicy_fs_unmount(cred_t *cr, struct mount *vfsp);
|
|
int secpolicy_basic_link(vnode_t *vp, cred_t *cr);
|
|
int secpolicy_vnode_owner(vnode_t *vp, cred_t *cr, uid_t owner);
|
|
int secpolicy_vnode_chown(vnode_t *vp, cred_t *cr, uid_t owner);
|
|
int secpolicy_vnode_stky_modify(cred_t *cr);
|
|
int secpolicy_vnode_remove(vnode_t *vp, cred_t *cr);
|
|
int secpolicy_vnode_access(cred_t *cr, vnode_t *vp, uid_t owner,
|
|
accmode_t accmode);
|
|
int secpolicy_vnode_access2(cred_t *cr, vnode_t *vp, uid_t owner,
|
|
accmode_t curmode, accmode_t wantmode);
|
|
int secpolicy_vnode_any_access(cred_t *cr, vnode_t *vp, uid_t owner);
|
|
int secpolicy_vnode_setdac(vnode_t *vp, cred_t *cr, uid_t owner);
|
|
int secpolicy_vnode_setattr(cred_t *cr, vnode_t *vp, struct vattr *vap,
|
|
const struct vattr *ovap, int flags,
|
|
int unlocked_access(void *, int, cred_t *), void *node);
|
|
int secpolicy_vnode_create_gid(cred_t *cr);
|
|
int secpolicy_vnode_setids_setgids(vnode_t *vp, cred_t *cr, gid_t gid);
|
|
int secpolicy_vnode_setid_retain(vnode_t *vp, cred_t *cr,
|
|
boolean_t issuidroot);
|
|
void secpolicy_setid_clear(struct vattr *vap, vnode_t *vp, cred_t *cr);
|
|
int secpolicy_setid_setsticky_clear(vnode_t *vp, struct vattr *vap,
|
|
const struct vattr *ovap, cred_t *cr);
|
|
int secpolicy_fs_owner(struct mount *vfsp, cred_t *cr);
|
|
int secpolicy_fs_mount(cred_t *cr, vnode_t *mvp, struct mount *vfsp);
|
|
void secpolicy_fs_mount_clearopts(cred_t *cr, struct mount *vfsp);
|
|
int secpolicy_xvattr(vnode_t *vp, xvattr_t *xvap, uid_t owner, cred_t *cr,
|
|
vtype_t vtype);
|
|
int secpolicy_smb(cred_t *cr);
|
|
|
|
|
|
#if __FreeBSD_version >= 1300005
|
|
#define spl_priv_check_cred(a, b) priv_check_cred((a), (b))
|
|
#else
|
|
#define spl_priv_check_cred(a, b) priv_check_cred((a), (b), 0)
|
|
#endif
|
|
#endif /* _OPENSOLARIS_SYS_POLICY_H_ */
|