Alejandro Colomar db7f1a91de Use _Noreturn (C11; GNU89) properly ... A function that returns with no value is a different thing from a function that doesn't return at all. Those are two orthogonal concepts, commonly confused. pthread_create(3) expects a pointer to a start routine that has a very precise prototype: void *(*start_routine)(void *); However, other thread functions, such as kernel ones, expect: void (*start_routine)(void *); Providing a different one is incorrect, and has only been working because the ABIs happen to produce a compatible function. We should use '_Noreturn void', since it's the natural type, and then provide a '_Noreturn void *' wrapper for pthread functions. For consistency, replace most cases of __NORETURN or __attribute__((noreturn)) by _Noreturn. _Noreturn is understood by -std=gnu89, so it should be safe to use everywhere. Ref: https://github.com/openzfs/zfs/pull/13110#discussion_r808450136 Ref: https://software.codidact.com/posts/285972 Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Co-authored-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz> Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com> Closes #13120		2022-03-04 16:25:22 -08:00
..
rpc	module/*.ko: prune .data, global .rodata	2022-01-14 15:37:55 -08:00
sys	Use _Noreturn (C11; GNU89) properly	2022-03-04 16:25:22 -08:00
Makefile.am	OpenZFS restructuring - move platform specific headers	2019-09-05 09:34:54 -07:00