mirror of
				https://git.proxmox.com/git/mirror_zfs.git
				synced 2025-10-26 18:05:04 +03:00 
			
		
		
		
	 546f38433a
			
		
	
	
		546f38433a
		
	
	
	
	
		
			
			When debugging with tracepoints, we see string pointers:
zfs  3017 [006]  8878.728915: zfs:zfs_set__error: ffffffffa0eec3fc:3013:ffffffffa0ebcd60(): error 0x2
        ffffffffa0e1ca43 spa_open_common (/lib/modules/3.12.21-gentoo-r1/extra/zfs/zfs.ko)
        ffffffffa0e1cbe3 spa_open (/lib/modules/3.12.21-gentoo-r1/extra/zfs/zfs.ko)
        ffffffffa0e6f6ef zfs_ioc_stable (/lib/modules/3.12.21-gentoo-r1/extra/zfs/zfs.ko)
        ffffffffa0e6f2a9 zfsdev_ioctl (/lib/modules/3.12.21-gentoo-r1/extra/zfs/zfs.ko)
        ffffffff811909dd do_vfs_ioctl ([kernel.kallsyms])
        ffffffff81190c41 sys_ioctl ([kernel.kallsyms])
        ffffffff8156e2e9 system_call_fastpath ([kernel.kallsyms])
            7ff7d8be69c7 __GI___ioctl (/lib64/libc-2.19.so)
            7ff7d90cac53 lzc_ioctl.constprop.3 (/lib64/libzfs_core.so.1.0.0)
        636f695f637a6c00 [unknown] ([unknown])
Printing the actual strings is more convenient:
zfs  3461 [001] 10599.847692: zfs:zfs_set__error: spa.c:3013:spa_open_common(): error 0x2
        ffffffffa116ba43 spa_open_common (/lib/modules/3.12.21-gentoo-r1/extra/zfs/zfs.ko)
        ffffffffa116bbe3 spa_open (/lib/modules/3.12.21-gentoo-r1/extra/zfs/zfs.ko)
        ffffffffa11be8df zfs_ioc_stable (/lib/modules/3.12.21-gentoo-r1/extra/zfs/zfs.ko)
        ffffffffa11be499 zfsdev_ioctl (/lib/modules/3.12.21-gentoo-r1/extra/zfs/zfs.ko)
        ffffffff811909dd do_vfs_ioctl ([kernel.kallsyms])
        ffffffff81190c41 sys_ioctl ([kernel.kallsyms])
        ffffffff8156e2e9 system_call_fastpath ([kernel.kallsyms])
            7f11b843c9c7 __GI___ioctl (/lib64/libc-2.19.so)
            7f11b8920c53 lzc_ioctl.constprop.3 (/lib64/libzfs_core.so.1.0.0)
        636f695f637a6c00 [unknown] ([unknown])
A few other tracepoints have strings as well, so switch to printing
the actual string values at the same time.
Signed-off-by: Richard Yao <ryao@gentoo.org>
Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov>
Closes #4212
		
	
			
		
			
				
	
	
		
			88 lines
		
	
	
		
			2.4 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			88 lines
		
	
	
		
			2.4 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| /*
 | |
|  * CDDL HEADER START
 | |
|  *
 | |
|  * The contents of this file are subject to the terms of the
 | |
|  * Common Development and Distribution License (the "License").
 | |
|  * You may not use this file except in compliance with the License.
 | |
|  *
 | |
|  * You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
 | |
|  * or http://www.opensolaris.org/os/licensing.
 | |
|  * See the License for the specific language governing permissions
 | |
|  * and limitations under the License.
 | |
|  *
 | |
|  * When distributing Covered Code, include this CDDL HEADER in each
 | |
|  * file and include the License file at usr/src/OPENSOLARIS.LICENSE.
 | |
|  * If applicable, add the following below this CDDL HEADER, with the
 | |
|  * fields enclosed by brackets "[]" replaced with your own identifying
 | |
|  * information: Portions Copyright [yyyy] [name of copyright owner]
 | |
|  *
 | |
|  * CDDL HEADER END
 | |
|  */
 | |
| 
 | |
| #if defined(_KERNEL) && defined(HAVE_DECLARE_EVENT_CLASS)
 | |
| 
 | |
| #undef TRACE_SYSTEM
 | |
| #define	TRACE_SYSTEM zfs
 | |
| 
 | |
| #undef TRACE_SYSTEM_VAR
 | |
| #define	TRACE_SYSTEM_VAR zfs_zrlock
 | |
| 
 | |
| #if !defined(_TRACE_ZRLOCK_H) || defined(TRACE_HEADER_MULTI_READ)
 | |
| #define	_TRACE_ZRLOCK_H
 | |
| 
 | |
| #include <linux/tracepoint.h>
 | |
| #include <sys/types.h>
 | |
| 
 | |
| /*
 | |
|  * Generic support for two argument tracepoints of the form:
 | |
|  *
 | |
|  * DTRACE_PROBE2(...,
 | |
|  *     zrlock_t *, ...,
 | |
|  *     uint32_t, ...);
 | |
|  */
 | |
| 
 | |
| DECLARE_EVENT_CLASS(zfs_zrlock_class,
 | |
| 	TP_PROTO(zrlock_t *zrl, uint32_t n),
 | |
| 	TP_ARGS(zrl, n),
 | |
| 	TP_STRUCT__entry(
 | |
| 	    __field(int32_t,		refcount)
 | |
| #ifdef	ZFS_DEBUG
 | |
| 	    __field(pid_t,		owner_pid)
 | |
| 	    __string(caller, zrl->zr_caller)
 | |
| #endif
 | |
| 	    __field(uint32_t,		n)
 | |
| 	),
 | |
| 	TP_fast_assign(
 | |
| 	    __entry->refcount	= zrl->zr_refcount;
 | |
| #ifdef	ZFS_DEBUG
 | |
| 	    __entry->owner_pid	= zrl->zr_owner ? zrl->zr_owner->pid : 0;
 | |
| 	    __assign_str(caller, zrl->zr_caller);
 | |
| #endif
 | |
| 	    __entry->n		= n;
 | |
| 	),
 | |
| #ifdef	ZFS_DEBUG
 | |
| 	TP_printk("zrl { refcount %d owner_pid %d caller %s } n %u",
 | |
| 	    __entry->refcount, __entry->owner_pid, __get_str(caller),
 | |
| 	    __entry->n)
 | |
| #else
 | |
| 	TP_printk("zrl { refcount %d } n %u",
 | |
| 	    __entry->refcount, __entry->n)
 | |
| #endif
 | |
| );
 | |
| 
 | |
| #define	DEFINE_ZRLOCK_EVENT(name) \
 | |
| DEFINE_EVENT(zfs_zrlock_class, name, \
 | |
| 	TP_PROTO(zrlock_t *zrl, uint32_t n), \
 | |
| 	TP_ARGS(zrl, n))
 | |
| DEFINE_ZRLOCK_EVENT(zfs_zrlock__reentry);
 | |
| 
 | |
| #endif /* _TRACE_ZRLOCK_H */
 | |
| 
 | |
| #undef TRACE_INCLUDE_PATH
 | |
| #undef TRACE_INCLUDE_FILE
 | |
| #define	TRACE_INCLUDE_PATH sys
 | |
| #define	TRACE_INCLUDE_FILE trace_zrlock
 | |
| #include <trace/define_trace.h>
 | |
| 
 | |
| #endif /* _KERNEL && HAVE_DECLARE_EVENT_CLASS */
 |