Richard Yao d954ca19ba Fix theoretical "use-after-free" in dbuf_prefetch_indirect_done() ... Coverity complains about a "use-after-free" bug in `dbuf_prefetch_indirect_done()` because we use a pointer value after freeing its buffer. The pointer is used for refcounting in ARC (as the reference holder). There is a theoretical situation where the pointer would be reused in a way that causes the refcounting to collide, so we change the order in which we call arc_buf_destroy() and dbuf_prefetch_fini() to match the rest of the function. This prevents the theoretical situation from being a possibility. Also, we have a few return statements with a value, despite this being a void function. We clean those up while we are making changes here. Reviewed-by: Alexander Motin <mav@FreeBSD.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Neal Gompa <ngompa@datto.com> Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Closes #13869		2022-09-13 17:58:29 -07:00
..
avl	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
icp	Fix build on FreeBSD/powerpc64*	2022-09-08 10:27:25 -07:00
lua	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
nvpair	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
os	Cleanup dead spa_boot code	2022-09-13 16:40:10 -07:00
unicode	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
zcommon	Enable relatime by default	2022-08-12 14:20:25 -07:00
zfs	Fix theoretical "use-after-free" in dbuf_prefetch_indirect_done()	2022-09-13 17:58:29 -07:00
zstd	Tiered early abort, zstd edition	2022-05-24 09:43:22 -07:00
.gitignore	FreeBSD: Ignore symlink to i386 includes	2022-08-02 16:34:23 -07:00
Kbuild.in	Cleanup dead spa_boot code	2022-09-13 16:40:10 -07:00
Makefile.bsd	Cleanup dead spa_boot code	2022-09-13 16:40:10 -07:00
Makefile.in	autoconf: use include directives instead of recursing down lib	2022-05-10 10:18:11 -07:00