mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2024-12-27 19:39:35 +03:00
5b72a38d68
Authored by: Serapheim Dimitropoulos <serapheim@delphix.com> Reviewed by: Matt Ahrens <mahrens@delphix.com> Reviewed by: Chris Williamson <chris.williamson@delphix.com> Reviewed by: Pavel Zakharov <pavel.zakharov@delphix.com> Approved by: Robert Mustacchi <rm@joyent.com> Ported-by: Don Brady <don.brady@delphix.com> We want to be able to run channel programs outside of synching context. This would greatly improve performance for channel programs that just gather information, as they won't have to wait for synching context anymore. === What is implemented? This feature introduces the following: - A new command line flag in "zfs program" to specify our intention to run in open context. (The -n option) - A new flag/option within the channel program ioctl which selects the context. - Appropriate error handling whenever we try a channel program in open-context that contains zfs.sync* expressions. - Documentation for the new feature in the manual pages. === How do we handle zfs.sync functions in open context? When such a function is found by the interpreter and we are running in open context we abort the script and we spit out a descriptive runtime error. For example, given the script below ... arg = ... fs = arg["argv"][1] err = zfs.sync.destroy(fs) msg = "destroying " .. fs .. " err=" .. err return msg if we run it in open context, we will get back the following error: Channel program execution failed: [string "channel program"]:3: running functions from the zfs.sync submodule requires passing sync=TRUE to lzc_channel_program() (i.e. do not specify the "-n" command line argument) stack traceback: [C]: in function 'destroy' [string "channel program"]:3: in main chunk === What about testing? We've introduced new wrappers for all channel program tests that run each channel program as both (startard & open-context) and expect the appropriate behavior depending on the program using the zfs.sync module. OpenZFS-issue: https://www.illumos.org/issues/8677 OpenZFS-commit: https://github.com/openzfs/openzfs/commit/17a49e15 Closes #6558
362 lines
9.2 KiB
C
362 lines
9.2 KiB
C
/*
|
|
* CDDL HEADER START
|
|
*
|
|
* This file and its contents are supplied under the terms of the
|
|
* Common Development and Distribution License ("CDDL"), version 1.0.
|
|
* You may only use this file in accordance with the terms of version
|
|
* 1.0 of the CDDL.
|
|
*
|
|
* A full copy of the text of the CDDL should have accompanied this
|
|
* source. A copy of the CDDL is also available via the Internet at
|
|
* http://www.illumos.org/license/CDDL.
|
|
*
|
|
* CDDL HEADER END
|
|
*/
|
|
|
|
/*
|
|
* Copyright (c) 2016, 2017 by Delphix. All rights reserved.
|
|
*/
|
|
|
|
#include <sys/lua/lua.h>
|
|
#include <sys/lua/lauxlib.h>
|
|
|
|
#include <sys/zcp.h>
|
|
#include <sys/dsl_dir.h>
|
|
#include <sys/dsl_pool.h>
|
|
#include <sys/dsl_prop.h>
|
|
#include <sys/dsl_synctask.h>
|
|
#include <sys/dsl_dataset.h>
|
|
#include <sys/dsl_bookmark.h>
|
|
#include <sys/dsl_destroy.h>
|
|
#include <sys/dmu_objset.h>
|
|
#include <sys/zfs_znode.h>
|
|
#include <sys/zfeature.h>
|
|
#include <sys/metaslab.h>
|
|
|
|
#define DST_AVG_BLKSHIFT 14
|
|
|
|
typedef int (zcp_synctask_func_t)(lua_State *, boolean_t, nvlist_t *);
|
|
typedef struct zcp_synctask_info {
|
|
const char *name;
|
|
zcp_synctask_func_t *func;
|
|
const zcp_arg_t pargs[4];
|
|
const zcp_arg_t kwargs[2];
|
|
zfs_space_check_t space_check;
|
|
int blocks_modified;
|
|
} zcp_synctask_info_t;
|
|
|
|
/*
|
|
* Generic synctask interface for channel program syncfuncs.
|
|
*
|
|
* To perform some action in syncing context, we'd generally call
|
|
* dsl_sync_task(), but since the Lua script is already running inside a
|
|
* synctask we need to leave out some actions (such as acquiring the config
|
|
* rwlock and performing space checks).
|
|
*
|
|
* If 'sync' is false, executes a dry run and returns the error code.
|
|
*
|
|
* If we are not running in syncing context and we are not doing a dry run
|
|
* (meaning we are running a zfs.sync function in open-context) then we
|
|
* return a Lua error.
|
|
*
|
|
* This function also handles common fatal error cases for channel program
|
|
* library functions. If a fatal error occurs, err_dsname will be the dataset
|
|
* name reported in error messages, if supplied.
|
|
*/
|
|
static int
|
|
zcp_sync_task(lua_State *state, dsl_checkfunc_t *checkfunc,
|
|
dsl_syncfunc_t *syncfunc, void *arg, boolean_t sync, const char *err_dsname)
|
|
{
|
|
int err;
|
|
zcp_run_info_t *ri = zcp_run_info(state);
|
|
|
|
err = checkfunc(arg, ri->zri_tx);
|
|
if (!sync)
|
|
return (err);
|
|
|
|
if (!ri->zri_sync) {
|
|
return (luaL_error(state, "running functions from the zfs.sync "
|
|
"submodule requires passing sync=TRUE to "
|
|
"lzc_channel_program() (i.e. do not specify the \"-n\" "
|
|
"command line argument)"));
|
|
}
|
|
|
|
if (err == 0) {
|
|
syncfunc(arg, ri->zri_tx);
|
|
} else if (err == EIO) {
|
|
if (err_dsname != NULL) {
|
|
return (luaL_error(state,
|
|
"I/O error while accessing dataset '%s'",
|
|
err_dsname));
|
|
} else {
|
|
return (luaL_error(state,
|
|
"I/O error while accessing dataset."));
|
|
}
|
|
}
|
|
|
|
return (err);
|
|
}
|
|
|
|
|
|
static int zcp_synctask_destroy(lua_State *, boolean_t, nvlist_t *);
|
|
static zcp_synctask_info_t zcp_synctask_destroy_info = {
|
|
.name = "destroy",
|
|
.func = zcp_synctask_destroy,
|
|
.pargs = {
|
|
{.za_name = "filesystem | snapshot", .za_lua_type = LUA_TSTRING},
|
|
{NULL, 0}
|
|
},
|
|
.kwargs = {
|
|
{.za_name = "defer", .za_lua_type = LUA_TBOOLEAN},
|
|
{NULL, 0}
|
|
},
|
|
.space_check = ZFS_SPACE_CHECK_NONE,
|
|
.blocks_modified = 0
|
|
};
|
|
|
|
/* ARGSUSED */
|
|
static int
|
|
zcp_synctask_destroy(lua_State *state, boolean_t sync, nvlist_t *err_details)
|
|
{
|
|
int err;
|
|
const char *dsname = lua_tostring(state, 1);
|
|
|
|
boolean_t issnap = (strchr(dsname, '@') != NULL);
|
|
|
|
if (!issnap && !lua_isnil(state, 2)) {
|
|
return (luaL_error(state,
|
|
"'deferred' kwarg only supported for snapshots: %s",
|
|
dsname));
|
|
}
|
|
|
|
if (issnap) {
|
|
dsl_destroy_snapshot_arg_t ddsa = { 0 };
|
|
ddsa.ddsa_name = dsname;
|
|
if (!lua_isnil(state, 2)) {
|
|
ddsa.ddsa_defer = lua_toboolean(state, 2);
|
|
} else {
|
|
ddsa.ddsa_defer = B_FALSE;
|
|
}
|
|
|
|
err = zcp_sync_task(state, dsl_destroy_snapshot_check,
|
|
dsl_destroy_snapshot_sync, &ddsa, sync, dsname);
|
|
} else {
|
|
dsl_destroy_head_arg_t ddha = { 0 };
|
|
ddha.ddha_name = dsname;
|
|
|
|
err = zcp_sync_task(state, dsl_destroy_head_check,
|
|
dsl_destroy_head_sync, &ddha, sync, dsname);
|
|
}
|
|
|
|
return (err);
|
|
}
|
|
|
|
static int zcp_synctask_promote(lua_State *, boolean_t, nvlist_t *);
|
|
static zcp_synctask_info_t zcp_synctask_promote_info = {
|
|
.name = "promote",
|
|
.func = zcp_synctask_promote,
|
|
.pargs = {
|
|
{.za_name = "clone", .za_lua_type = LUA_TSTRING},
|
|
{NULL, 0}
|
|
},
|
|
.kwargs = {
|
|
{NULL, 0}
|
|
},
|
|
.space_check = ZFS_SPACE_CHECK_RESERVED,
|
|
.blocks_modified = 3
|
|
};
|
|
|
|
static int
|
|
zcp_synctask_promote(lua_State *state, boolean_t sync, nvlist_t *err_details)
|
|
{
|
|
int err;
|
|
dsl_dataset_promote_arg_t ddpa = { 0 };
|
|
const char *dsname = lua_tostring(state, 1);
|
|
zcp_run_info_t *ri = zcp_run_info(state);
|
|
|
|
ddpa.ddpa_clonename = dsname;
|
|
ddpa.err_ds = err_details;
|
|
ddpa.cr = ri->zri_cred;
|
|
|
|
/*
|
|
* If there was a snapshot name conflict, then err_ds will be filled
|
|
* with a list of conflicting snapshot names.
|
|
*/
|
|
err = zcp_sync_task(state, dsl_dataset_promote_check,
|
|
dsl_dataset_promote_sync, &ddpa, sync, dsname);
|
|
|
|
return (err);
|
|
}
|
|
|
|
static int zcp_synctask_rollback(lua_State *, boolean_t, nvlist_t *err_details);
|
|
static zcp_synctask_info_t zcp_synctask_rollback_info = {
|
|
.name = "rollback",
|
|
.func = zcp_synctask_rollback,
|
|
.space_check = ZFS_SPACE_CHECK_RESERVED,
|
|
.blocks_modified = 1,
|
|
.pargs = {
|
|
{.za_name = "filesystem", .za_lua_type = LUA_TSTRING},
|
|
{0, 0}
|
|
},
|
|
.kwargs = {
|
|
{0, 0}
|
|
}
|
|
};
|
|
|
|
static int
|
|
zcp_synctask_rollback(lua_State *state, boolean_t sync, nvlist_t *err_details)
|
|
{
|
|
int err;
|
|
const char *dsname = lua_tostring(state, 1);
|
|
dsl_dataset_rollback_arg_t ddra = { 0 };
|
|
|
|
ddra.ddra_fsname = dsname;
|
|
ddra.ddra_result = err_details;
|
|
|
|
err = zcp_sync_task(state, dsl_dataset_rollback_check,
|
|
dsl_dataset_rollback_sync, &ddra, sync, dsname);
|
|
|
|
return (err);
|
|
}
|
|
|
|
static int zcp_synctask_snapshot(lua_State *, boolean_t, nvlist_t *);
|
|
static zcp_synctask_info_t zcp_synctask_snapshot_info = {
|
|
.name = "snapshot",
|
|
.func = zcp_synctask_snapshot,
|
|
.pargs = {
|
|
{.za_name = "filesystem@snapname | volume@snapname",
|
|
.za_lua_type = LUA_TSTRING},
|
|
{NULL, 0}
|
|
},
|
|
.kwargs = {
|
|
{NULL, 0}
|
|
},
|
|
.space_check = ZFS_SPACE_CHECK_NORMAL,
|
|
.blocks_modified = 3
|
|
};
|
|
|
|
/* ARGSUSED */
|
|
static int
|
|
zcp_synctask_snapshot(lua_State *state, boolean_t sync, nvlist_t *err_details)
|
|
{
|
|
int err;
|
|
dsl_dataset_snapshot_arg_t ddsa = { 0 };
|
|
const char *dsname = lua_tostring(state, 1);
|
|
zcp_run_info_t *ri = zcp_run_info(state);
|
|
|
|
/*
|
|
* On old pools, the ZIL must not be active when a snapshot is created,
|
|
* but we can't suspend the ZIL because we're already in syncing
|
|
* context.
|
|
*/
|
|
if (spa_version(ri->zri_pool->dp_spa) < SPA_VERSION_FAST_SNAP) {
|
|
return (ENOTSUP);
|
|
}
|
|
|
|
/*
|
|
* We only allow for a single snapshot rather than a list, so the
|
|
* error list output is unnecessary.
|
|
*/
|
|
ddsa.ddsa_errors = NULL;
|
|
ddsa.ddsa_props = NULL;
|
|
ddsa.ddsa_cr = ri->zri_cred;
|
|
ddsa.ddsa_snaps = fnvlist_alloc();
|
|
fnvlist_add_boolean(ddsa.ddsa_snaps, dsname);
|
|
|
|
zcp_cleanup_handler_t *zch = zcp_register_cleanup(state,
|
|
(zcp_cleanup_t *)&fnvlist_free, ddsa.ddsa_snaps);
|
|
|
|
err = zcp_sync_task(state, dsl_dataset_snapshot_check,
|
|
dsl_dataset_snapshot_sync, &ddsa, sync, dsname);
|
|
|
|
zcp_deregister_cleanup(state, zch);
|
|
fnvlist_free(ddsa.ddsa_snaps);
|
|
|
|
return (err);
|
|
}
|
|
|
|
static int
|
|
zcp_synctask_wrapper(lua_State *state)
|
|
{
|
|
int err;
|
|
zcp_cleanup_handler_t *zch;
|
|
int num_ret = 1;
|
|
nvlist_t *err_details = fnvlist_alloc();
|
|
|
|
/*
|
|
* Make sure err_details is properly freed, even if a fatal error is
|
|
* thrown during the synctask.
|
|
*/
|
|
zch = zcp_register_cleanup(state,
|
|
(zcp_cleanup_t *)&fnvlist_free, err_details);
|
|
|
|
zcp_synctask_info_t *info = lua_touserdata(state, lua_upvalueindex(1));
|
|
boolean_t sync = lua_toboolean(state, lua_upvalueindex(2));
|
|
|
|
zcp_run_info_t *ri = zcp_run_info(state);
|
|
dsl_pool_t *dp = ri->zri_pool;
|
|
|
|
/* MOS space is triple-dittoed, so we multiply by 3. */
|
|
uint64_t funcspace = (info->blocks_modified << DST_AVG_BLKSHIFT) * 3;
|
|
|
|
zcp_parse_args(state, info->name, info->pargs, info->kwargs);
|
|
|
|
err = 0;
|
|
if (info->space_check != ZFS_SPACE_CHECK_NONE && funcspace > 0) {
|
|
uint64_t quota = dsl_pool_adjustedsize(dp,
|
|
info->space_check == ZFS_SPACE_CHECK_RESERVED) -
|
|
metaslab_class_get_deferred(spa_normal_class(dp->dp_spa));
|
|
uint64_t used = dsl_dir_phys(dp->dp_root_dir)->dd_used_bytes +
|
|
ri->zri_space_used;
|
|
|
|
if (used + funcspace > quota) {
|
|
err = SET_ERROR(ENOSPC);
|
|
}
|
|
}
|
|
|
|
if (err == 0) {
|
|
err = info->func(state, sync, err_details);
|
|
}
|
|
|
|
if (err == 0) {
|
|
ri->zri_space_used += funcspace;
|
|
}
|
|
|
|
lua_pushnumber(state, (lua_Number)err);
|
|
if (fnvlist_num_pairs(err_details) > 0) {
|
|
(void) zcp_nvlist_to_lua(state, err_details, NULL, 0);
|
|
num_ret++;
|
|
}
|
|
|
|
zcp_deregister_cleanup(state, zch);
|
|
fnvlist_free(err_details);
|
|
|
|
return (num_ret);
|
|
}
|
|
|
|
int
|
|
zcp_load_synctask_lib(lua_State *state, boolean_t sync)
|
|
{
|
|
int i;
|
|
zcp_synctask_info_t *zcp_synctask_funcs[] = {
|
|
&zcp_synctask_destroy_info,
|
|
&zcp_synctask_promote_info,
|
|
&zcp_synctask_rollback_info,
|
|
&zcp_synctask_snapshot_info,
|
|
NULL
|
|
};
|
|
|
|
lua_newtable(state);
|
|
|
|
for (i = 0; zcp_synctask_funcs[i] != NULL; i++) {
|
|
zcp_synctask_info_t *info = zcp_synctask_funcs[i];
|
|
lua_pushlightuserdata(state, info);
|
|
lua_pushboolean(state, sync);
|
|
lua_pushcclosure(state, &zcp_synctask_wrapper, 2);
|
|
lua_setfield(state, -2, info->name);
|
|
info++;
|
|
}
|
|
|
|
return (1);
|
|
}
|