mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2025-07-07 08:17:41 +03:00
d16c029f99
See issue #8226: Property filesystem_limit does not work as documented There have been previous attempts to fix the behavior on Linux, but so far the issue is still open. See PRs #8228, #8280. The existing tests pass for the incorrect behavior. This is a problem on FreeBSD; we are failing the tests because we implement the feature correctly. I have adapted the tests based on the work by @loli10k in #8280 and extended the changes to fix the snapshot_limit test as well. Linux now fails these tests, so entries linking to the issue have been added to the "maybe" group in zts-report.py. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes #10082
128 lines
5.2 KiB
Bash
Executable File
128 lines
5.2 KiB
Bash
Executable File
#!/bin/ksh -p
|
|
#
|
|
# This file and its contents are supplied under the terms of the
|
|
# Common Development and Distribution License ("CDDL"), version 1.0.
|
|
# You may only use this file in accordance with the terms of version
|
|
# 1.0 of the CDDL.
|
|
#
|
|
# A full copy of the text of the CDDL should have accompanied this
|
|
# source. A copy of the CDDL is also available via the Internet at
|
|
# http://www.illumos.org/license/CDDL.
|
|
#
|
|
|
|
#
|
|
# Copyright 2018, loli10K <ezomori.nozomu@gmail.com>. All rights reserved.
|
|
#
|
|
|
|
. $STF_SUITE/include/libtest.shlib
|
|
. $STF_SUITE/tests/functional/delegate/delegate_common.kshlib
|
|
|
|
#
|
|
# DESCRIPTION:
|
|
# ZFS 'filesystem_limit' is enforced when executing various actions
|
|
# NOTE: the limit should *not* be enforced if the user is allowed to change it.
|
|
#
|
|
# STRATEGY:
|
|
# 1. Verify 'zfs create' and 'zfs clone' cannot exceed the filesystem_limit
|
|
# 2. Verify 'zfs rename' cannot move filesystems exceeding the limit
|
|
# 3. Verify 'zfs receive' cannot exceed the limit
|
|
#
|
|
|
|
verify_runnable "both"
|
|
|
|
function setup
|
|
{
|
|
# We can't delegate 'mount' privs under Linux: to avoid issues with
|
|
# commands that may need to (re)mount datasets we set mountpoint=none
|
|
if is_linux; then
|
|
log_must zfs create -o mountpoint=none "$DATASET_TEST"
|
|
log_must zfs create -o mountpoint=none "$DATASET_UTIL"
|
|
else
|
|
log_must zfs create "$DATASET_TEST"
|
|
log_must zfs create "$DATASET_UTIL"
|
|
fi
|
|
if is_freebsd; then
|
|
# Ensure our non-root user has the permission to create the
|
|
# mountpoints and mount the filesystems.
|
|
sysctl vfs.usermount=1
|
|
log_must chmod 777 $(get_prop mountpoint "$DATASET_TEST")
|
|
log_must chmod 777 $(get_prop mountpoint "$DATASET_UTIL")
|
|
fi
|
|
log_must zfs allow -d -l $STAFF1 'create,mount,rename,clone,receive' \
|
|
"$DATASET_TEST"
|
|
log_must zfs allow -d -l $STAFF1 'create,mount,rename,clone,receive' \
|
|
"$DATASET_UTIL"
|
|
}
|
|
|
|
function cleanup
|
|
{
|
|
if is_freebsd; then
|
|
sysctl vfs.usermount=0
|
|
fi
|
|
destroy_dataset "$DATASET_TEST" "-Rf"
|
|
destroy_dataset "$DATASET_UTIL" "-Rf"
|
|
rm -f $ZSTREAM
|
|
}
|
|
|
|
log_assert "Verify 'filesystem_limit' is enforced executing various actions"
|
|
log_onexit cleanup
|
|
|
|
DATASET_TEST="$TESTPOOL/$TESTFS/filesystem_limit_test"
|
|
DATASET_UTIL="$TESTPOOL/$TESTFS/filesystem_limit_util"
|
|
ZSTREAM="$TEST_BASE_DIR/filesystem_limit.$$"
|
|
|
|
# 1. Verify 'zfs create' and 'zfs clone' cannot exceed the filesystem_limit
|
|
setup
|
|
# NOTE: we allow 'canmount' to the non-root user so we can use 'log_must' with
|
|
# 'user_run zfs create -o canmount=off' successfully
|
|
log_must zfs allow -d -l $STAFF1 'canmount' "$DATASET_TEST"
|
|
log_must zfs set filesystem_limit=1 "$DATASET_TEST"
|
|
log_must user_run $STAFF1 zfs create -o canmount=off "$DATASET_TEST/create"
|
|
log_mustnot user_run $STAFF1 zfs create -o canmount=off "$DATASET_TEST/create_exceed"
|
|
log_mustnot datasetexists "$DATASET_TEST/create_exceed"
|
|
log_must zfs set filesystem_limit=2 "$DATASET_TEST"
|
|
log_must zfs snapshot "$DATASET_TEST/create@snap"
|
|
log_must user_run $STAFF1 zfs clone -o canmount=off "$DATASET_TEST/create@snap" "$DATASET_TEST/clone"
|
|
log_mustnot user_run $STAFF1 zfs clone -o canmount=off "$DATASET_TEST/create@snap" "$DATASET_TEST/clone_exceed"
|
|
log_mustnot datasetexists "$DATASET_TEST/clone_exceed"
|
|
log_must test "$(get_prop 'filesystem_count' "$DATASET_TEST")" == "2"
|
|
# Verify filesystem_limit is *not* enforced for users allowed to change it
|
|
log_must zfs create "$DATASET_TEST/create_notenforced_root"
|
|
log_must zfs allow -l $STAFF1 'filesystem_limit' "$DATASET_TEST"
|
|
log_must user_run $STAFF1 zfs create -o canmount=off "$DATASET_TEST/create_notenforced_user"
|
|
log_must test "$(get_prop 'filesystem_count' "$DATASET_TEST")" == "4"
|
|
cleanup
|
|
|
|
# 2. Verify 'zfs rename' cannot move filesystems exceeding the limit
|
|
setup
|
|
log_must zfs set filesystem_limit=0 "$DATASET_UTIL"
|
|
log_must zfs create "$DATASET_TEST/rename"
|
|
log_mustnot user_run $STAFF1 zfs rename "$DATASET_TEST/rename" "$DATASET_UTIL/renamed"
|
|
log_mustnot datasetexists "$DATASET_UTIL/renamed"
|
|
log_must test "$(get_prop 'filesystem_count' "$DATASET_UTIL")" == "0"
|
|
# Verify filesystem_limit is *not* enforced for users allowed to change it
|
|
log_must zfs rename "$DATASET_TEST/rename" "$DATASET_UTIL/renamed_notenforced_root"
|
|
log_must zfs rename "$DATASET_UTIL/renamed_notenforced_root" "$DATASET_TEST/rename"
|
|
log_must zfs allow -l $STAFF1 'filesystem_limit' "$DATASET_UTIL"
|
|
log_must user_run $STAFF1 zfs rename "$DATASET_TEST/rename" "$DATASET_UTIL/renamed_notenforced_user"
|
|
log_must datasetexists "$DATASET_UTIL/renamed_notenforced_user"
|
|
cleanup
|
|
|
|
# 3. Verify 'zfs receive' cannot exceed the limit
|
|
setup
|
|
log_must zfs set filesystem_limit=0 "$DATASET_TEST"
|
|
log_must zfs create "$DATASET_UTIL/send"
|
|
log_must zfs snapshot "$DATASET_UTIL/send@snap1"
|
|
log_must eval "zfs send $DATASET_UTIL/send@snap1 > $ZSTREAM"
|
|
log_mustnot user_run $STAFF1 eval "zfs receive $DATASET_TEST/received < $ZSTREAM"
|
|
log_mustnot datasetexists "$DATASET_TEST/received"
|
|
log_must test "$(get_prop 'filesystem_count' "$DATASET_TEST")" == "0"
|
|
# Verify filesystem_limit is *not* enforced for users allowed to change it
|
|
log_must eval "zfs receive $DATASET_TEST/received < $ZSTREAM"
|
|
log_must zfs destroy -r "$DATASET_TEST/received"
|
|
log_must zfs allow -l $STAFF1 'filesystem_limit' "$DATASET_TEST"
|
|
log_must user_run $STAFF1 eval "zfs receive $DATASET_TEST/received < $ZSTREAM"
|
|
log_must datasetexists "$DATASET_TEST/received"
|
|
|
|
log_pass "'filesystem_limit' property is enforced"
|