mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2024-12-26 03:09:34 +03:00
0cf14bf4b5
torvalds/linux@09022bc196 removes the flag, and the corresponding SetPageError() and ClearPageError() macros, with no replacement offered. Going back through the upstream history, use of this flag has been gradually removed over the last year as part of the long tail of converting everything to folios. Interesting tidbit comments from torvalds/linux@29e9412b25 and torvalds/linux@420e05d0de suggest that this flag has not been used meaningfully since page writeback failures started being recorded in errseq_t instead (the whole "fsyncgate" thing, ~2017, around torvalds/linux@8ed1e46aaf). Given that, it's possible that since perhaps Linux 4.13 we haven't been getting anything by setting the flag. I don't know if that's true and/or if there's something we should be doing instead, but my gut feel is that its probably fine we only use the page cache as a proxy to allow mmap() to work, rather than backing IO with it. As such, I'm expecting that removing this will do no harm, but I'm leaving it in for older kernels to maintain status quo, and if there is an overall better way, that is left for a future change. Sponsored-by: https://despairlabs.com/sponsor/ Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Rob Norris <robn@despairlabs.com> Closes #16582
25 lines
650 B
Plaintext
25 lines
650 B
Plaintext
AC_DEFUN([ZFS_AC_KERNEL_SRC_MM_PAGE_FLAG_ERROR], [
|
|
ZFS_LINUX_TEST_SRC([mm_page_flag_error], [
|
|
#include <linux/page-flags.h>
|
|
|
|
static enum pageflags
|
|
test_flag __attribute__((unused)) = PG_error;
|
|
])
|
|
])
|
|
AC_DEFUN([ZFS_AC_KERNEL_MM_PAGE_FLAG_ERROR], [
|
|
AC_MSG_CHECKING([whether PG_error flag is available])
|
|
ZFS_LINUX_TEST_RESULT([mm_page_flag_error], [
|
|
AC_MSG_RESULT(yes)
|
|
AC_DEFINE(HAVE_MM_PAGE_FLAG_ERROR, 1, [PG_error flag is available])
|
|
],[
|
|
AC_MSG_RESULT(no)
|
|
])
|
|
])
|
|
|
|
AC_DEFUN([ZFS_AC_KERNEL_SRC_MM_PAGE_FLAGS], [
|
|
ZFS_AC_KERNEL_SRC_MM_PAGE_FLAG_ERROR
|
|
])
|
|
AC_DEFUN([ZFS_AC_KERNEL_MM_PAGE_FLAGS], [
|
|
ZFS_AC_KERNEL_MM_PAGE_FLAG_ERROR
|
|
])
|