mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2025-03-05 20:28:20 +03:00
0cf14bf4b5
torvalds/linux@09022bc196 removes the flag, and the corresponding SetPageError() and ClearPageError() macros, with no replacement offered. Going back through the upstream history, use of this flag has been gradually removed over the last year as part of the long tail of converting everything to folios. Interesting tidbit comments from torvalds/linux@29e9412b25 and torvalds/linux@420e05d0de suggest that this flag has not been used meaningfully since page writeback failures started being recorded in errseq_t instead (the whole "fsyncgate" thing, ~2017, around torvalds/linux@8ed1e46aaf). Given that, it's possible that since perhaps Linux 4.13 we haven't been getting anything by setting the flag. I don't know if that's true and/or if there's something we should be doing instead, but my gut feel is that its probably fine we only use the page cache as a proxy to allow mmap() to work, rather than backing IO with it. As such, I'm expecting that removing this will do no harm, but I'm leaving it in for older kernels to maintain status quo, and if there is an overall better way, that is left for a future change. Sponsored-by: https://despairlabs.com/sponsor/ Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Rob Norris <robn@despairlabs.com> Closes #16582
58 lines
2.0 KiB
C
58 lines
2.0 KiB
C
/*
|
|
* CDDL HEADER START
|
|
*
|
|
* The contents of this file are subject to the terms of the
|
|
* Common Development and Distribution License (the "License").
|
|
* You may not use this file except in compliance with the License.
|
|
*
|
|
* You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
|
|
* or https://opensource.org/licenses/CDDL-1.0.
|
|
* See the License for the specific language governing permissions
|
|
* and limitations under the License.
|
|
*
|
|
* When distributing Covered Code, include this CDDL HEADER in each
|
|
* file and include the License file at usr/src/OPENSOLARIS.LICENSE.
|
|
* If applicable, add the following below this CDDL HEADER, with the
|
|
* fields enclosed by brackets "[]" replaced with your own identifying
|
|
* information: Portions Copyright [yyyy] [name of copyright owner]
|
|
*
|
|
* CDDL HEADER END
|
|
*/
|
|
|
|
/*
|
|
* Copyright (c) 2023, 2024, Klara Inc.
|
|
* Copyright (c) 2024, Rob Norris <robn@despairlabs.com>
|
|
*/
|
|
|
|
#ifndef _ZFS_MM_COMPAT_H
|
|
#define _ZFS_MM_COMPAT_H
|
|
|
|
#include <linux/mm.h>
|
|
#include <linux/pagemap.h>
|
|
|
|
/* 5.4 introduced page_size(). Older kernels can use a trivial macro instead */
|
|
#ifndef HAVE_MM_PAGE_SIZE
|
|
#define page_size(p) ((unsigned long)(PAGE_SIZE << compound_order(p)))
|
|
#endif
|
|
|
|
/* 6.11 removed page_mapping(). A simple wrapper around folio_mapping() works */
|
|
#ifndef HAVE_MM_PAGE_MAPPING
|
|
#define page_mapping(p) folio_mapping(page_folio(p))
|
|
#endif
|
|
|
|
/*
|
|
* 6.12 removed PG_error, SetPageError and ClearPageError, with no direct
|
|
* replacement, because page writeback errors are recorded elsewhere. Since we
|
|
* only use the page cache to assist with mmap(), never directly backing it
|
|
* with IO, it shouldn't be possible for this condition to occur on our pages
|
|
* anyway, even if this is the right way to report it. So it should be safe
|
|
* to remove, but for avoidance of doubt, we make it a no-op on 6.12 and leave
|
|
* it for everything else.
|
|
*/
|
|
#ifndef HAVE_MM_PAGE_FLAG_ERROR
|
|
#define SetPageError(p) do {} while (0)
|
|
#define ClearPageError(p) do {} while (0)
|
|
#endif
|
|
|
|
#endif /* _ZFS_MM_COMPAT_H */
|