mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2024-11-17 01:51:00 +03:00
8df0bde321
Change enforced shell type from `dash` to `sh` and excluded `SC2039` and `SC3043` by default. `local` keyword is accepted by all POSIX shells from practical point of view. There is no need anymore to enforce dash so `local` is accepted. Reviewed-by: George Melikov <mail@gmelikov.ru> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: szubersk <szuberskidamian@gmail.com> Closes #13020 |
||
|---|---|---|
| .. | ||
| .gitignore | ||
| all-debug.sh | ||
| all-syslog.sh | ||
| data-notify.sh | ||
| generic-notify.sh | ||
| history_event-zfs-list-cacher.sh.in | ||
| Makefile.am | ||
| pool_import-led.sh | ||
| README | ||
| resilver_finish-notify.sh | ||
| resilver_finish-start-scrub.sh | ||
| scrub_finish-notify.sh | ||
| statechange-led.sh | ||
| statechange-notify.sh | ||
| trim_finish-notify.sh | ||
| vdev_attach-led.sh | ||
| vdev_clear-led.sh | ||
| zed-functions.sh | ||
| zed.rc | ||
Shell scripts are the recommended choice for ZEDLETs that mostly call other utilities and do relatively little data manipulation. Shell scripts MUST work on both bash and dash. Shell scripts MUST run cleanly through ShellCheck: http://www.shellcheck.net/ General functions reside in "zed-functions.sh". Use them where applicable. Additional references that may be of use: Google Shell Style Guide https://github.com/google/styleguide/blob/gh-pages/shell.xml Dash as /bin/sh https://wiki.ubuntu.com/DashAsBinSh Common shell script mistakes http://www.pixelbeat.org/programming/shell_script_mistakes.html Filenames and Pathnames in Shell: How to do it Correctly http://www.dwheeler.com/essays/filenames-in-shell.html Autoconf: Portable Shell Programming https://www.gnu.org/software/autoconf/manual/autoconf.html#Portable-Shell Please BE CONSISTENT with the existing style, check for errors, minimize dependencies where possible, try to be portable, and comment anything non-obvious. Festina lente.