mirror_zfs/include
Rob Norris 3e7e19e028 pool_iter_refresh: don't refresh pools twice
In "all pools" mode, pool_iter_refresh() will call zpool_iter(), which
will call zpool_refresh_stats() before calling add_pool(). If we already
have the pool, this is a different handle, so we just release it and
return. Back in pool_iter_refresh(), we then call zpool_stats_refresh()
again for our handle on the same pool.

All together, this means we're doing two ZFS_IOC_POOL_STATS calls into
the kernel for every pool in the system. This isn't wrong, but it does
double the pressure on global locks.

Instead, we add a new function zpool_refresh_stats_from_handle() that
simply copies the pool config and state from one handle to another, and
use it to update our handle before we release it in add_pool(), so we
only have one call per pool per interval.

Sponsored-by: Klara, Inc.
Sponsored-by: Wasabi Technology, Inc.
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rob Norris <rob.norris@klarasystems.com>
Closes #17807
2025-10-21 09:50:43 -07:00
..
os zvol: Fix blk-mq sync 2025-09-29 16:50:43 -07:00
sys spa_config: Rename spa_config_enter_mmp() to spa_config_enter_priority() 2025-10-21 09:50:43 -07:00
.gitignore OpenZFS restructuring - move platform specific sources 2019-09-06 11:26:26 -07:00
cityhash.h SPDX: license tags: MIT 2025-03-13 17:56:54 -07:00
libnvpair.h SPDX: license tags: CDDL-1.0 2025-03-13 17:56:27 -07:00
libuutil_common.h SPDX: license tags: CDDL-1.0 2025-03-13 17:56:27 -07:00
libuutil_impl.h SPDX: license tags: CDDL-1.0 2025-03-13 17:56:27 -07:00
libuutil.h SPDX: license tags: CDDL-1.0 2025-03-13 17:56:27 -07:00
libzdb.h libzdb: Initial breakout of libzdb 2024-02-05 10:00:41 -08:00
libzfs_core.h SPDX: license tags: CDDL-1.0 2025-03-13 17:56:27 -07:00
libzfs.h pool_iter_refresh: don't refresh pools twice 2025-10-21 09:50:43 -07:00
libzfsbootenv.h SPDX: license tags: CDDL-1.0 2025-03-13 17:56:27 -07:00
libzutil.h SPDX: license tags: CDDL-1.0 2025-03-13 17:56:27 -07:00
Makefile.am Add TXG timestamp database 2025-08-06 10:31:21 -07:00
thread_pool.h SPDX: license tags: CDDL-1.0 2025-03-13 17:56:27 -07:00
zfeature_common.h Implement physical rewrites 2025-08-06 10:36:56 -07:00
zfs_comutil.h SPDX: license tags: CDDL-1.0 2025-03-13 17:56:27 -07:00
zfs_crrd.h Add TXG timestamp database 2025-08-06 10:31:21 -07:00
zfs_deleg.h ZFS allow send:encrypted 2025-09-12 15:05:02 -07:00
zfs_fletcher.h SPDX: license tags: CDDL-1.0 2025-03-13 17:56:27 -07:00
zfs_namecheck.h SPDX: license tags: CDDL-1.0 2025-03-13 17:56:27 -07:00
zfs_prop.h SPDX: license tags: CDDL-1.0 2025-03-13 17:56:27 -07:00
zfs_valstr.h events: include zio type in IO error reports 2025-05-30 10:29:29 -04:00