John Poduska c161360dce Resilver restarts unnecessarily when it encounters errors ... When a resilver finishes, vdev_dtl_reassess is called to hopefully excise DTL_MISSING (amongst other things). If there are errors during the resilver, they are tracked in DTL_SCRUB, as spelled out in the block comment in vdev.c. DTL_SCRUB is in-core only, so it can only be used if the pool was online for the whole resilver. This state is tracked with the spa_scrub_started flag, which only gets set when the scan is initialized. Unfortunately, this flag gets cleared right before vdev_dtl_reassess gets called, so if there are any errors during the scan, DTL_MISSING will never get excised and the resilver will just continually restart. This fix simply moves clearing that flag until after the call to vdev_dtl_reasses. In addition, if a pool is imported and already has scn_errors > 0, this change will restart the resilver immediately instead of doing the rest of the scan and then restarting it from the beginning. On the other hand, if scn_errors == 0 at import, then no errors have been encountered so far, so the spa_scrub_started flag can be safely set. A test has been added to verify that resilver does not restart when relevant DTL's are available. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Paul Zuchowski <pzuchowski@datto.com> Signed-off-by: John Poduska <jpoduska@datto.com> Closes #10291		2020-09-22 11:33:35 -07:00
..
abd.c	single-chunk scatter ABDs can be treated as linear	2020-01-22 13:48:56 -08:00
aggsum.c	OpenZFS 9688 - aggsum_fini leaks memory	2018-10-19 12:08:03 -07:00
arc.c	Use boot_ncpus in place of max_ncpus in taskq_create	2020-09-16 13:35:42 -07:00
blkptr.c
bplist.c
bpobj.c	Stack overflow in recursive bpobj_iterate_impl	2019-03-06 09:50:55 -08:00
bptree.c
bqueue.c	Wait in 'S' state when send/recv pipe is blocking	2019-06-07 12:45:40 -07:00
cityhash.c	OpenZFS 8484 - Implement aggregate sum and use for arc counters	2018-06-06 09:35:59 -07:00
dataset_kstats.c	Fix panic on DilOS with kstat per dataset statistics	2020-01-22 13:49:00 -08:00
dbuf_stats.c	Prefix all refcount functions with zfs_	2018-10-01 10:42:05 -07:00
dbuf.c	Fix typos in module/zfs/	2020-01-22 13:48:59 -08:00
ddt_zap.c	fat zap should prefetch when iterating	2019-09-25 11:27:47 -07:00
ddt.c	Replace sprintf()->snprintf() and strcpy()->strlcpy()	2020-09-15 21:16:58 +00:00
dmu_diff.c	diff_cb() does not handle large dnodes	2020-01-22 13:49:01 -08:00
dmu_object.c	Fix send/recv lost spill block	2019-05-07 15:18:44 -07:00
dmu_objset.c	Replace sprintf()->snprintf() and strcpy()->strlcpy()	2020-09-15 21:16:58 +00:00
dmu_recv.c	Always refuse receving non-resume stream when resume state exists	2019-09-25 11:27:51 -07:00
dmu_send.c	Fix send/recv lost spill block	2019-05-07 15:18:44 -07:00
dmu_traverse.c	Fix traverse_impl() kmem leak	2018-08-15 09:53:44 -07:00
dmu_tx.c	Improve performance by using dmu_tx_hold_*_by_dnode()	2019-09-25 11:27:50 -07:00
dmu_zfetch.c	Fix typos in module/zfs/	2020-01-22 13:48:59 -08:00
dmu.c	Export dmu_offset_next() symbol	2020-09-16 14:17:51 -07:00
dnode_sync.c	Reinstate raw receive check when truncating	2019-06-07 12:45:40 -07:00
dnode.c	cppcheck: (warning) Possible null pointer dereference: dnp	2020-01-22 13:49:06 -08:00
dsl_bookmark.c	Fix typos in module/zfs/	2020-01-22 13:48:59 -08:00
dsl_crypt.c	Add missing zfs_refcount_destroy() in key_mapping_rele()	2020-05-12 10:53:32 -07:00
dsl_dataset.c	Replace sprintf()->snprintf() and strcpy()->strlcpy()	2020-09-15 21:16:58 +00:00
dsl_deadlist.c
dsl_deleg.c	Update build system and packaging	2018-05-29 16:00:33 -07:00
dsl_destroy.c	Fix typos in module/zfs/	2020-01-22 13:48:59 -08:00
dsl_dir.c	Replace sprintf()->snprintf() and strcpy()->strlcpy()	2020-09-15 21:16:58 +00:00
dsl_pool.c	Use boot_ncpus in place of max_ncpus in taskq_create	2020-09-16 13:35:42 -07:00
dsl_prop.c	Replace sprintf()->snprintf() and strcpy()->strlcpy()	2020-09-15 21:16:58 +00:00
dsl_scan.c	Resilver restarts unnecessarily when it encounters errors	2020-09-22 11:33:35 -07:00
dsl_synctask.c	Fix typos in module/zfs/	2020-01-22 13:48:59 -08:00
dsl_userhold.c	Replace sprintf()->snprintf() and strcpy()->strlcpy()	2020-09-15 21:16:58 +00:00
edonr_zfs.c
fm.c	Fix typos in module/zfs/	2020-01-22 13:48:59 -08:00
gzip.c	Update build system and packaging	2018-05-29 16:00:33 -07:00
hkdf.c
lz4.c	Reword comment in lz4_compress_zfs	2019-05-02 16:46:04 -07:00
lzjb.c
Makefile.in	Add TRIM support	2019-03-29 09:13:20 -07:00
metaslab.c	Prevent metaslab_sync panic due to spa_final_dirty_txg	2020-01-22 13:48:58 -08:00
mmp.c	Initialize mmp_last_write when the mmp thread starts (#10912)	2020-09-16 00:16:47 +00:00
multilist.c	Avoid extra taskq_dispatch() calls by DMU	2019-09-25 11:27:48 -07:00
pathname.c	Disable unused pathname::pn_path* (unneeded in Linux)	2019-09-25 11:27:49 -07:00
policy.c	Fix typos in module/zfs/	2020-01-22 13:48:59 -08:00
qat_compress.c	Fix zfs-0.8.3 "qat.h"	2020-01-22 13:49:07 -08:00
qat_crypt.c	Fix zfs-0.8.3 "qat.h"	2020-01-22 13:49:07 -08:00
qat.c	Fix zfs-0.8.3 "qat.h"	2020-01-22 13:49:07 -08:00
qat.h	Fix typos in module/zfs/	2020-01-22 13:48:59 -08:00
range_tree.c	Restrict kstats and print real pointers	2019-04-04 18:57:06 -07:00
refcount.c	Prevent race in blkptr_verify against device removal	2020-01-22 13:48:57 -08:00
rrwlock.c	Prefix all refcount functions with zfs_	2018-10-01 10:42:05 -07:00
sa.c	Fix typos in module/zfs/	2020-01-22 13:48:59 -08:00
sha256.c
skein_zfs.c
spa_boot.c
spa_checkpoint.c	Fix typos in module/zfs/	2020-01-22 13:48:59 -08:00
spa_config.c	Fix /etc/hostid on root pool deadlock	2019-09-25 11:27:51 -07:00
spa_errlog.c	Fix typos in module/zfs/	2020-01-22 13:48:59 -08:00
spa_history.c	Fix typos in module/zfs/	2020-01-22 13:48:59 -08:00
spa_misc.c	Prevent race in blkptr_verify against device removal	2020-01-22 13:48:57 -08:00
spa_stats.c	Restrict kstats and print real pointers	2019-04-04 18:57:06 -07:00
spa.c	Replace sprintf()->snprintf() and strcpy()->strlcpy()	2020-09-15 21:16:58 +00:00
space_map.c	Restrict kstats and print real pointers	2019-04-04 18:57:06 -07:00
space_reftree.c
THIRDPARTYLICENSE.cityhash	OpenZFS 8484 - Implement aggregate sum and use for arc counters	2018-06-06 09:35:59 -07:00
THIRDPARTYLICENSE.cityhash.descrip	OpenZFS 8484 - Implement aggregate sum and use for arc counters	2018-06-06 09:35:59 -07:00
trace.c
txg.c	Use boot_ncpus in place of max_ncpus in taskq_create	2020-09-16 13:35:42 -07:00
uberblock.c	MMP interval and fail_intervals in uberblock	2019-03-21 12:47:57 -07:00
unique.c
vdev_cache.c	Fix typos in module/zfs/	2020-01-22 13:48:59 -08:00
vdev_disk.c	Linux 5.5 compat: blkg_tryget()	2020-05-12 10:53:32 -07:00
vdev_file.c	Update vdev_ops_t from illumos	2019-09-25 11:27:48 -07:00
vdev_indirect_births.c	Fixes: #8934 Large kmem_alloc	2019-09-25 11:27:49 -07:00
vdev_indirect_mapping.c	Get rid of space_map_update() for ms_synced_length	2019-02-12 10:38:11 -08:00
vdev_indirect.c	Update vdev_ops_t from illumos	2019-09-25 11:27:48 -07:00
vdev_initialize.c	Linux 5.6 compat: time_t	2020-05-12 10:53:32 -07:00
vdev_label.c	panic in removal_remap test on 4K devices	2019-09-25 11:27:47 -07:00
vdev_mirror.c	Avoid some crashes when importing a pool with corrupt metadata	2020-01-22 13:49:06 -08:00
vdev_missing.c	Update vdev_ops_t from illumos	2019-09-25 11:27:48 -07:00
vdev_queue.c	Fix typos in module/zfs/	2020-01-22 13:48:59 -08:00
vdev_raidz_math_aarch64_neon_common.h	Fix typos in module/zfs/	2020-01-22 13:48:59 -08:00
vdev_raidz_math_aarch64_neon.c	Linux 5.0 compat: SIMD compatibility	2020-01-22 13:49:01 -08:00
vdev_raidz_math_aarch64_neonx2.c	Linux 5.0 compat: SIMD compatibility	2020-01-22 13:49:01 -08:00
vdev_raidz_math_avx2.c	Linux 5.0 compat: SIMD compatibility	2020-01-22 13:49:01 -08:00
vdev_raidz_math_avx512bw.c	Linux 5.0 compat: SIMD compatibility	2020-01-22 13:49:01 -08:00
vdev_raidz_math_avx512f.c	Linux 5.0 compat: SIMD compatibility	2020-01-22 13:49:01 -08:00
vdev_raidz_math_impl.h
vdev_raidz_math_scalar.c	Linux 5.3: Fix switch() fall though compiler errors	2019-09-25 11:27:50 -07:00
vdev_raidz_math_sse2.c	Linux 5.0 compat: SIMD compatibility	2020-01-22 13:49:01 -08:00
vdev_raidz_math_ssse3.c	Linux 5.0 compat: SIMD compatibility	2020-01-22 13:49:01 -08:00
vdev_raidz_math.c	Linux 5.0 compat: SIMD compatibility	2020-01-22 13:49:01 -08:00
vdev_raidz.c	Fix typos in module/zfs/	2020-01-22 13:48:59 -08:00
vdev_removal.c	Cancel initialize and TRIM before vdev_metaslab_fini()	2020-01-22 13:49:06 -08:00
vdev_root.c	Update vdev_ops_t from illumos	2019-09-25 11:27:48 -07:00
vdev_trim.c	Linux 5.6 compat: time_t	2020-05-12 10:53:32 -07:00
vdev.c	Resilver restarts unnecessarily when it encounters errors	2020-09-22 11:33:35 -07:00
zap_leaf.c	Off-by-one in zap_leaf_array_create()	2019-01-18 09:58:46 -08:00
zap_micro.c	Replace sprintf()->snprintf() and strcpy()->strlcpy()	2020-09-15 21:16:58 +00:00
zap.c	Replace sprintf()->snprintf() and strcpy()->strlcpy()	2020-09-15 21:16:58 +00:00
zcp_get.c	Replace sprintf()->snprintf() and strcpy()->strlcpy()	2020-09-15 21:16:58 +00:00
zcp_global.c
zcp_iter.c	Fix typos in module/zfs/	2020-01-22 13:48:59 -08:00
zcp_synctask.c	OpenZFS 9166 - zfs storage pool checkpoint	2018-06-26 10:07:42 -07:00
zcp.c	Fix typos in module/zfs/	2020-01-22 13:48:59 -08:00
zfeature.c	Consistently captialize GUID for features	2019-04-16 10:01:51 -07:00
zfs_acl.c	Fix typos in module/zfs/	2020-01-22 13:48:59 -08:00
zfs_byteswap.c	Fix typos in module/zfs/	2020-01-22 13:48:59 -08:00
zfs_ctldir.c	Fix inability to destroy snapshot used over NFS	2020-09-16 14:30:51 -07:00
zfs_debug.c	Linux 5.6 compat: time_t	2020-05-12 10:53:32 -07:00
zfs_dir.c	Fix typos in module/zfs/	2020-01-22 13:48:59 -08:00
zfs_fm.c	Add zpool status -s (slow I/Os) and -p (parseable)	2018-11-08 16:47:24 -08:00
zfs_fuid.c	Update build system and packaging	2018-05-29 16:00:33 -07:00
zfs_ioctl.c	Replace sprintf()->snprintf() and strcpy()->strlcpy()	2020-09-15 21:16:58 +00:00
zfs_log.c	Improve write performance by using dmu_read_by_dnode()	2020-01-22 13:48:57 -08:00
zfs_onexit.c	Update build system and packaging	2018-05-29 16:00:33 -07:00
zfs_ratelimit.c
zfs_replay.c	Fix zil replay panic when TX_REMOVE followed by TX_CREATE	2019-09-25 11:27:51 -07:00
zfs_rlock.c	Prefix struct rangelock	2020-05-12 10:53:32 -07:00
zfs_sa.c
zfs_sysfs.c	Prevent pointer to an out-of-scope local variable	2019-09-25 11:27:48 -07:00
zfs_vfsops.c	Fix typos in module/zfs/	2020-01-22 13:48:59 -08:00
zfs_vnops.c	Prefix struct rangelock	2020-05-12 10:53:32 -07:00
zfs_znode.c	Prefix struct rangelock	2020-05-12 10:53:32 -07:00
zil.c	Improve logging of 128KB writes	2020-01-22 13:49:04 -08:00
zio_checksum.c	Fix typos in module/zfs/	2020-01-22 13:48:59 -08:00
zio_compress.c	zio_decompress_data always ASSERTs successful decompression	2020-01-22 13:49:05 -08:00
zio_crypt.c	Linux 5.0 compat: SIMD compatibility	2020-01-22 13:49:01 -08:00
zio_inject.c	Fix typos in module/zfs/	2020-01-22 13:48:59 -08:00
zio.c	Replace sprintf()->snprintf() and strcpy()->strlcpy()	2020-09-15 21:16:58 +00:00
zle.c
zpl_ctldir.c
zpl_export.c
zpl_file.c	Fix errant EFAULT during writes (#8719)	2019-05-08 10:04:04 -07:00
zpl_inode.c	Linux 5.6 compat: timestamp_truncate()	2020-05-12 10:53:32 -07:00
zpl_super.c	Fix typos in module/zfs/	2020-01-22 13:48:59 -08:00
zpl_xattr.c	Drop redundant POSIX ACL check in zpl_init_acl()	2019-09-25 11:27:49 -07:00
zrlock.c	Update build system and packaging	2018-05-29 16:00:33 -07:00
zthr.c	Fix txg_wait_open() load average inflation	2019-04-04 09:44:46 -07:00
zvol.c	Linux 5.9 compat: make_request_fn replaced with submit_bio interface	2020-09-15 21:16:58 +00:00