mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2025-01-04 23:39:33 +03:00
ab8d9c1783
Various module parameters such as `zfs_arc_max` were originally `uint64_t` on OpenSolaris/Illumos, but were changed to `unsigned long` for Linux compatibility because Linux's kernel default module parameter implementation did not support 64-bit types on 32-bit platforms. This caused problems when porting OpenZFS to Windows because its LLP64 memory model made `unsigned long` a 32-bit type on 64-bit, which created the undesireable situation that parameters that should accept 64-bit values could not on 64-bit Windows. Upon inspection, it turns out that the Linux kernel module parameter interface is extensible, such that we are allowed to define our own types. Rather than maintaining the original type change via hacks to to continue shrinking module parameters on 32-bit Linux, we implement support for 64-bit module parameters on Linux. After doing a review of all 64-bit kernel parameters (found via the man page and also proposed changes by Andrew Innes), the kernel module parameters fell into a few groups: Parameters that were originally 64-bit on Illumos: * dbuf_cache_max_bytes * dbuf_metadata_cache_max_bytes * l2arc_feed_min_ms * l2arc_feed_secs * l2arc_headroom * l2arc_headroom_boost * l2arc_write_boost * l2arc_write_max * metaslab_aliquot * metaslab_force_ganging * zfetch_array_rd_sz * zfs_arc_max * zfs_arc_meta_limit * zfs_arc_meta_min * zfs_arc_min * zfs_async_block_max_blocks * zfs_condense_max_obsolete_bytes * zfs_condense_min_mapping_bytes * zfs_deadman_checktime_ms * zfs_deadman_synctime_ms * zfs_initialize_chunk_size * zfs_initialize_value * zfs_lua_max_instrlimit * zfs_lua_max_memlimit * zil_slog_bulk Parameters that were originally 32-bit on Illumos: * zfs_per_txg_dirty_frees_percent Parameters that were originally `ssize_t` on Illumos: * zfs_immediate_write_sz Note that `ssize_t` is `int32_t` on 32-bit and `int64_t` on 64-bit. It has been upgraded to 64-bit. Parameters that were `long`/`unsigned long` because of Linux/FreeBSD influence: * l2arc_rebuild_blocks_min_l2size * zfs_key_max_salt_uses * zfs_max_log_walking * zfs_max_logsm_summary_length * zfs_metaslab_max_size_cache_sec * zfs_min_metaslabs_to_flush * zfs_multihost_interval * zfs_unflushed_log_block_max * zfs_unflushed_log_block_min * zfs_unflushed_log_block_pct * zfs_unflushed_max_mem_amt * zfs_unflushed_max_mem_ppm New parameters that do not exist in Illumos: * l2arc_trim_ahead * vdev_file_logical_ashift * vdev_file_physical_ashift * zfs_arc_dnode_limit * zfs_arc_dnode_limit_percent * zfs_arc_dnode_reduce_percent * zfs_arc_meta_limit_percent * zfs_arc_sys_free * zfs_deadman_ziotime_ms * zfs_delete_blocks * zfs_history_output_max * zfs_livelist_max_entries * zfs_max_async_dedup_frees * zfs_max_nvlist_src_size * zfs_rebuild_max_segment * zfs_rebuild_vdev_limit * zfs_unflushed_log_txg_max * zfs_vdev_max_auto_ashift * zfs_vdev_min_auto_ashift * zfs_vnops_read_chunk_size * zvol_max_discard_blocks Rather than clutter the lists with commentary, the module parameters that need comments are repeated below. A few parameters were defined in Linux/FreeBSD specific code, where the use of ulong/long is not an issue for portability, so we leave them alone: * zfs_delete_blocks * zfs_key_max_salt_uses * zvol_max_discard_blocks The documentation for a few parameters was found to be incorrect: * zfs_deadman_checktime_ms - incorrectly documented as int * zfs_delete_blocks - not documented as Linux only * zfs_history_output_max - incorrectly documented as int * zfs_vnops_read_chunk_size - incorrectly documented as long * zvol_max_discard_blocks - incorrectly documented as ulong The documentation for these has been fixed, alongside the changes to document the switch to fixed width types. In addition, several kernel module parameters were percentages or held ashift values, so being 64-bit never made sense for them. They have been downgraded to 32-bit: * vdev_file_logical_ashift * vdev_file_physical_ashift * zfs_arc_dnode_limit_percent * zfs_arc_dnode_reduce_percent * zfs_arc_meta_limit_percent * zfs_per_txg_dirty_frees_percent * zfs_unflushed_log_block_pct * zfs_vdev_max_auto_ashift * zfs_vdev_min_auto_ashift Of special note are `zfs_vdev_max_auto_ashift` and `zfs_vdev_min_auto_ashift`, which were already defined as `uint64_t`, and passed to the kernel as `ulong`. This is inherently buggy on big endian 32-bit Linux, since the values would not be written to the correct locations. 32-bit FreeBSD was unaffected because its sysctl code correctly treated this as a `uint64_t`. Lastly, a code comment suggests that `zfs_arc_sys_free` is Linux-specific, but there is nothing to indicate to me that it is Linux-specific. Nothing was done about that. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Jorgen Lundman <lundman@lundman.net> Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Original-patch-by: Andrew Innes <andrew.c12@gmail.com> Original-patch-by: Jorgen Lundman <lundman@lundman.net> Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Closes #13984 Closes #14004
205 lines
6.8 KiB
C
205 lines
6.8 KiB
C
/*
|
|
* CDDL HEADER START
|
|
*
|
|
* The contents of this file are subject to the terms of the
|
|
* Common Development and Distribution License (the "License").
|
|
* You may not use this file except in compliance with the License.
|
|
*
|
|
* You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
|
|
* or https://opensource.org/licenses/CDDL-1.0.
|
|
* See the License for the specific language governing permissions
|
|
* and limitations under the License.
|
|
*
|
|
* When distributing Covered Code, include this CDDL HEADER in each
|
|
* file and include the License file at usr/src/OPENSOLARIS.LICENSE.
|
|
* If applicable, add the following below this CDDL HEADER, with the
|
|
* fields enclosed by brackets "[]" replaced with your own identifying
|
|
* information: Portions Copyright [yyyy] [name of copyright owner]
|
|
*
|
|
* CDDL HEADER END
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2016 Gvozden Neskovic <neskovic@gmail.com>.
|
|
* Copyright (c) 2020 by Delphix. All rights reserved.
|
|
*/
|
|
|
|
#ifndef _MOD_COMPAT_H
|
|
#define _MOD_COMPAT_H
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/moduleparam.h>
|
|
|
|
/*
|
|
* Despite constifying struct kernel_param_ops, some older kernels define a
|
|
* `__check_old_set_param()` function in their headers that checks for a
|
|
* non-constified `->set()`. This has long been fixed in Linux mainline, but
|
|
* since we support older kernels, we workaround it by using a preprocessor
|
|
* definition to disable it.
|
|
*/
|
|
#define __check_old_set_param(_) (0)
|
|
|
|
typedef const struct kernel_param zfs_kernel_param_t;
|
|
|
|
#define ZMOD_RW 0644
|
|
#define ZMOD_RD 0444
|
|
|
|
enum scope_prefix_types {
|
|
zfs,
|
|
zfs_arc,
|
|
zfs_condense,
|
|
zfs_dbuf,
|
|
zfs_dbuf_cache,
|
|
zfs_deadman,
|
|
zfs_dedup,
|
|
zfs_l2arc,
|
|
zfs_livelist,
|
|
zfs_livelist_condense,
|
|
zfs_lua,
|
|
zfs_metaslab,
|
|
zfs_mg,
|
|
zfs_multihost,
|
|
zfs_prefetch,
|
|
zfs_reconstruct,
|
|
zfs_recv,
|
|
zfs_send,
|
|
zfs_spa,
|
|
zfs_trim,
|
|
zfs_txg,
|
|
zfs_vdev,
|
|
zfs_vdev_cache,
|
|
zfs_vdev_file,
|
|
zfs_vdev_mirror,
|
|
zfs_vnops,
|
|
zfs_zevent,
|
|
zfs_zio,
|
|
zfs_zil
|
|
};
|
|
|
|
/*
|
|
* While we define our own s64/u64 types, there is no reason to reimplement the
|
|
* existing Linux kernel types, so we use the preprocessor to remap our
|
|
* "custom" implementations to the kernel ones. This is done because the CPP
|
|
* does not allow us to write conditional definitions. The fourth definition
|
|
* exists because the CPP will not allow us to replace things like INT with int
|
|
* before string concatenation.
|
|
*/
|
|
|
|
#define spl_param_set_int param_set_int
|
|
#define spl_param_get_int param_get_int
|
|
#define spl_param_ops_int param_ops_int
|
|
#define spl_param_ops_INT param_ops_int
|
|
|
|
#define spl_param_set_long param_set_long
|
|
#define spl_param_get_long param_get_long
|
|
#define spl_param_ops_long param_ops_long
|
|
#define spl_param_ops_LONG param_ops_long
|
|
|
|
#define spl_param_set_uint param_set_uint
|
|
#define spl_param_get_uint param_get_uint
|
|
#define spl_param_ops_uint param_ops_uint
|
|
#define spl_param_ops_UINT param_ops_uint
|
|
|
|
#define spl_param_set_ulong param_set_ulong
|
|
#define spl_param_get_ulong param_get_ulong
|
|
#define spl_param_ops_ulong param_ops_ulong
|
|
#define spl_param_ops_ULONG param_ops_ulong
|
|
|
|
#define spl_param_set_charp param_set_charp
|
|
#define spl_param_get_charp param_get_charp
|
|
#define spl_param_ops_charp param_ops_charp
|
|
#define spl_param_ops_STRING param_ops_charp
|
|
|
|
int spl_param_set_s64(const char *val, zfs_kernel_param_t *kp);
|
|
extern int spl_param_get_s64(char *buffer, zfs_kernel_param_t *kp);
|
|
extern const struct kernel_param_ops spl_param_ops_s64;
|
|
#define spl_param_ops_S64 spl_param_ops_s64
|
|
|
|
extern int spl_param_set_u64(const char *val, zfs_kernel_param_t *kp);
|
|
extern int spl_param_get_u64(char *buffer, zfs_kernel_param_t *kp);
|
|
extern const struct kernel_param_ops spl_param_ops_u64;
|
|
#define spl_param_ops_U64 spl_param_ops_u64
|
|
|
|
/*
|
|
* Declare a module parameter / sysctl node
|
|
*
|
|
* "scope_prefix" the part of the sysctl / sysfs tree the node resides under
|
|
* (currently a no-op on Linux)
|
|
* "name_prefix" the part of the variable name that will be excluded from the
|
|
* exported names on platforms with a hierarchical namespace
|
|
* "name" the part of the variable that will be exposed on platforms with a
|
|
* hierarchical namespace, or as name_prefix ## name on Linux
|
|
* "type" the variable type
|
|
* "perm" the permissions (read/write or read only)
|
|
* "desc" a brief description of the option
|
|
*
|
|
* Examples:
|
|
* ZFS_MODULE_PARAM(zfs_vdev_mirror, zfs_vdev_mirror_, rotating_inc, UINT,
|
|
* ZMOD_RW, "Rotating media load increment for non-seeking I/O's");
|
|
* on FreeBSD:
|
|
* vfs.zfs.vdev.mirror.rotating_inc
|
|
* on Linux:
|
|
* zfs_vdev_mirror_rotating_inc
|
|
*
|
|
* ZFS_MODULE_PARAM(zfs, , dmu_prefetch_max, UINT, ZMOD_RW,
|
|
* "Limit one prefetch call to this size");
|
|
* on FreeBSD:
|
|
* vfs.zfs.dmu_prefetch_max
|
|
* on Linux:
|
|
* dmu_prefetch_max
|
|
*/
|
|
#define ZFS_MODULE_PARAM(scope_prefix, name_prefix, name, type, perm, desc) \
|
|
_Static_assert( \
|
|
sizeof (scope_prefix) == sizeof (enum scope_prefix_types), \
|
|
"" #scope_prefix " size mismatch with enum scope_prefix_types"); \
|
|
module_param_cb(name_prefix ## name, &spl_param_ops_ ## type, \
|
|
&name_prefix ## name, perm); \
|
|
MODULE_PARM_DESC(name_prefix ## name, desc)
|
|
|
|
/*
|
|
* Declare a module parameter / sysctl node
|
|
*
|
|
* "scope_prefix" the part of the the sysctl / sysfs tree the node resides under
|
|
* (currently a no-op on Linux)
|
|
* "name_prefix" the part of the variable name that will be excluded from the
|
|
* exported names on platforms with a hierarchical namespace
|
|
* "name" the part of the variable that will be exposed on platforms with a
|
|
* hierarchical namespace, or as name_prefix ## name on Linux
|
|
* "setfunc" setter function
|
|
* "getfunc" getter function
|
|
* "perm" the permissions (read/write or read only)
|
|
* "desc" a brief description of the option
|
|
*
|
|
* Examples:
|
|
* ZFS_MODULE_PARAM_CALL(zfs_spa, spa_, slop_shift, param_set_slop_shift,
|
|
* param_get_int, ZMOD_RW, "Reserved free space in pool");
|
|
* on FreeBSD:
|
|
* vfs.zfs.spa_slop_shift
|
|
* on Linux:
|
|
* spa_slop_shift
|
|
*/
|
|
#define ZFS_MODULE_PARAM_CALL( \
|
|
scope_prefix, name_prefix, name, setfunc, getfunc, perm, desc) \
|
|
_Static_assert( \
|
|
sizeof (scope_prefix) == sizeof (enum scope_prefix_types), \
|
|
"" #scope_prefix " size mismatch with enum scope_prefix_types"); \
|
|
module_param_call(name_prefix ## name, setfunc, getfunc, \
|
|
&name_prefix ## name, perm); \
|
|
MODULE_PARM_DESC(name_prefix ## name, desc)
|
|
|
|
/*
|
|
* As above, but there is no variable with the name name_prefix ## name,
|
|
* so NULL is passed to module_param_call instead.
|
|
*/
|
|
#define ZFS_MODULE_VIRTUAL_PARAM_CALL( \
|
|
scope_prefix, name_prefix, name, setfunc, getfunc, perm, desc) \
|
|
_Static_assert( \
|
|
sizeof (scope_prefix) == sizeof (enum scope_prefix_types), \
|
|
"" #scope_prefix " size mismatch with enum scope_prefix_types"); \
|
|
module_param_call(name_prefix ## name, setfunc, getfunc, NULL, perm); \
|
|
MODULE_PARM_DESC(name_prefix ## name, desc)
|
|
|
|
#define ZFS_MODULE_PARAM_ARGS const char *buf, zfs_kernel_param_t *kp
|
|
|
|
#endif /* _MOD_COMPAT_H */
|