mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2024-11-19 02:41:00 +03:00
db7f1a91de
A function that returns with no value is a different thing from a
function that doesn't return at all. Those are two orthogonal
concepts, commonly confused.
pthread_create(3) expects a pointer to a start routine that has a
very precise prototype:
void *(*start_routine)(void *);
However, other thread functions, such as kernel ones, expect:
void (*start_routine)(void *);
Providing a different one is incorrect, and has only been working
because the ABIs happen to produce a compatible function.
We should use '_Noreturn void', since it's the natural type, and
then provide a '_Noreturn void *' wrapper for pthread functions.
For consistency, replace most cases of __NORETURN or
__attribute__((noreturn)) by _Noreturn. _Noreturn is understood
by -std=gnu89, so it should be safe to use everywhere.
Ref: https://github.com/openzfs/zfs/pull/13110#discussion_r808450136
Ref: https://software.codidact.com/posts/285972
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Co-authored-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Signed-off-by: Alejandro Colomar <alx.manpages@gmail.com>
Closes #13120
85 lines
2.6 KiB
C
85 lines
2.6 KiB
C
/*
|
|
* Copyright (C) 2007-2010 Lawrence Livermore National Security, LLC.
|
|
* Copyright (C) 2007 The Regents of the University of California.
|
|
* Produced at Lawrence Livermore National Laboratory (cf, DISCLAIMER).
|
|
* Written by Brian Behlendorf <behlendorf1@llnl.gov>.
|
|
* UCRL-CODE-235197
|
|
*
|
|
* This file is part of the SPL, Solaris Porting Layer.
|
|
*
|
|
* The SPL is free software; you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public License as published by the
|
|
* Free Software Foundation; either version 2 of the License, or (at your
|
|
* option) any later version.
|
|
*
|
|
* The SPL is distributed in the hope that it will be useful, but WITHOUT
|
|
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
|
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
|
|
* for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with the SPL. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef _SPL_THREAD_H
|
|
#define _SPL_THREAD_H
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/mm.h>
|
|
#include <linux/spinlock.h>
|
|
#include <linux/kthread.h>
|
|
#include <sys/types.h>
|
|
#include <sys/sysmacros.h>
|
|
#include <sys/tsd.h>
|
|
|
|
/*
|
|
* Thread interfaces
|
|
*/
|
|
#define TP_MAGIC 0x53535353
|
|
|
|
#define TS_SLEEP TASK_INTERRUPTIBLE
|
|
#define TS_RUN TASK_RUNNING
|
|
#define TS_ZOMB EXIT_ZOMBIE
|
|
#define TS_STOPPED TASK_STOPPED
|
|
|
|
typedef void (*thread_func_t)(void *);
|
|
|
|
#define thread_create_named(name, stk, stksize, func, arg, len, \
|
|
pp, state, pri) \
|
|
__thread_create(stk, stksize, (thread_func_t)func, \
|
|
name, arg, len, pp, state, pri)
|
|
|
|
#define thread_create(stk, stksize, func, arg, len, pp, state, pri) \
|
|
__thread_create(stk, stksize, (thread_func_t)func, #func, \
|
|
arg, len, pp, state, pri)
|
|
|
|
#define thread_exit() __thread_exit()
|
|
#define thread_join(t) VERIFY(0)
|
|
#define curthread current
|
|
#define getcomm() current->comm
|
|
#define getpid() current->pid
|
|
|
|
extern kthread_t *__thread_create(caddr_t stk, size_t stksize,
|
|
thread_func_t func, const char *name, void *args, size_t len, proc_t *pp,
|
|
int state, pri_t pri);
|
|
extern __attribute__((noreturn)) void __thread_exit(void);
|
|
extern struct task_struct *spl_kthread_create(int (*func)(void *),
|
|
void *data, const char namefmt[], ...);
|
|
|
|
extern proc_t p0;
|
|
|
|
#ifdef HAVE_SIGINFO
|
|
typedef kernel_siginfo_t spl_kernel_siginfo_t;
|
|
#else
|
|
typedef siginfo_t spl_kernel_siginfo_t;
|
|
#endif
|
|
|
|
#ifdef HAVE_SET_SPECIAL_STATE
|
|
#define spl_set_special_state(x) set_special_state((x))
|
|
#else
|
|
#define spl_set_special_state(x) __set_current_state((x))
|
|
#endif
|
|
|
|
|
|
#endif /* _SPL_THREAD_H */
|