mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2024-11-17 18:11:00 +03:00
a4bfd8ea1b
Up until now no SPL consumer attempted to perform signed 64-bit division so there was no need to support this. That has now changed so I adding 64-bit division support for 32-bit platforms. The signed implementation is based on the unsigned version. Since the have been several bug reports in the past concerning correct 64-bit division on 32-bit platforms I added some long over due regression tests. Much to my surprise the unsigned 64-bit division regression tests failed. This was surprising because __udivdi3() was implemented by simply calling div64_u64() which is provided by the kernel. This meant that the linux kernels 64-bit division algorithm on 32-bit platforms was flawed. After some investigation this turned out to be exactly the case. Because of this I was forced to abandon the kernel helper and instead to fully implement 64-bit division in the spl. There are several published implementation out there on how to do this properly and I settled on one proposed in the book Hacker's Delight. Their proposed algoritm is freely available without restriction and I have just modified it to be linux kernel friendly. The update implementation now passed all the unsigned and signed regression tests. This should be functional, but not fast, which is good enough for out purposes. If you want fast too I'd strongly suggest you upgrade to a 64-bit platform. I have also reported the kernel bug and we'll see if we can't get it fixed up stream. |
||
|---|---|---|
| .. | ||
| .gitignore | ||
| Makefile.in | ||
| splat-atomic.c | ||
| splat-condvar.c | ||
| splat-cred.c | ||
| splat-ctl.c | ||
| splat-generic.c | ||
| splat-internal.h | ||
| splat-kmem.c | ||
| splat-kobj.c | ||
| splat-list.c | ||
| splat-mutex.c | ||
| splat-random.c | ||
| splat-rwlock.c | ||
| splat-taskq.c | ||
| splat-thread.c | ||
| splat-time.c | ||
| splat-vnode.c | ||