mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2024-12-26 03:09:34 +03:00
67395be0c2
* `zstream_do_token()` does not handle failures from `libzfs_init()`
* `ztest_global_vars_to_zdb_args()` does not handle failures from
`calloc()`.
* `zfs_snapshot_nvl()` will pass an offset to a NULL pointer as a
source to `strlcpy()` if the provided nvlist is `NULL`.
We handle these by doing what the existing error handling does for other
errors involving these functions.
Coverity complained about these. It had complained about several more,
but one was fixed by 570ca4441e and
another was a false positive. The remaining complaints labelled
"dereferece null return vaue" involve fetching things stored in
in-kernel data structures via `list_head()/list_next()`,
`AVL_PREV()/AVL_NEXT()` and `zfs_btree_find()`. Most of them occur in
void functions that have no error handling. They are much harder to
analyze than the two fixed in this patch, so they are left for a
follow-up patch.
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu>
Closes #13971
83 lines
2.0 KiB
C
83 lines
2.0 KiB
C
/*
|
|
* CDDL HEADER START
|
|
*
|
|
* The contents of this file are subject to the terms of the
|
|
* Common Development and Distribution License (the "License").
|
|
* You may not use this file except in compliance with the License.
|
|
*
|
|
* You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
|
|
* or https://opensource.org/licenses/CDDL-1.0.
|
|
* See the License for the specific language governing permissions
|
|
* and limitations under the License.
|
|
*
|
|
* When distributing Covered Code, include this CDDL HEADER in each
|
|
* file and include the License file at usr/src/OPENSOLARIS.LICENSE.
|
|
* If applicable, add the following below this CDDL HEADER, with the
|
|
* fields enclosed by brackets "[]" replaced with your own identifying
|
|
* information: Portions Copyright [yyyy] [name of copyright owner]
|
|
*
|
|
* CDDL HEADER END
|
|
*/
|
|
|
|
/*
|
|
* Copyright 2010 Sun Microsystems, Inc. All rights reserved.
|
|
* Use is subject to license terms.
|
|
*
|
|
* Portions Copyright 2012 Martin Matuska <martin@matuska.org>
|
|
*/
|
|
|
|
/*
|
|
* Copyright (c) 2020 by Datto Inc. All rights reserved.
|
|
*/
|
|
|
|
#include <ctype.h>
|
|
#include <libnvpair.h>
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
#include <unistd.h>
|
|
#include <stddef.h>
|
|
|
|
#include <libzfs.h>
|
|
#include <libzfs_core.h>
|
|
|
|
#include <sys/dmu.h>
|
|
#include <sys/zfs_ioctl.h>
|
|
#include "zstream.h"
|
|
|
|
int
|
|
zstream_do_token(int argc, char *argv[])
|
|
{
|
|
char *resume_token = NULL;
|
|
libzfs_handle_t *hdl;
|
|
|
|
if (argc < 2) {
|
|
(void) fprintf(stderr, "Need to pass the resume token\n");
|
|
zstream_usage();
|
|
}
|
|
|
|
resume_token = argv[1];
|
|
|
|
if ((hdl = libzfs_init()) == NULL) {
|
|
(void) fprintf(stderr, "%s\n", libzfs_error_init(errno));
|
|
return (1);
|
|
}
|
|
|
|
nvlist_t *resume_nvl =
|
|
zfs_send_resume_token_to_nvlist(hdl, resume_token);
|
|
|
|
if (resume_nvl == NULL) {
|
|
(void) fprintf(stderr,
|
|
"Unable to parse resume token: %s\n",
|
|
libzfs_error_description(hdl));
|
|
libzfs_fini(hdl);
|
|
return (1);
|
|
}
|
|
|
|
dump_nvlist(resume_nvl, 5);
|
|
nvlist_free(resume_nvl);
|
|
|
|
libzfs_fini(hdl);
|
|
return (0);
|
|
}
|