mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2024-12-28 03:49:38 +03:00
b4e4cbeb20
This fixes an oversight in the Direct I/O PR. There is nothing that stops a process from manipulating the contents of a buffer for a Direct I/O read while the I/O is in flight. This can lead checksum verify failures. However, the disk contents are still correct, and this would lead to false reporting of checksum validation failures. To remedy this, all Direct I/O reads that have a checksum verification failure are treated as suspicious. In the event a checksum validation failure occurs for a Direct I/O read, then the I/O request will be reissued though the ARC. This allows for actual validation to happen and removes any possibility of the buffer being manipulated after the I/O has been issued. Just as with Direct I/O write checksum validation failures, Direct I/O read checksum validation failures are reported though zpool status -d in the DIO column. Also the zevent has been updated to have both: 1. dio_verify_wr -> Checksum verification failure for writes 2. dio_verify_rd -> Checksum verification failure for reads. This allows for determining what I/O operation was the culprit for the checksum verification failure. All DIO errors are reported only on the top-level VDEV. Even though FreeBSD can write protect pages (stable pages) it still has the same issue as Linux with Direct I/O reads. This commit updates the following: 1. Propogates checksum failures for reads all the way up to the top-level VDEV. 2. Reports errors through zpool status -d as DIO. 3. Has two zevents for checksum verify errors with Direct I/O. One for read and one for write. 4. Updates FreeBSD ABD code to also check for ABD_FLAG_FROM_PAGES and handle ABD buffer contents validation the same as Linux. 5. Updated manipulate_user_buffer.c to also manipulate a buffer while a Direct I/O read is taking place. 6. Adds a new ZTS test case dio_read_verify that stress tests the new code. 7. Updated man pages. 8. Added an IMPLY statement to zio_checksum_verify() to make sure that Direct I/O reads are not issued as speculative. 9. Removed self healing through mirror, raidz, and dRAID VDEVs for Direct I/O reads. This issue was first observed when installing a Windows 11 VM on a ZFS dataset with the dataset property direct set to always. The zpool devices would report checksum failures, but running a subsequent zpool scrub would not repair any data and report no errors. Reviewed-by: Tony Hutter <hutter2@llnl.gov> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Alexander Motin <mav@FreeBSD.org> Signed-off-by: Brian Atkinson <batkinson@lanl.gov> Closes #16598 |
||
|---|---|---|
| .. | ||
| checksum | ||
| file | ||
| linux_dos_attributes | ||
| .gitignore | ||
| badsend.c | ||
| btree_test.c | ||
| chg_usr_exec.c | ||
| clone_mmap_cached.c | ||
| clone_mmap_write.c | ||
| clonefile.c | ||
| cp_files.c | ||
| ctime.c | ||
| devname2devid.c | ||
| dir_rd_update.c | ||
| dosmode_readonly_write.c | ||
| draid.c | ||
| ereports.c | ||
| get_diff.c | ||
| getversion.c | ||
| idmap_util.c | ||
| libzfs_input_check.c | ||
| Makefile.am | ||
| manipulate_user_buffer.c | ||
| mkbusy.c | ||
| mkfile.c | ||
| mkfiles.c | ||
| mktree.c | ||
| mmap_exec.c | ||
| mmap_libaio.c | ||
| mmap_seek.c | ||
| mmap_sync.c | ||
| mmapwrite.c | ||
| nvlist_to_lua.c | ||
| readmmap.c | ||
| rename_dir.c | ||
| renameat2.c | ||
| rm_lnkcnt_zero_file.c | ||
| send_doall.c | ||
| stride_dd.c | ||
| suid_write_to_file.c | ||
| threadsappend.c | ||
| truncate_test.c | ||
| user_ns_exec.c | ||
| xattrtest.c | ||
| zed_fd_spill-zedlet.c | ||
| zfs_diff-socket.c | ||