c/mirror_zfs
1
0
Fork 0
mirror of https://git.proxmox.com/git/mirror_zfs.git synced 2024-12-26 11:19:32 +03:00
Code Issues Packages Projects Releases Wiki Activity
4,965 Commits 2 Branches 38 Tags 86 MiB
C 70.4%
Shell 19.4%
Assembly 5.1%
M4 2%
Python 1.8%
Other 1.3%
9abbee4912
Go to file
Tomohiro Kusumi 9abbee4912 Don't enter zvol's rangelock for read bio with size 0 
The SCST driver (SCSI target driver implementation) and possibly
others may issue read bio's with a length of zero bytes. Although
this is unusual, such bio's issued under certain condition can cause
kernel oops, due to how rangelock is implemented.

rangelock_add_reader() is not made to handle overlap of two (or more)
ranges from read bio's with the same offset when one of them has size
of 0, even though they conceptually overlap. Allowing them to enter
rangelock results in kernel oops by dereferencing invalid pointer,
or assertion failure on AVL tree manipulation with debug enabled
kernel module.

For example, this happens when read bio whose (offset, size) is
(0, 0) enters rangelock followed by another read bio with (0, 4096)
when (0, 0) rangelock is still locked, when there are no pending
write bio's. It can also happen with reverse order, which is (0, N)
followed by (0, 0) when (0, N) is still locked. More details
mentioned in #8379.

Kernel Oops on ->make_request_fn() of ZFS volume
https://github.com/zfsonlinux/zfs/issues/8379

Prevent this by returning bio with size 0 as success without entering
rangelock. This has been done for write bio after checking flusher
bio case (though not for the same reason), but not for read bio.

Reviewed-by: Alek Pinchuk <apinchuk@datto.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tomohiro Kusumi <kusumi.tomohiro@osnexus.com>
Closes #8379 
Closes #8401
2019-02-20 10:14:36 -08:00
.github Bump commit subject length to 72 characters 2019-01-08 09:23:05 -08:00
cmd zfs should optionally send holds 2019-02-15 12:41:38 -08:00
config Linux 5.0 compat: Fix bio_set_dev() 2019-01-28 10:11:45 -08:00
contrib ZVOLs should not be allowed to have children 2019-02-08 15:44:15 -08:00
etc ZFS mounted NFSv3 shares fail lock reclaims 2019-02-15 14:40:16 -08:00
include Introduce auxiliary metaslab histograms 2019-02-20 09:59:56 -08:00
lib Fix zdb crash 2019-02-19 11:15:22 -08:00
man zfs mount man page should document legacy behaviour 2019-02-19 11:10:57 -08:00
module Don't enter zvol's rangelock for read bio with size 0 2019-02-20 10:14:36 -08:00
rpm Add diffutils dependency for dkms build 2019-02-20 10:04:05 -08:00
scripts OpenZFS 9185 - Enable testing over NFS in ZFS performance tests 2019-02-04 09:27:37 -08:00
tests Prevent user accounting on readonly pool 2019-02-19 18:41:18 -08:00
udev Add enclosure_symlinks option to vdev_id 2018-12-14 17:27:49 -08:00
.gitignore Verify .gitignore entries 2019-01-15 11:56:29 -08:00
.gitmodules Add zimport.sh compatibility test script 2014-02-21 12:10:31 -08:00
.travis.yml Add .travis.yml 2017-11-13 09:18:18 -08:00
AUTHORS Update build system and packaging 2018-05-29 16:00:33 -07:00
autogen.sh Cause autogen.sh to fail if autoreconf fails 2018-07-06 09:27:37 -07:00
configure.ac Use ZFS version for pyzfs & drop unused reqs file 2019-01-08 15:56:42 -08:00
copy-builtin Allow copy-builtin to work with modified sources 2018-10-17 12:06:05 -07:00
COPYRIGHT Update build system and packaging 2018-05-29 16:00:33 -07:00
LICENSE Update build system and packaging 2018-05-29 16:00:33 -07:00
Makefile.am Verify .gitignore entries 2019-01-15 11:56:29 -08:00
META Tag 0.8.0-rc3 2019-01-14 12:40:42 -08:00
NEWS Add NEWS file 2018-09-18 12:03:47 -07:00
NOTICE Update build system and packaging 2018-05-29 16:00:33 -07:00
README.md Explicitly state supported Linux versions 2018-05-30 20:11:19 -07:00
TEST Update build system and packaging 2018-05-29 16:00:33 -07:00
zfs.release.in Move zfs.release generation to configure step 2012-07-12 12:22:51 -07:00

README.md

img

ZFS on Linux is an advanced file system and volume manager which was originally developed for Solaris and is now maintained by the OpenZFS community.

codecov coverity

Official Resources

Installation

Full documentation for installing ZoL on your favorite Linux distribution can be found at our site.

Contribute & Develop

We have a separate document with contribution guidelines.

Release

ZFS on Linux is released under a CDDL license.
For more details see the NOTICE, LICENSE and COPYRIGHT files; UCRL-CODE-235197

Supported Kernels

  • The META file contains the officially recognized supported kernel versions.