Matthew Ahrens 948423a3d1 zfs promote does not delete livelist of origin ... When a clone is promoted, its livelist is no longer accurate, so it is discarded. If the clone's origin is also a clone (i.e. we are promoting a clone of a clone), then the origin's livelist is also no longer accurate, so it should be discarded, but the code doesn't actually do that. Consider a pool with: * Filesystem A * Clone B, a clone of A * Clone C, a clone of B If we promote C, it discards C's livelist. It should discard B's livelist, but that is not happening. The impact is that when B is destroyed, we use the livelist to find the blocks to free, but the livelist is no longer correct so we end up freeing blocks that are still in use by C. The incorrectly-freed blocks can be reallocated causing checksum errors. And when C is destroyed it can double-free the incorrectly-freed blocks. The problem is that we remove the livelist of `origin_ds->ds_dir`, but the origin snapshot has already been moved to the promoted dsl_dir. So this is actually trying to remove the livelist of the promoted dsl_dir, which was already removed. As explained in a comment in the beginning of `dsl_dataset_promote_sync()`, we need to use the saved `odd` for the origin's dsl_dir. Reviewed-by: Pavel Zakharov <pavel.zakharov@delphix.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: George Wilson <gwilson@delphix.com> Reviewed by: Sara Hartse <sara.hartse@delphix.com> Signed-off-by: Matthew Ahrens <mahrens@delphix.com> Closes #10652		2020-07-31 08:59:00 -07:00
..
callbacks	ZTS: Add a failsafe callback to run after each test	2020-03-10 11:00:56 -07:00
cmd	ZTS: Fix devname2devid build on FreeBSD with libudev	2020-07-22 10:49:22 -07:00
include	Fix lua stack overflow on recursive call to gsub()	2020-07-27 16:11:47 -07:00
tests	zfs promote does not delete livelist of origin	2020-07-31 08:59:00 -07:00
Makefile.am	OpenZFS 7503 - zfs-test should tail ::zfs_dbgmsg on test failure	2017-04-12 13:36:48 -07:00