mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2024-11-18 10:21:01 +03:00
2e7f664f04
I recently gained the ability to run Clang's static analyzer on the linux kernel modules via a few hacks. This extended coverage to code that was previously missed since Clang's static analyzer only looked at code that we built in userspace. Running it against the Linux kernel modules built from my local branch produced a total of 72 reports against my local branch. Of those, 50 were reports of logic errors and 22 were reports of dead code. Since we already had cleaned up all of the previous dead code reports, I felt it would be a good next step to clean up these dead code reports. Clang did a further breakdown of the dead code reports into: Dead assignment 15 Dead increment 2 Dead nested assignment 5 The benefit of cleaning these up, especially in the case of dead nested assignment, is that they can expose places where our error handling is incorrect. A number of them were fairly straight forward. However several were not: In vdev_disk_physio_completion(), not only were we not using the return value from the static function vdev_disk_dio_put(), but nothing used it, so I changed it to return void and removed the existing (void) cast in the other area where we call it in addition to no longer storing it to a stack value. In FSE_createDTable(), the function is dead code. Its helper function FSE_freeDTable() is also dead code, as are the CPP definitions in `module/zstd/include/zstd_compat_wrapper.h`. We just delete it all. In zfs_zevent_wait(), we have an optimization opportunity. cv_wait_sig() returns 0 if there are waiting signals and 1 if there are none. The Linux SPL version literally returns `signal_pending(current) ? 0 : 1)` and FreeBSD implements the same semantics, we can just do `!cv_wait_sig()` in place of `signal_pending(current)` to avoid unnecessarily calling it again. zfs_setattr() on FreeBSD version did not have error handling issue because the code was removed entirely from FreeBSD version. The error is from updating the attribute directory's files. After some thought, I decided to propapage errors on it to userspace. In zfs_secpolicy_tmp_snapshot(), we ignore a lack of permission from the first check in favor of checking three other permissions. I assume this is intentional. In zfs_create_fs(), the return value of zap_update() was not checked despite setting an important version number. I see no backward compatibility reason to permit failures, so we add an assertion to catch failures. Interestingly, Linux is still using ASSERT(error == 0) from OpenSolaris while FreeBSD has switched to the improved ASSERT0(error) from illumos, although illumos has yet to adopt it here. ASSERT(error == 0) was used on Linux while ASSERT0(error) was used on FreeBSD since the entire file needs conversion and that should be the subject of another patch. dnode_move()'s issue was caused by us not having implemented POINTER_IS_VALID() on Linux. We have a stub in `include/os/linux/spl/sys/kmem_cache.h` for it, when it really should be in `include/os/linux/spl/sys/kmem.h` to be consistent with Illumos/OpenSolaris. FreeBSD put both `POINTER_IS_VALID()` and `POINTER_INVALIDATE()` in `include/os/freebsd/spl/sys/kmem.h`, so we copy what it did. Whenever a report was in platform-specific code, I checked the FreeBSD version to see if it also applied to FreeBSD, but it was only relevant a few times. Lastly, the patch that enabled Clang's static analyzer to be run on the Linux kernel modules needs more work before it can be put into a PR. I plan to do that in the future as part of the on-going static analysis work that I am doing. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Closes #14380
207 lines
5.3 KiB
C
207 lines
5.3 KiB
C
/*
|
|
* Copyright (C) 2007-2010 Lawrence Livermore National Security, LLC.
|
|
* Copyright (C) 2007 The Regents of the University of California.
|
|
* Produced at Lawrence Livermore National Laboratory (cf, DISCLAIMER).
|
|
* Written by Brian Behlendorf <behlendorf1@llnl.gov>.
|
|
* UCRL-CODE-235197
|
|
*
|
|
* This file is part of the SPL, Solaris Porting Layer.
|
|
*
|
|
* The SPL is free software; you can redistribute it and/or modify it
|
|
* under the terms of the GNU General Public License as published by the
|
|
* Free Software Foundation; either version 2 of the License, or (at your
|
|
* option) any later version.
|
|
*
|
|
* The SPL is distributed in the hope that it will be useful, but WITHOUT
|
|
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
|
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
|
|
* for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with the SPL. If not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
* Solaris Porting Layer (SPL) Thread Implementation.
|
|
*/
|
|
|
|
#include <sys/thread.h>
|
|
#include <sys/kmem.h>
|
|
#include <sys/tsd.h>
|
|
|
|
/*
|
|
* Thread interfaces
|
|
*/
|
|
typedef struct thread_priv_s {
|
|
unsigned long tp_magic; /* Magic */
|
|
int tp_name_size; /* Name size */
|
|
char *tp_name; /* Name (without _thread suffix) */
|
|
void (*tp_func)(void *); /* Registered function */
|
|
void *tp_args; /* Args to be passed to function */
|
|
size_t tp_len; /* Len to be passed to function */
|
|
int tp_state; /* State to start thread at */
|
|
pri_t tp_pri; /* Priority to start threat at */
|
|
} thread_priv_t;
|
|
|
|
static int
|
|
thread_generic_wrapper(void *arg)
|
|
{
|
|
thread_priv_t *tp = (thread_priv_t *)arg;
|
|
void (*func)(void *);
|
|
void *args;
|
|
|
|
ASSERT(tp->tp_magic == TP_MAGIC);
|
|
func = tp->tp_func;
|
|
args = tp->tp_args;
|
|
set_current_state(tp->tp_state);
|
|
set_user_nice((kthread_t *)current, PRIO_TO_NICE(tp->tp_pri));
|
|
kmem_free(tp->tp_name, tp->tp_name_size);
|
|
kmem_free(tp, sizeof (thread_priv_t));
|
|
|
|
if (func)
|
|
func(args);
|
|
|
|
return (0);
|
|
}
|
|
|
|
/*
|
|
* thread_create() may block forever if it cannot create a thread or
|
|
* allocate memory. This is preferable to returning a NULL which Solaris
|
|
* style callers likely never check for... since it can't fail.
|
|
*/
|
|
kthread_t *
|
|
__thread_create(caddr_t stk, size_t stksize, thread_func_t func,
|
|
const char *name, void *args, size_t len, proc_t *pp, int state, pri_t pri)
|
|
{
|
|
thread_priv_t *tp;
|
|
struct task_struct *tsk;
|
|
char *p;
|
|
|
|
/* Option pp is simply ignored */
|
|
/* Variable stack size unsupported */
|
|
ASSERT(stk == NULL);
|
|
|
|
tp = kmem_alloc(sizeof (thread_priv_t), KM_PUSHPAGE);
|
|
if (tp == NULL)
|
|
return (NULL);
|
|
|
|
tp->tp_magic = TP_MAGIC;
|
|
tp->tp_name_size = strlen(name) + 1;
|
|
|
|
tp->tp_name = kmem_alloc(tp->tp_name_size, KM_PUSHPAGE);
|
|
if (tp->tp_name == NULL) {
|
|
kmem_free(tp, sizeof (thread_priv_t));
|
|
return (NULL);
|
|
}
|
|
|
|
strlcpy(tp->tp_name, name, tp->tp_name_size);
|
|
|
|
/*
|
|
* Strip trailing "_thread" from passed name which will be the func
|
|
* name since the exposed API has no parameter for passing a name.
|
|
*/
|
|
p = strstr(tp->tp_name, "_thread");
|
|
if (p)
|
|
p[0] = '\0';
|
|
|
|
tp->tp_func = func;
|
|
tp->tp_args = args;
|
|
tp->tp_len = len;
|
|
tp->tp_state = state;
|
|
tp->tp_pri = pri;
|
|
|
|
tsk = spl_kthread_create(thread_generic_wrapper, (void *)tp,
|
|
"%s", tp->tp_name);
|
|
if (IS_ERR(tsk))
|
|
return (NULL);
|
|
|
|
wake_up_process(tsk);
|
|
return ((kthread_t *)tsk);
|
|
}
|
|
EXPORT_SYMBOL(__thread_create);
|
|
|
|
/*
|
|
* spl_kthread_create - Wrapper providing pre-3.13 semantics for
|
|
* kthread_create() in which it is not killable and less likely
|
|
* to return -ENOMEM.
|
|
*/
|
|
struct task_struct *
|
|
spl_kthread_create(int (*func)(void *), void *data, const char namefmt[], ...)
|
|
{
|
|
struct task_struct *tsk;
|
|
va_list args;
|
|
char name[TASK_COMM_LEN];
|
|
|
|
va_start(args, namefmt);
|
|
vsnprintf(name, sizeof (name), namefmt, args);
|
|
va_end(args);
|
|
do {
|
|
tsk = kthread_create(func, data, "%s", name);
|
|
if (IS_ERR(tsk)) {
|
|
if (signal_pending(current)) {
|
|
clear_thread_flag(TIF_SIGPENDING);
|
|
continue;
|
|
}
|
|
if (PTR_ERR(tsk) == -ENOMEM)
|
|
continue;
|
|
return (NULL);
|
|
} else {
|
|
return (tsk);
|
|
}
|
|
} while (1);
|
|
}
|
|
EXPORT_SYMBOL(spl_kthread_create);
|
|
|
|
/*
|
|
* The "why" argument indicates the allowable side-effects of the call:
|
|
*
|
|
* FORREAL: Extract the next pending signal from p_sig into p_cursig;
|
|
* stop the process if a stop has been requested or if a traced signal
|
|
* is pending.
|
|
*
|
|
* JUSTLOOKING: Don't stop the process, just indicate whether or not
|
|
* a signal might be pending (FORREAL is needed to tell for sure).
|
|
*/
|
|
int
|
|
issig(int why)
|
|
{
|
|
ASSERT(why == FORREAL || why == JUSTLOOKING);
|
|
|
|
if (!signal_pending(current))
|
|
return (0);
|
|
|
|
if (why != FORREAL)
|
|
return (1);
|
|
|
|
struct task_struct *task = current;
|
|
spl_kernel_siginfo_t __info;
|
|
sigset_t set;
|
|
siginitsetinv(&set, 1ULL << (SIGSTOP - 1) | 1ULL << (SIGTSTP - 1));
|
|
sigorsets(&set, &task->blocked, &set);
|
|
|
|
spin_lock_irq(&task->sighand->siglock);
|
|
#ifdef HAVE_DEQUEUE_SIGNAL_4ARG
|
|
enum pid_type __type;
|
|
if (dequeue_signal(task, &set, &__info, &__type) != 0) {
|
|
#else
|
|
if (dequeue_signal(task, &set, &__info) != 0) {
|
|
#endif
|
|
#ifdef HAVE_SIGNAL_STOP
|
|
spin_unlock_irq(&task->sighand->siglock);
|
|
kernel_signal_stop();
|
|
#else
|
|
if (current->jobctl & JOBCTL_STOP_DEQUEUED)
|
|
spl_set_special_state(TASK_STOPPED);
|
|
|
|
spin_unlock_irq(¤t->sighand->siglock);
|
|
|
|
schedule();
|
|
#endif
|
|
return (0);
|
|
}
|
|
|
|
spin_unlock_irq(&task->sighand->siglock);
|
|
|
|
return (1);
|
|
}
|
|
|
|
EXPORT_SYMBOL(issig);
|