Richard Yao 88b199c24e Cleanup spa_export_common() ... Coverity complains about a possible NULL pointer dereference. This is impossible, but it suspects it because we do a NULL check against `spa->spa_root_vdev`. This NULL check was never necessary and makes the code harder to understand, so we drop it. In particular, we dereference `spa->spa_root_vdev` when `new_state != POOL_STATE_UNINITIALIZED && !hardforce`. The first is only true when spa_reset is called, which only occurs under fault injection. The second is true unless `zpool export -F $POOLNAME` is used. Therefore, we effectively *always* dereference the pointer. In the cases where we do not, there is no reason to think it is unsafe. Therefore this change is safe to make. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Closes #13905		2022-09-27 16:45:51 -07:00
..
abd.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
aggsum.c	Remove bcopy(), bzero(), bcmp()	2022-03-15 15:13:42 -07:00
arc.c	Cleanup: Specify unsignedness on things that should not be signed	2022-09-27 16:42:41 -07:00
blake3_zfs.c	Fix memory allocation issue for BLAKE3 context	2022-06-21 14:32:09 -07:00
blkptr.c	Remove bcopy(), bzero(), bcmp()	2022-03-15 15:13:42 -07:00
bplist.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
bpobj.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
bptree.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
bqueue.c	zfs recv hangs if max recordsize is less than received recordsize	2022-09-16 13:52:25 -07:00
btree.c	Add zfs_btree_verify_intensity kernel module parameter	2022-09-15 16:22:33 -07:00
dataset_kstats.c	Add support for per dataset zil stats and use wmsum counters	2022-07-20 17:14:06 -07:00
dbuf_stats.c	Revert "Reduce dbuf_find() lock contention"	2022-09-22 12:59:41 -07:00
dbuf.c	Cleanup: Specify unsignedness on things that should not be signed	2022-09-27 16:42:41 -07:00
ddt_zap.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
ddt.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
dmu_diff.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
dmu_object.c	Cleanup: Specify unsignedness on things that should not be signed	2022-09-27 16:42:41 -07:00
dmu_objset.c	Revert "Avoid panic with recordsize > 128k, raw sending and no large_blocks"	2022-08-25 13:33:32 -07:00
dmu_recv.c	Cleanup: Specify unsignedness on things that should not be signed	2022-09-27 16:42:41 -07:00
dmu_redact.c	Fix incorrect size given to bqueue_enqueue() call in dmu_redact.c	2022-09-15 16:21:21 -07:00
dmu_send.c	Cleanup: Specify unsignedness on things that should not be signed	2022-09-27 16:42:41 -07:00
dmu_traverse.c	Cleanup: Specify unsignedness on things that should not be signed	2022-09-27 16:42:41 -07:00
dmu_tx.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
dmu_zfetch.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
dmu.c	Cleanup: Specify unsignedness on things that should not be signed	2022-09-27 16:42:41 -07:00
dnode_sync.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
dnode.c	Cleanup: Use OpenSolaris functions to call scheduler	2022-09-12 09:55:37 -07:00
dsl_bookmark.c	Remaining {=> const} char|void *tag	2022-06-29 14:08:59 -07:00
dsl_crypt.c	Fix zpool status in case of unloaded keys	2022-08-22 17:42:01 -07:00
dsl_dataset.c	Cleanup: Specify unsignedness on things that should not be signed	2022-09-27 16:42:41 -07:00
dsl_deadlist.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
dsl_deleg.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
dsl_destroy.c	Prevent zevent list from consuming all of kernel memory	2022-08-22 12:36:22 -07:00
dsl_dir.c	Cleanup: Switch to strlcpy from strncpy	2022-09-27 16:35:29 -07:00
dsl_pool.c	Cleanup: Specify unsignedness on things that should not be signed	2022-09-27 16:42:41 -07:00
dsl_prop.c	Cleanup: Switch to strlcpy from strncpy	2022-09-27 16:35:29 -07:00
dsl_scan.c	Cleanup: Specify unsignedness on things that should not be signed	2022-09-27 16:42:41 -07:00
dsl_synctask.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
dsl_userhold.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
edonr_zfs.c	Remove bcopy(), bzero(), bcmp()	2022-03-15 15:13:42 -07:00
fm.c	Cleanup: Specify unsignedness on things that should not be signed	2022-09-27 16:42:41 -07:00
gzip.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
hkdf.c	Remove bcopy(), bzero(), bcmp()	2022-03-15 15:13:42 -07:00
lz4_zfs.c	Updated the lz4 decompressor	2022-01-07 10:36:49 -08:00
lz4.c	lz4: Cherrypick fix for CVE-2021-3520	2022-01-12 16:14:36 -08:00
lzjb.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
metaslab.c	Cleanup: Specify unsignedness on things that should not be signed	2022-09-27 16:42:41 -07:00
mmp.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
multilist.c	Cleanup: Specify unsignedness on things that should not be signed	2022-09-27 16:42:41 -07:00
objlist.c	Implement Redacted Send/Receive	2019-06-19 09:48:12 -07:00
pathname.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
range_tree.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
refcount.c	Cleanup: Specify unsignedness on things that should not be signed	2022-09-27 16:42:41 -07:00
rrwlock.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
sa.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
sha256.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
skein_zfs.c	Remove bcopy(), bzero(), bcmp()	2022-03-15 15:13:42 -07:00
spa_checkpoint.c	Fix usage of zed_log_msg() and zfs_panic_recover()	2022-09-19 17:32:18 -07:00
spa_config.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
spa_errlog.c	Cleanup: Specify unsignedness on things that should not be signed	2022-09-27 16:42:41 -07:00
spa_history.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
spa_log_spacemap.c	Cleanup: Use OpenSolaris functions to call scheduler	2022-09-12 09:55:37 -07:00
spa_misc.c	Cleanup: Specify unsignedness on things that should not be signed	2022-09-27 16:42:41 -07:00
spa_stats.c	Cleanup: Specify unsignedness on things that should not be signed	2022-09-27 16:42:41 -07:00
spa.c	Cleanup spa_export_common()	2022-09-27 16:45:51 -07:00
space_map.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
space_reftree.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
THIRDPARTYLICENSE.cityhash	OpenZFS 8484 - Implement aggregate sum and use for arc counters	2018-06-06 09:35:59 -07:00
THIRDPARTYLICENSE.cityhash.descrip	OpenZFS 8484 - Implement aggregate sum and use for arc counters	2018-06-06 09:35:59 -07:00
txg.c	Cleanup: Specify unsignedness on things that should not be signed	2022-09-27 16:42:41 -07:00
uberblock.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
unique.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
vdev_cache.c	Cleanup: Specify unsignedness on things that should not be signed	2022-09-27 16:42:41 -07:00
vdev_draid_rand.c	Distributed Spare (dRAID) Feature	2020-11-13 13:51:51 -08:00
vdev_draid.c	vdev_draid_lookup_map() should not iterate outside draid_maps	2022-09-12 12:51:17 -07:00
vdev_indirect_births.c	Remove bcopy(), bzero(), bcmp()	2022-03-15 15:13:42 -07:00
vdev_indirect_mapping.c	Remove bcopy(), bzero(), bcmp()	2022-03-15 15:13:42 -07:00
vdev_indirect.c	Cleanup: Specify unsignedness on things that should not be signed	2022-09-27 16:42:41 -07:00
vdev_initialize.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
vdev_label.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
vdev_mirror.c	Improve too large physical ashift handling	2022-09-08 10:30:53 -07:00
vdev_missing.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
vdev_queue.c	Cleanup: Specify unsignedness on things that should not be signed	2022-09-27 16:42:41 -07:00
vdev_raidz_math_aarch64_neon_common.h	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
vdev_raidz_math_aarch64_neon.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
vdev_raidz_math_aarch64_neonx2.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
vdev_raidz_math_avx2.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
vdev_raidz_math_avx512bw.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
vdev_raidz_math_avx512f.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
vdev_raidz_math_impl.h	Cleanup Raid-Z Typo fixes	2022-09-06 09:43:21 -07:00
vdev_raidz_math_powerpc_altivec_common.h	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
vdev_raidz_math_powerpc_altivec.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
vdev_raidz_math_scalar.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
vdev_raidz_math_sse2.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
vdev_raidz_math_ssse3.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
vdev_raidz_math.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
vdev_raidz.c	Improve too large physical ashift handling	2022-09-08 10:30:53 -07:00
vdev_rebuild.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
vdev_removal.c	Cleanup: Specify unsignedness on things that should not be signed	2022-09-27 16:42:41 -07:00
vdev_root.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
vdev_trim.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
vdev.c	Cleanup: Specify unsignedness on things that should not be signed	2022-09-27 16:42:41 -07:00
zap_leaf.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
zap_micro.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
zap.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
zcp_get.c	Cleanup: Switch to strlcpy from strncpy	2022-09-27 16:35:29 -07:00
zcp_global.c	OpenZFS 8600 - ZFS channel programs - snapshot	2018-02-08 15:29:24 -08:00
zcp_iter.c	module/*.ko: prune .data, global .rodata	2022-01-14 15:37:55 -08:00
zcp_set.c	Support setting user properties in a channel program	2020-02-14 13:41:42 -08:00
zcp_synctask.c	Add zfs.sync.snapshot_rename	2022-09-02 13:31:19 -07:00
zcp.c	Remaining {=> const} char|void *tag	2022-06-29 14:08:59 -07:00
zfeature.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
zfs_byteswap.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
zfs_chksum.c	Fix BLAKE3 tuneable and module loading on Linux and FreeBSD	2022-09-16 14:25:53 -07:00
zfs_fm.c	Fix unchecked return values and unused return values	2022-09-23 16:52:03 -07:00
zfs_fuid.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
zfs_ioctl.c	Cleanup: Specify unsignedness on things that should not be signed	2022-09-27 16:42:41 -07:00
zfs_log.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
zfs_onexit.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
zfs_quota.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
zfs_ratelimit.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
zfs_replay.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
zfs_rlock.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
zfs_sa.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
zfs_vnops.c	zfs_enter rework	2022-09-16 13:36:47 -07:00
zil.c	Cleanup: Specify unsignedness on things that should not be signed	2022-09-27 16:42:41 -07:00
zio_checksum.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
zio_compress.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
zio_inject.c	Cleanup: Switch to strlcpy from strncpy	2022-09-27 16:35:29 -07:00
zio.c	Cleanup: Specify unsignedness on things that should not be signed	2022-09-27 16:42:41 -07:00
zle.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
zrlock.c	Replace dead opensolaris.org license link	2022-07-11 14:16:13 -07:00
zthr.c	Switch from _Noreturn to __attribute__((noreturn))	2022-03-23 08:51:00 -07:00
zvol.c	Fix unchecked return values and unused return values	2022-09-23 16:52:03 -07:00