mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2024-11-17 18:11:00 +03:00
7b3e34ba5a
Rolling back a mounted filesystem with open file handles and cached dentries+inodes never worked properly in ZoL. The major issue was that Linux provides no easy mechanism for modules to invalidate the inode cache for a file system. Because of this it was possible that an inode from the previous filesystem would not get properly dropped from the cache during rolling back. Then a new inode with the same inode number would be create and collide with the existing cached inode. Ideally this would trigger an VERIFY() but in practice the error wasn't handled and it would just NULL reference. Luckily, this issue can be resolved by sprucing up the existing Solaris zfs_rezget() functionality for the Linux VFS. The way it works now is that when a file system is rolled back all the cached inodes will be traversed and refetched from disk. If a version of the cached inode exists on disk the in-core copy will be updated accordingly. If there is no match for that object on disk it will be unhashed from the inode cache and marked as stale. This will effectively make the inode unfindable for lookups allowing the inode number to be immediately recycled. The inode will then only be accessible from the cached dentries. Subsequent dentry lookups which reference a stale inode will result in the dentry being invalidated. Once invalidated the dentry will drop its reference on the inode allowing it to be safely pruned from the cache. Special care is taken for negative dentries since they do not reference any inode. These dentires will be invalidate based on when they were added to the dentry cache. Entries added before the last rollback will be invalidate to prevent them from masking real files in the dataset. Two nice side effects of this fix are: * Removes the dependency on spl_invalidate_inodes(), it can now be safely removed from the SPL when we choose to do so. * zfs_znode_alloc() no longer requires a dentry to be passed. This effectively reverts this portition of the code to its upstream counterpart. The dentry is not instantiated more correctly in the Linux ZPL layer. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Ned Bass <bass6@llnl.gov> Closes #795
93 lines
3.2 KiB
C
93 lines
3.2 KiB
C
/*
|
|
* CDDL HEADER START
|
|
*
|
|
* The contents of this file are subject to the terms of the
|
|
* Common Development and Distribution License (the "License").
|
|
* You may not use this file except in compliance with the License.
|
|
*
|
|
* You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
|
|
* or http://www.opensolaris.org/os/licensing.
|
|
* See the License for the specific language governing permissions
|
|
* and limitations under the License.
|
|
*
|
|
* When distributing Covered Code, include this CDDL HEADER in each
|
|
* file and include the License file at usr/src/OPENSOLARIS.LICENSE.
|
|
* If applicable, add the following below this CDDL HEADER, with the
|
|
* fields enclosed by brackets "[]" replaced with your own identifying
|
|
* information: Portions Copyright [yyyy] [name of copyright owner]
|
|
*
|
|
* CDDL HEADER END
|
|
*/
|
|
/*
|
|
* Copyright (c) 2011, Lawrence Livermore National Security, LLC.
|
|
*/
|
|
|
|
#ifndef _SYS_ZPL_H
|
|
#define _SYS_ZPL_H
|
|
|
|
#include <sys/vfs.h>
|
|
#include <linux/vfs_compat.h>
|
|
#include <linux/xattr_compat.h>
|
|
#include <linux/dcache_compat.h>
|
|
#include <linux/exportfs.h>
|
|
#include <linux/writeback.h>
|
|
#include <linux/falloc.h>
|
|
|
|
/* zpl_inode.c */
|
|
extern void zpl_vap_init(vattr_t *vap, struct inode *dir,
|
|
zpl_umode_t mode, cred_t *cr);
|
|
|
|
extern const struct inode_operations zpl_inode_operations;
|
|
extern const struct inode_operations zpl_dir_inode_operations;
|
|
extern const struct inode_operations zpl_symlink_inode_operations;
|
|
extern const struct inode_operations zpl_special_inode_operations;
|
|
extern dentry_operations_t zpl_dentry_operations;
|
|
|
|
/* zpl_file.c */
|
|
extern ssize_t zpl_read_common(struct inode *ip, const char *buf,
|
|
size_t len, loff_t pos, uio_seg_t segment, int flags, cred_t *cr);
|
|
extern ssize_t zpl_write_common(struct inode *ip, const char *buf,
|
|
size_t len, loff_t pos, uio_seg_t segment, int flags, cred_t *cr);
|
|
extern long zpl_fallocate_common(struct inode *ip, int mode,
|
|
loff_t offset, loff_t len);
|
|
|
|
extern const struct address_space_operations zpl_address_space_operations;
|
|
extern const struct file_operations zpl_file_operations;
|
|
extern const struct file_operations zpl_dir_file_operations;
|
|
|
|
/* zpl_super.c */
|
|
extern void zpl_prune_sbs(int64_t bytes_to_scan, void *private);
|
|
|
|
typedef struct zpl_mount_data {
|
|
const char *z_osname; /* Dataset name */
|
|
void *z_data; /* Mount options string */
|
|
} zpl_mount_data_t;
|
|
|
|
extern const struct super_operations zpl_super_operations;
|
|
extern const struct export_operations zpl_export_operations;
|
|
extern struct file_system_type zpl_fs_type;
|
|
|
|
/* zpl_xattr.c */
|
|
extern ssize_t zpl_xattr_list(struct dentry *dentry, char *buf, size_t size);
|
|
extern int zpl_xattr_security_init(struct inode *ip, struct inode *dip,
|
|
const struct qstr *qstr);
|
|
|
|
extern xattr_handler_t *zpl_xattr_handlers[];
|
|
|
|
/* zpl_ctldir.c */
|
|
extern const struct file_operations zpl_fops_root;
|
|
extern const struct inode_operations zpl_ops_root;
|
|
|
|
extern const struct file_operations zpl_fops_snapdir;
|
|
extern const struct inode_operations zpl_ops_snapdir;
|
|
#ifdef HAVE_AUTOMOUNT
|
|
extern const struct dentry_operations zpl_dops_snapdirs;
|
|
#else
|
|
extern const struct inode_operations zpl_ops_snapdirs;
|
|
#endif /* HAVE_AUTOMOUNT */
|
|
|
|
extern const struct file_operations zpl_fops_shares;
|
|
extern const struct inode_operations zpl_ops_shares;
|
|
|
|
#endif /* _SYS_ZPL_H */
|