mirror of
https://git.proxmox.com/git/mirror_zfs.git
synced 2025-02-04 14:24:22 +03:00
f1a05fa114
Lookups in the snapshot control directory for an existing snapshot fail with ENOENT if an earlier lookup failed before the snapshot was created. This is because the earlier lookup causes a negative dentry to be cached which is never invalidated. The bug can be reproduced as follows (the second ls should succeed): $ ls /tank/.zfs/snapshot/s ls: cannot access /tank/.zfs/snapshot/s: No such file or directory $ zfs snap tank@s $ ls /tank/.zfs/snapshot/s ls: cannot access /tank/.zfs/snapshot/s: No such file or directory To remedy this, always invalidate cached dentries in the snapshot control directory. Since these entries never exist on disk there is no significant performance penalty for the extra lookups. Signed-off-by: Brian Behlendorf <behlendorf1@llnl.gov> Closes #1192
64 lines
1.8 KiB
C
64 lines
1.8 KiB
C
/*
|
|
* CDDL HEADER START
|
|
*
|
|
* The contents of this file are subject to the terms of the
|
|
* Common Development and Distribution License (the "License").
|
|
* You may not use this file except in compliance with the License.
|
|
*
|
|
* You can obtain a copy of the license at usr/src/OPENSOLARIS.LICENSE
|
|
* or http://www.opensolaris.org/os/licensing.
|
|
* See the License for the specific language governing permissions
|
|
* and limitations under the License.
|
|
*
|
|
* When distributing Covered Code, include this CDDL HEADER in each
|
|
* file and include the License file at usr/src/OPENSOLARIS.LICENSE.
|
|
* If applicable, add the following below this CDDL HEADER, with the
|
|
* fields enclosed by brackets "[]" replaced with your own identifying
|
|
* information: Portions Copyright [yyyy] [name of copyright owner]
|
|
*
|
|
* CDDL HEADER END
|
|
*/
|
|
|
|
/*
|
|
* Copyright (C) 2011 Lawrence Livermore National Security, LLC.
|
|
*/
|
|
|
|
#ifndef _ZFS_DCACHE_H
|
|
#define _ZFS_DCACHE_H
|
|
|
|
#include <linux/dcache.h>
|
|
|
|
#define dname(dentry) ((char *)((dentry)->d_name.name))
|
|
#define dlen(dentry) ((int)((dentry)->d_name.len))
|
|
|
|
#ifndef HAVE_D_MAKE_ROOT
|
|
#define d_make_root(inode) d_alloc_root(inode)
|
|
#endif /* HAVE_D_MAKE_ROOT */
|
|
|
|
/*
|
|
* 2.6.30 API change,
|
|
* The const keyword was added to the 'struct dentry_operations' in
|
|
* the dentry structure. To handle this we define an appropriate
|
|
* dentry_operations_t typedef which can be used.
|
|
*/
|
|
#ifdef HAVE_CONST_DENTRY_OPERATIONS
|
|
typedef const struct dentry_operations dentry_operations_t;
|
|
#else
|
|
typedef struct dentry_operations dentry_operations_t;
|
|
#endif
|
|
|
|
/*
|
|
* 2.6.38 API change,
|
|
* Added d_set_d_op() helper function which sets some flags in
|
|
* dentry->d_flags based on which operations are defined.
|
|
*/
|
|
#ifndef HAVE_D_SET_D_OP
|
|
static inline void
|
|
d_set_d_op(struct dentry *dentry, dentry_operations_t *op)
|
|
{
|
|
dentry->d_op = op;
|
|
}
|
|
#endif /* HAVE_D_SET_D_OP */
|
|
|
|
#endif /* _ZFS_DCACHE_H */
|