mirror_zfs/module
Serapheim Dimitropoulos 7637ef8d23 OpenZFS 9591 - ms_shift can be incorrectly changed
ms_shift can be incorrectly changed changed in MOS config for
indirect vdevs that have been historically expanded

According to spa_config_update() we expect new vdevs to have
vdev_ms_array equal to 0 and then we go ahead and set their metaslab
size. The problem is that indirect vdevs also have vdev_ms_array == 0
because their metaslabs are destroyed once their removal is done.

As a result, if a vdev was expanded and then removed may have its
ms_shift changed if another vdev was added after its removal.
Fortunately this behavior does not cause any type of crash or bad
behavior in the kernel but it can confuse zdb and anyone doing any kind
of analysis of the history of the pools.

Authored by: Serapheim Dimitropoulos <serapheim@delphix.com>
Reviewed by: Matthew Ahrens <mahrens@delphix.com>
Reviewed by: George Wilson <gwilson@zfsmail.com>
Reviewed by: John Kennedy <john.kennedy@delphix.com>
Reviewed by: Prashanth Sreenivasa <pks@delphix.com>
Reviewed by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Tim Chase <tim@chase2k.com>
Ported-by: Tim Chase <tim@chase2k.com>

OpenZFS-commit: https://github.com/openzfs/openzfs/pull/651
OpenZFS-issue: https://illumos.org/issues/9591a
External-issue: DLPX-58879
Closes #7644
2018-06-21 09:35:26 -07:00
..
avl Update build system and packaging 2018-05-29 16:00:33 -07:00
icp Update build system and packaging 2018-05-29 16:00:33 -07:00
lua Update build system and packaging 2018-05-29 16:00:33 -07:00
nvpair Update build system and packaging 2018-05-29 16:00:33 -07:00
spl Add pool state /proc entry, "SUSPENDED" pools 2018-06-06 09:33:54 -07:00
unicode Update build system and packaging 2018-05-29 16:00:33 -07:00
zcommon OpenZFS 9235 - rename zpool_rewind_policy_t to zpool_load_policy_t 2018-06-04 14:54:20 -07:00
zfs OpenZFS 9591 - ms_shift can be incorrectly changed 2018-06-21 09:35:26 -07:00
.gitignore Prepare SPL repo to merge with ZFS repo 2018-05-29 14:51:39 -07:00
Makefile.in Update build system and packaging 2018-05-29 16:00:33 -07:00